From patchwork Wed Feb 22 11:06:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 655910 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED775C636D6 for ; Wed, 22 Feb 2023 11:07:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231769AbjBVLHN (ORCPT ); Wed, 22 Feb 2023 06:07:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59172 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231175AbjBVLHK (ORCPT ); Wed, 22 Feb 2023 06:07:10 -0500 Received: from mail-pg1-x534.google.com (mail-pg1-x534.google.com [IPv6:2607:f8b0:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E92CD392B8 for ; Wed, 22 Feb 2023 03:07:03 -0800 (PST) Received: by mail-pg1-x534.google.com with SMTP id c32so4088675pgc.7 for ; Wed, 22 Feb 2023 03:07:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pDg7lq2x44X37ra1GNdaDrKzjiETRuIzGhmCMqpU5cE=; b=r1B1OjeRgYE2hqrawLKj4xpLJVqD/NOJn2YO5tpvGrJoVa63RKypdjpj7HIRczRaRq 4EJSObe8KfRHFxJGyQ/5jOv5SajH0HE7OCEeJuBmMwMUwQjgw96J13XWoBgSvhs68U4u oMFV2k0JCMxS0aFax7sI1VqIq1Blgx2Z9M9xJAR3b5/N1z699TcZHAcRIYFDq5vzfm4E oMRdVlhqbsVRnpS7qVtEJuDP0ffT/nlbbiryV/2HEPVWlknxa0uNTpfuQ2rDBjfyUdt3 wEgbEl7QURSywxkwf3cxQGTzx1qsPwfjyqxd5P+yeUUHcI1fZJ6eyAiJhDxzat3cRYM6 yz7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pDg7lq2x44X37ra1GNdaDrKzjiETRuIzGhmCMqpU5cE=; b=A9X1OsOhc2tOyucURT5iYDNpnr9tobpm4LvE39RzELFs5M7MEEk7l2E8/7xT8noFAi p72HH5xecXcgM0KLj34WY/V6Rzwv615zPsfVb8um0XmpKh+zY+11UWH23Aenr4ZIqonf gp7TX86AvG+IZkE+W8cpQHbQcNW3TZlRBWAsuLtfkL26/axZI6A/07t31mtW6VbLu/J6 A3yLa1p/rLPw0EyrrPt8hjVqmKBTlv7XEqFw3oN25VTH2OwVddW0yZ7ElQOkBv71HSJ0 pHpUJk/8Jlg+XmOIi3eSFjTxIiqA0XbOijlF7GMEUCvNIPQA7kUv9TuqV3T/UbJlKhFW Uh8w== X-Gm-Message-State: AO0yUKVXvz0pS7b+efpBSMfNvLTmT7g2Z17zR4EaodUfvYwwWR2z5fHT HUm5CwqUvwUiqFs2cp9tTF40GA== X-Google-Smtp-Source: AK7set9fKC+RycmDf0F/GqylOk93+YTe3GQqwm+VQ6ERcOpZORV12Lo/ieqtt/fuMQqEOwm55GXHRw== X-Received: by 2002:a62:52d5:0:b0:5a8:ad9d:83f with SMTP id g204-20020a6252d5000000b005a8ad9d083fmr6289573pfb.24.1677064023416; Wed, 22 Feb 2023 03:07:03 -0800 (PST) Received: from localhost ([122.172.83.155]) by smtp.gmail.com with ESMTPSA id f15-20020aa78b0f000000b005ac419804d3sm4822377pfd.186.2023.02.22.03.07.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Feb 2023 03:07:02 -0800 (PST) From: Viresh Kumar To: Jun Nie , Viresh Kumar , Nishanth Menon , Stephen Boyd , "Rafael J. Wysocki" Cc: Viresh Kumar , linux-pm@vger.kernel.org, Vincent Guittot , Manivannan Sadhasivam , linux-kernel@vger.kernel.org Subject: [PATCH 3/3] OPP: Allow platforms to add a set_required_opps() callback Date: Wed, 22 Feb 2023 16:36:39 +0530 Message-Id: X-Mailer: git-send-email 2.31.1.272.g89b43f80a514 In-Reply-To: References: MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org We currently configure required-opps only for genpds, as we aren't really sure what's required of the other use cases. This patch allows platforms to add their own set_required_opps() helper. Signed-off-by: Viresh Kumar --- Jun, I think this can replace the cpufreq notification from the devfreq driver (get_target_freq_with_cpufreq()), which is used currently only by mtk-cci-devfreq.c. Instead of the notification, the aggregation of the requests for the devfreq device can be done within this callback. What do you say ? --- drivers/opp/core.c | 35 +++++++++++++++++++++++++++++++++++ drivers/opp/opp.h | 4 ++-- include/linux/pm_opp.h | 5 +++++ 3 files changed, 42 insertions(+), 2 deletions(-) diff --git a/drivers/opp/core.c b/drivers/opp/core.c index 954c94865cf5..22985ad7af79 100644 --- a/drivers/opp/core.c +++ b/drivers/opp/core.c @@ -2421,8 +2421,35 @@ static void _opp_detach_genpd(struct opp_table *opp_table) mutex_unlock(&opp_table->genpd_virt_dev_lock); } +/** + * _opp_set_required_opps_helper() - Register custom set required opps helper. + * @dev: Device for which the helper is getting registered. + * @set_required_opps: Custom set required opps helper. + * + * This must be called before any OPPs are initialized for the device. + */ +static void _opp_set_required_opps_helper(struct opp_table *opp_table, + set_required_opps_t set_required_opps) +{ + opp_table->set_required_opps = set_required_opps; +} + +/** + * _opp_put_required_opps_helper() - Releases resources blocked for + * required opps helper. + * @opp_table: OPP table returned from _opp_set_required_opps_helper(). + * + * Release resources blocked for platform specific required opps helper. + */ +static void _opp_put_required_opps_helper(struct opp_table *opp_table) +{ + opp_table->set_required_opps = NULL; +} + static void _opp_clear_config(struct opp_config_data *data) { + if (data->flags & OPP_CONFIG_REQUIRED_OPPS) + _opp_put_required_opps_helper(data->opp_table); if (data->flags & OPP_CONFIG_GENPD) _opp_detach_genpd(data->opp_table); if (data->flags & OPP_CONFIG_REGULATOR) @@ -2546,6 +2573,14 @@ int dev_pm_opp_set_config(struct device *dev, struct dev_pm_opp_config *config) data->flags |= OPP_CONFIG_GENPD; } + /* Required opps helper */ + if (config->set_required_opps) { + _opp_set_required_opps_helper(opp_table, + config->set_required_opps); + + data->flags |= OPP_CONFIG_REQUIRED_OPPS; + } + ret = xa_alloc(&opp_configs, &id, data, XA_LIMIT(1, INT_MAX), GFP_KERNEL); if (ret) diff --git a/drivers/opp/opp.h b/drivers/opp/opp.h index 2a057c42ddf4..54cfeb894f5d 100644 --- a/drivers/opp/opp.h +++ b/drivers/opp/opp.h @@ -35,6 +35,7 @@ extern struct list_head opp_tables, lazy_opp_tables; #define OPP_CONFIG_PROP_NAME BIT(3) #define OPP_CONFIG_SUPPORTED_HW BIT(4) #define OPP_CONFIG_GENPD BIT(5) +#define OPP_CONFIG_REQUIRED_OPPS BIT(6) /** * struct opp_config_data - data for set config operations @@ -235,8 +236,7 @@ struct opp_table { bool enabled; bool genpd_performance_state; bool is_genpd; - int (*set_required_opps)(struct device *dev, - struct opp_table *opp_table, struct dev_pm_opp *opp, bool scaling_down); + set_required_opps_t set_required_opps; #ifdef CONFIG_DEBUG_FS struct dentry *dentry; diff --git a/include/linux/pm_opp.h b/include/linux/pm_opp.h index dc1fb5890792..5a8c0cc50c96 100644 --- a/include/linux/pm_opp.h +++ b/include/linux/pm_opp.h @@ -64,6 +64,9 @@ typedef int (*config_regulators_t)(struct device *dev, typedef int (*config_clks_t)(struct device *dev, struct opp_table *opp_table, struct dev_pm_opp *opp, void *data, bool scaling_down); +typedef int (*set_required_opps_t)(struct device *dev, struct opp_table *opp_table, + struct dev_pm_opp *opp, bool scaling_down); + /** * struct dev_pm_opp_config - Device OPP configuration values * @clk_names: Clk names, NULL terminated array. @@ -76,6 +79,7 @@ typedef int (*config_clks_t)(struct device *dev, struct opp_table *opp_table, * @genpd_names: Null terminated array of pointers containing names of genpd to * attach. * @virt_devs: Pointer to return the array of virtual devices. + * @set_required_opps: Custom set required opps helper. * * This structure contains platform specific OPP configurations for the device. */ @@ -90,6 +94,7 @@ struct dev_pm_opp_config { const char * const *regulator_names; const char * const *genpd_names; struct device ***virt_devs; + set_required_opps_t set_required_opps; }; #if defined(CONFIG_PM_OPP)