From patchwork Thu Aug 29 08:07:29 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 172542 Delivered-To: patch@linaro.org Received: by 2002:a92:d204:0:0:0:0:0 with SMTP id y4csp1868953ily; Thu, 29 Aug 2019 01:07:36 -0700 (PDT) X-Google-Smtp-Source: APXvYqzsX0+oPPQcJkBEFVSCyksSE75cEBOPrgaUJqqglC/ADop0Q+zVp4zhl3eqeSYzq2z7ic2A X-Received: by 2002:a63:9249:: with SMTP id s9mr6914133pgn.356.1567066056310; Thu, 29 Aug 2019 01:07:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567066056; cv=none; d=google.com; s=arc-20160816; b=pgNEsiMkSgpilf5m/+VdA9Qwtu8jdv3SgO9V1kwjg5F3TMS1YZEj5SEBkZgxA1U5Z1 FU2uFMz3HmnuqqgBFH44nEARZYcrZmCn9wAXcSlI9B0Ro2RhiEvTZ3k5sSOAsUSpvyFo NgyrRhSTass4ZYBUcYLTSpLxBn6clckhjheARUrq+Rxfz8oVrzw5jCWq/cdJ3L2roXBl Zbj4xm6aTf7AcMr4QWGjpmhtA8OIx9+bCXvsbPxEwF6dV6PFMdBJtt56Ga1kcvmi5uZY pIUGBXBitNI7axGpIny15HVQUNIudPteo5hFOQzATOmf4mSGf20cVuO2Bbjr4MueuE7s u+4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=nq8To/7J1PSl3z5Lxbp7yzGH/kF9sw7bMQzb25E4PoY=; b=tstIcu8Z9eH00JYYH4+/7RkvgxUi3Awl7RfOG8wNNyOCJS8I8QPCsti6qWY2lNSFX7 IjzsKe/w4cWeNHliO38/R7PP6lPgJhGEPo2kLITfrnhhA98uqKJ3HqPVhA7121y9iZO2 olLFDdGzZa9V/G3EcpkXdXuEaImDSO5A474hm22TS4276Iwn+v8sLFvAAi0XcJw78xbB udlOvdF2DQcLRkciBA4sXEqNsHOy9Zyv3vHxGwutST55t4Rq9nE/RJFqU9Ye0/QmyqQb ObfdGgxziJMyrV5yagZn9Z+2W+95GcJS/sCpZFPQ6KXQOhvx9zvdIL1Q73dx/HExqOeb sqrw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Iy0ht6TD; spf=pass (google.com: best guess record for domain of linux-pm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-pm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l6si1311902pgg.489.2019.08.29.01.07.35; Thu, 29 Aug 2019 01:07:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-pm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Iy0ht6TD; spf=pass (google.com: best guess record for domain of linux-pm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-pm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726081AbfH2IHf (ORCPT + 11 others); Thu, 29 Aug 2019 04:07:35 -0400 Received: from mail-pl1-f196.google.com ([209.85.214.196]:46978 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725939AbfH2IHf (ORCPT ); Thu, 29 Aug 2019 04:07:35 -0400 Received: by mail-pl1-f196.google.com with SMTP id o3so1192250plb.13 for ; Thu, 29 Aug 2019 01:07:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=nq8To/7J1PSl3z5Lxbp7yzGH/kF9sw7bMQzb25E4PoY=; b=Iy0ht6TDTmGshmaHrPiBh24TX0AOyLc+aZTieNTwrNKdltnBow1I+wT9how0xATzcy T8TdaugNXk89y2QVrWB796cybqqB4Dikq5iXUtErxvtwGNX7tSit17FeRbUsp3NRs+XB kLuHjobpjXTEZUFzCJRlDt5rNF6mo6brysZcwCcfPefgcXv73TJZVhykZXQHH6LMB4ZJ zKwzC5lHD5weE9RZ8BP5IclarFlphjIqZ1UiVrzies2f0YDEk7uWIFKe2s/27GDnQ8pS LnzbkLLv1Zr4UFJThGWzARqALmWXqEkX6oWv+rdR4zpDv7gRNVjTy1tJrvjcoPRsDNCX uGGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=nq8To/7J1PSl3z5Lxbp7yzGH/kF9sw7bMQzb25E4PoY=; b=RyFH3p3xcTJJ+WlJ7ILICVXf202a4xV/bVxUO+rQucLyDwjQ9yIiy1eNAGD0IJqKFw Z2yCNXre3nx3dTMkIl+snOIC+tQ11CBavIlH2bPl5StKCyjHZY0FmOIxao0lGLcR9MTW QKL1HlK4Do+tZLaM+IjCb1CHxrDKoVwZu1srFU+Nnhtc76vqrQ2P/pwK/DP4fv1c+mC+ djAZc3WmIr90pcOr9GTt4oTLlRtLqk6ysfU1f0RZfGEQLYK7c6d9kqz9tLIqRys1e8oq HRaWuQ5qTs6o5YXkbmitZFQcVg7wDSZo8KHWJvoe7g5wtYjrSh5dsq0XQjk3GuRSLIMb p/Pw== X-Gm-Message-State: APjAAAXbj/Kt2Ri37TANNBbwFhiA6/Hbmu6tWcEwLvGzgg1o8OPr3o97 eF/mYUJbAmMoj0WIJBVTlVaas6AspGw= X-Received: by 2002:a17:902:8f85:: with SMTP id z5mr8752168plo.328.1567066054551; Thu, 29 Aug 2019 01:07:34 -0700 (PDT) Received: from localhost ([122.167.132.221]) by smtp.gmail.com with ESMTPSA id p2sm2637128pfb.122.2019.08.29.01.07.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 29 Aug 2019 01:07:33 -0700 (PDT) From: Viresh Kumar To: Georgi Djakov Cc: Viresh Kumar , Vincent Guittot , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] interconnect: Disallow interconnect core to be built as a module Date: Thu, 29 Aug 2019 13:37:29 +0530 Message-Id: X-Mailer: git-send-email 2.21.0.rc0.269.g1a574e7a288b MIME-Version: 1.0 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Building individual drivers as modules is fine but allowing a core framework to be built as a module makes it really complex and should be avoided. Whatever uses the interconnect core APIs must also be built as a module if interconnect core is built as module, else we will see compilation failures. If another core framework (like cpufreq, clk, etc), that can't be built as module, needs to use interconnect APIs then we will start seeing compilation failures with allmodconfig configurations as the symbols (like of_icc_get()) used in other frameworks will not be available in the built-in image. Disallow the interconnect core to be built as a module to avoid all these issues. Signed-off-by: Viresh Kumar --- drivers/interconnect/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.21.0.rc0.269.g1a574e7a288b Reviewed-by: Bjorn Andersson diff --git a/drivers/interconnect/Kconfig b/drivers/interconnect/Kconfig index bfa4ca3ab7a9..b6ea8f0a6122 100644 --- a/drivers/interconnect/Kconfig +++ b/drivers/interconnect/Kconfig @@ -1,6 +1,6 @@ # SPDX-License-Identifier: GPL-2.0-only menuconfig INTERCONNECT - tristate "On-Chip Interconnect management support" + bool "On-Chip Interconnect management support" help Support for management of the on-chip interconnects.