From patchwork Thu Oct 16 08:15:44 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 38798 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ee0-f72.google.com (mail-ee0-f72.google.com [74.125.83.72]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 12E0A20973 for ; Thu, 16 Oct 2014 08:15:53 +0000 (UTC) Received: by mail-ee0-f72.google.com with SMTP id e51sf1721719eek.7 for ; Thu, 16 Oct 2014 01:15:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:mime-version:in-reply-to:references :date:message-id:subject:from:to:cc:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe:content-type; bh=GyDQRtWzxieYjI66lwE3haNIpABPLBxoRGNTbMmayuw=; b=YtN+HHRjIKIaIUQIawtRs1JT6m8QrBsgXhXbX0Exy3Bxf3LuypYH0cgoUKGiKchB2w iZ22M7iDeUpLfxA8kXUHmYJMWYuQgIKcehccl1oZGjSTa+OBYzFXP4QJSWRzE9BxueKN gYXvL2iASoZdNvBX5R4uhr5uDFtuPDySCGr/+ClDYqTQrNH3/7otez/mFZxK89/B1vk9 G7kuO9HlMCAURYQlDbsHaGQZ+iLDUWboQoNBezQMWcRrDLLRe36aQD/KaqvemIJ6tWG0 94tGE6z3aHnB9PfIjBEQI1leTorTvF1k2m8R/8aeklxqdpYFKPkifi88wvES8/DWr/yU og6A== X-Gm-Message-State: ALoCoQmbgJKL7QloaQa7Lcd6voPh/aLvzx1usPGIxtgegQ2jV8m9tUjvSZx6Jb8rdyRKKkqvNP5i X-Received: by 10.112.26.82 with SMTP id j18mr146846lbg.16.1413447353116; Thu, 16 Oct 2014 01:15:53 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.205.108 with SMTP id lf12ls120294lac.48.gmail; Thu, 16 Oct 2014 01:15:53 -0700 (PDT) X-Received: by 10.152.206.36 with SMTP id ll4mr18079509lac.64.1413447352954; Thu, 16 Oct 2014 01:15:52 -0700 (PDT) Received: from mail-la0-f51.google.com (mail-la0-f51.google.com [209.85.215.51]) by mx.google.com with ESMTPS id m8si33574337lah.97.2014.10.16.01.15.52 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 16 Oct 2014 01:15:52 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.51 as permitted sender) client-ip=209.85.215.51; Received: by mail-la0-f51.google.com with SMTP id ge10so2449543lab.10 for ; Thu, 16 Oct 2014 01:15:52 -0700 (PDT) X-Received: by 10.152.6.228 with SMTP id e4mr9411732laa.71.1413447352132; Thu, 16 Oct 2014 01:15:52 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.84.229 with SMTP id c5csp753403lbz; Thu, 16 Oct 2014 01:15:51 -0700 (PDT) X-Received: by 10.70.19.101 with SMTP id d5mr18559166pde.79.1413447350197; Thu, 16 Oct 2014 01:15:50 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id fr3si18132730pdb.233.2014.10.16.01.15.49 for ; Thu, 16 Oct 2014 01:15:50 -0700 (PDT) Received-SPF: none (google.com: linux-pm-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750993AbaJPIPr (ORCPT + 15 others); Thu, 16 Oct 2014 04:15:47 -0400 Received: from mail-ob0-f179.google.com ([209.85.214.179]:62502 "EHLO mail-ob0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751316AbaJPIPp (ORCPT ); Thu, 16 Oct 2014 04:15:45 -0400 Received: by mail-ob0-f179.google.com with SMTP id wp4so2452081obc.24 for ; Thu, 16 Oct 2014 01:15:44 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.202.66.137 with SMTP id p131mr495371oia.77.1413447344725; Thu, 16 Oct 2014 01:15:44 -0700 (PDT) Received: by 10.182.233.170 with HTTP; Thu, 16 Oct 2014 01:15:44 -0700 (PDT) In-Reply-To: <1413322689-6195-1-git-send-email-jgeboski@gmail.com> References: <1413322689-6195-1-git-send-email-jgeboski@gmail.com> Date: Thu, 16 Oct 2014 13:45:44 +0530 Message-ID: Subject: Re: [PATCH] cpufreq: allow powersave governor as the default without expert mode From: Viresh Kumar To: James Geboski Cc: "Rafael J. Wysocki" , "linux-pm@vger.kernel.org" , Linux Kernel Mailing List Sender: linux-pm-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: viresh.kumar@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.51 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , On 15 October 2014 03:08, James Geboski wrote: > The intel_pstate driver only supports the performance and the powersave > governors. With the performance governor ensuring the highest possible > performance settings, userspace tools fail to make any lasting changes. > In order to allow userspace tools to make modifications to the settings, > the powersave governor must be in use. This makes having the powersave > governor as the default convenient for systems where the intel_pstate > driver is being employed. Having to enable expert mode in the kernel > configuration is just a headache for such a trivial task. > > This patch applies to all kernel versions 2.6.38 or greater after the > migration from CONFIG_EMBEDDED to CONFIG_EXPERT (6a108a14fa35). Most > importantly, this applies to kernel versions 3.9 or greater when the > intel_pstate driver was introduced. > > Signed-off-by: James Geboski > --- > drivers/cpufreq/Kconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig > index 3489f8f..73df7db 100644 > --- a/drivers/cpufreq/Kconfig > +++ b/drivers/cpufreq/Kconfig > @@ -63,7 +63,6 @@ config CPU_FREQ_DEFAULT_GOV_PERFORMANCE > > config CPU_FREQ_DEFAULT_GOV_POWERSAVE > bool "powersave" > - depends on EXPERT > select CPU_FREQ_GOV_POWERSAVE > help > Use the CPUFreq governor 'powersave' as default. This sets This was the commit which introduced it: commit 30d221db4439973076953e2ed44344fa92d1d09f Author: Alessandro Guido Date: Fri Apr 18 13:31:13 2008 -0700 [CPUFREQ] allow use of the powersave governor as the default one Allow use of the powersave cpufreq governor as the default one for EMBEDDED configs. Signed-off-by: Alessandro Guido Signed-off-by: Andrew Morton Signed-off-by: Dave Jones --- drivers/cpufreq/Kconfig | 9 +++++++++ drivers/cpufreq/cpufreq_powersave.c | 8 ++++++-- include/linux/cpufreq.h | 3 +++ 3 files changed, 18 insertions(+), 2 deletions(-) And I think it was wrong since ever, it should have been selected by EMBEDDED instead of a depends here. For your patch: Acked-by: Viresh Kumar -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig index c159ae6..5f076ae 100644 --- a/drivers/cpufreq/Kconfig +++ b/drivers/cpufreq/Kconfig @@ -69,6 +69,15 @@ config CPU_FREQ_DEFAULT_GOV_PERFORMANCE the frequency statically to the highest frequency supported by the CPU. +config CPU_FREQ_DEFAULT_GOV_POWERSAVE + bool "powersave" + depends on EMBEDDED + select CPU_FREQ_GOV_POWERSAVE + help + Use the CPUFreq governor 'powersave' as default. This sets + the frequency statically to the lowest frequency supported by + the CPU. +