From patchwork Thu Nov 15 06:24:21 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Daniel Kachhap X-Patchwork-Id: 12853 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 4768723FC0 for ; Thu, 15 Nov 2012 06:24:25 +0000 (UTC) Received: from mail-ia0-f180.google.com (mail-ia0-f180.google.com [209.85.210.180]) by fiordland.canonical.com (Postfix) with ESMTP id DD3F0A1843C for ; Thu, 15 Nov 2012 06:24:24 +0000 (UTC) Received: by mail-ia0-f180.google.com with SMTP id f6so800181iag.11 for ; Wed, 14 Nov 2012 22:24:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf :mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:x-gm-message-state; bh=4YFzmJNppo0GJXdgID1EAD5x8mzpPQxcdeOBadUDnbo=; b=Q3TiU6WisAiqEKBftz21Q7Mk18FKcDFLaJWuuEsM82Cv4vA14F3HaQcaLvrZgIgsEf an6NC3/YFVGLCTLX4aMJ9Oy04sjyzZaKeTwOaVGKGtjkrmcxhnmxtPq8/XJWwadgTEDO 2WjVU+0D7lfeWUKfsdp/nKQ+ERGP4YZTasu2eaWM5qChI2bMwC/IadxZgiO6hAA/wyHv cPasJf37oK6fmUxejsyBOdfd66ybFlVqPufYVEXd2AQO5AZPA/7zQ15iw2mKPfhyZhOu CbyPvxdMvVwyTYSJe1mw1ZLP9J+2ZljWeC3M1lXpTE5R+iMF3WUExIk36WFs1nAkLWlb 9b2w== Received: by 10.50.91.195 with SMTP id cg3mr1595497igb.57.1352960664119; Wed, 14 Nov 2012 22:24:24 -0800 (PST) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.50.67.148 with SMTP id n20csp779198igt; Wed, 14 Nov 2012 22:24:23 -0800 (PST) Received: by 10.60.14.200 with SMTP id r8mr105430oec.45.1352960662622; Wed, 14 Nov 2012 22:24:22 -0800 (PST) Received: from mail-ob0-f181.google.com (mail-ob0-f181.google.com [209.85.214.181]) by mx.google.com with ESMTPS id df4si14794474obc.50.2012.11.14.22.24.22 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 14 Nov 2012 22:24:22 -0800 (PST) Received-SPF: neutral (google.com: 209.85.214.181 is neither permitted nor denied by best guess record for domain of amit.kachhap@linaro.org) client-ip=209.85.214.181; Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.214.181 is neither permitted nor denied by best guess record for domain of amit.kachhap@linaro.org) smtp.mail=amit.kachhap@linaro.org Received: by mail-ob0-f181.google.com with SMTP id ta14so1317844obb.40 for ; Wed, 14 Nov 2012 22:24:22 -0800 (PST) MIME-Version: 1.0 Received: by 10.182.177.7 with SMTP id cm7mr116338obc.20.1352960662042; Wed, 14 Nov 2012 22:24:22 -0800 (PST) Received: by 10.76.85.105 with HTTP; Wed, 14 Nov 2012 22:24:21 -0800 (PST) In-Reply-To: <1352938284.2143.5.camel@rzhang1-mobl4> References: <1352875704-2178-1-git-send-email-sachin.kamat@linaro.org> <1352938284.2143.5.camel@rzhang1-mobl4> Date: Thu, 15 Nov 2012 11:54:21 +0530 Message-ID: Subject: Re: [PATCH 1/1] thermal: Exynos: Add missing dependency From: Amit Kachhap To: linux-pm@vger.kernel.org, Sachin Kamat Cc: durgadoss.r@intel.com, patches@linaro.org, akpm@linux-foundation.org X-Gm-Message-State: ALoCoQkVko8sv9p8TDItVu5sZmCHYDWI0/miSJkS+V5fwAfuIUfpsaNp/yyPMj/Ib7idYYXQnmkV On 15 November 2012 05:41, Zhang Rui wrote: > Hi, Sachin, > > thanks for catching the problem. > > On Wed, 2012-11-14 at 12:18 +0530, Sachin Kamat wrote: >> CPU_FREQ_TABLE depends on CPU_FREQ. Selecting CPU_FREQ_TABLE without checking >> for dependencies gives the following compilation warnings: >> warning: (ARCH_TEGRA_2x_SOC && ARCH_TEGRA_3x_SOC && UX500_SOC_DB8500 && >> CPU_THERMAL && EXYNOS_THERMAL) selects CPU_FREQ_TABLE which has unmet >> direct dependencies (ARCH_HAS_CPUFREQ && CPU_FREQ) >> > Amit, > > how is exynos driver supposed to work? > do you want the exynos driver still be loaded without CPU_THERMAL? > If yes, EXYNOS_THERMAL should not select CPU_FREQ_TABLE. > If no, EXYNOS_THERMAL should depends on CPU_THERMAL instead of THERMAL. > and CPU_THERMAL will select CPU_FREQ_TABLE instead. > > IMO, either of the above solution will be more proper to fix this > warning. Yes Rui, Currently exynos driver has dependency on CPU_THERMAL. There is some code-refactoring work needed to remove this dependency. As of now to fix the warning following changes may be sufficient. Thanks, Amit Daniel > > thanks, > rui > >> Cc: Amit Daniel Kachhap >> Signed-off-by: Sachin Kamat >> --- >> Build tested using exynos4_defconfig on linux-next tree of 20121114. >> --- >> drivers/thermal/Kconfig | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig >> index 266c15e..197b7db 100644 >> --- a/drivers/thermal/Kconfig >> +++ b/drivers/thermal/Kconfig >> @@ -50,7 +50,7 @@ config RCAR_THERMAL >> >> config EXYNOS_THERMAL >> tristate "Temperature sensor on Samsung EXYNOS" >> - depends on (ARCH_EXYNOS4 || ARCH_EXYNOS5) && THERMAL >> + depends on (ARCH_EXYNOS4 || ARCH_EXYNOS5) && THERMAL && CPU_FREQ >> select CPU_FREQ_TABLE >> help >> If you say yes here you get support for TMU (Thermal Managment > > --- a/drivers/thermal/Kconfig +++ b/drivers/thermal/Kconfig @@ -50,7 +50,8 @@ config RCAR_THERMAL config EXYNOS_THERMAL tristate "Temperature sensor on Samsung EXYNOS" - depends on (ARCH_EXYNOS4 || ARCH_EXYNOS5) && THERMAL + depends on THERMAL + depends on (ARCH_EXYNOS4 || ARCH_EXYNOS5) && CPU_THERMAL select CPU_FREQ_TABLE help If you say yes here you get support for TMU (Thermal Managment