From patchwork Fri Aug 22 23:54:48 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kevin Hilman X-Patchwork-Id: 35864 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-oi0-f69.google.com (mail-oi0-f69.google.com [209.85.218.69]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id E81792057E for ; Fri, 22 Aug 2014 23:55:16 +0000 (UTC) Received: by mail-oi0-f69.google.com with SMTP id h136sf57444281oig.4 for ; Fri, 22 Aug 2014 16:55:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version:sender:precedence :list-id:x-original-sender:x-original-authentication-results :mailing-list:list-post:list-help:list-archive:list-unsubscribe :content-type; bh=0eVcNw5jHfSAKFI9Ckkld+pUhK0ohOVi+It+P1Exljg=; b=gYhJSR7c4kh/mdkNoBuvakcw1AtYPj1Y1KnYZ5gkp8QyJruORRc2+Sa2fOTzRE/leD B3lBInXzbIbTnyDFJKaj5y4KeD6UupJOW3NqN9obGxY5EoV/21DP81KFro+uTqloAxaK wKIJa1byWVCbDSXDNLM3VWDD3YMM0f1dEtotGN9yQTzhXkbLXU5xAOBE1vAL4rK+yVLT bgeWmda98z+dQj2SJyyhEAa+QLjlFny4u42rNpdQu73ASGBEosd7L0VtDPqDuKqLosK5 bveTEos3jY4UKhYgKHO02ZWcCE3zOl1lzolNxtjoKaDbk/U8LmEhowWq4BOuBgZ7jPbh wAlQ== X-Gm-Message-State: ALoCoQnxAQ6scc9rNQ5Kp2kCYoYh643OJASiCgo5LO3IOnhKjQpcZq9skm/nN3m/Ct+M21NJ3xzL X-Received: by 10.182.29.65 with SMTP id i1mr5062861obh.30.1408751716426; Fri, 22 Aug 2014 16:55:16 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.33.246 with SMTP id j109ls1325476qgj.83.gmail; Fri, 22 Aug 2014 16:55:16 -0700 (PDT) X-Received: by 10.52.61.136 with SMTP id p8mr1202578vdr.15.1408751716304; Fri, 22 Aug 2014 16:55:16 -0700 (PDT) Received: from mail-vc0-f170.google.com (mail-vc0-f170.google.com [209.85.220.170]) by mx.google.com with ESMTPS id xc7si13573882vcb.32.2014.08.22.16.55.16 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 22 Aug 2014 16:55:16 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.170 as permitted sender) client-ip=209.85.220.170; Received: by mail-vc0-f170.google.com with SMTP id lf12so13248697vcb.1 for ; Fri, 22 Aug 2014 16:55:16 -0700 (PDT) X-Received: by 10.52.1.39 with SMTP id 7mr2927550vdj.17.1408751716161; Fri, 22 Aug 2014 16:55:16 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.221.45.67 with SMTP id uj3csp54061vcb; Fri, 22 Aug 2014 16:55:15 -0700 (PDT) X-Received: by 10.66.235.1 with SMTP id ui1mr10354000pac.28.1408751714761; Fri, 22 Aug 2014 16:55:14 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id gl10si42700359pbd.139.2014.08.22.16.55.13 for ; Fri, 22 Aug 2014 16:55:14 -0700 (PDT) Received-SPF: none (google.com: linux-pm-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752541AbaHVXyx (ORCPT + 15 others); Fri, 22 Aug 2014 19:54:53 -0400 Received: from mail-pa0-f51.google.com ([209.85.220.51]:49676 "EHLO mail-pa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752532AbaHVXyv (ORCPT ); Fri, 22 Aug 2014 19:54:51 -0400 Received: by mail-pa0-f51.google.com with SMTP id ey11so17681153pad.10 for ; Fri, 22 Aug 2014 16:54:50 -0700 (PDT) X-Received: by 10.67.15.172 with SMTP id fp12mr10546337pad.4.1408751690514; Fri, 22 Aug 2014 16:54:50 -0700 (PDT) Received: from localhost (c-67-183-17-239.hsd1.wa.comcast.net. [67.183.17.239]) by mx.google.com with ESMTPSA id zv3sm3262036pac.16.2014.08.22.16.54.49 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Fri, 22 Aug 2014 16:54:49 -0700 (PDT) From: Kevin Hilman To: Tomasz Figa Cc: Kukjin Kim , Thomas Abraham , linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, l.majewski@samsung.com, mturquette@linaro.org, heiko@sntech.de, viresh.kumar@linaro.org, t.figa@samsung.com, cw00.choi@samsung.com, linux-samsung-soc@vger.kernel.org, linaro-kernel@lists.linaro.org, amit.kucheria@linaro.org Subject: Re: [PATCH v9 4/6] ARM: Exynos: switch to using generic cpufreq driver for Exynos4210/5250/5420 References: <1406707663-16656-1-git-send-email-thomas.ab@samsung.com> <1406707663-16656-5-git-send-email-thomas.ab@samsung.com> <53DA8BB9.6020702@samsung.com> <53DA8D85.3050106@gmail.com> Date: Fri, 22 Aug 2014 16:54:48 -0700 In-Reply-To: <53DA8D85.3050106@gmail.com> (Tomasz Figa's message of "Thu, 31 Jul 2014 20:40:05 +0200") Message-ID: <7hbnrc6px3.fsf@paris.lan> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Sender: linux-pm-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: khilman@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.170 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Tomasz Figa writes: > Kukjin, > > On 31.07.2014 20:32, Kukjin Kim wrote: >> On 07/30/14 17:07, Thomas Abraham wrote: >>> The new CPU clock type allows the use of generic CPUfreq drivers. So for >>> Exynos4210/5250, switch to using generic cpufreq driver. For Exynos5420, >>> which did not have CPUfreq driver support, enable the use of generic >>> CPUfreq driver. >>> >>> Suggested-by: Tomasz Figa >>> Cc: Kukjin Kim >> >> Looks good to me, >> >> Acked-by: Kukjin Kim >> >> BTW, who will handle this series? I hope see this series in 3.17. > > This series consists mostly of clock changes and it likely depends on > patches already in my for-next, so I would be inclined toward taking it > through samsung-clk tree. So has this series been picked up anywhere? I don't see it in your samsung-clk tree, nor in Kukjin's for-next. Also, I'm curious whether or how this is has been tested on big.LITTLE SoCs. I'm trying it on the 5800/Chromebook2 and it's not terribly stable. I'm testing along with CPUidle, so there may be some untested interactions there as it seems a bit more stable without CPUidle enabled. I'd love to hear from anyone else that's testing CPUidle and CPUfreq together big.LITTLE 5420/5800, with or without the switcher. Also, the patch below[2] is needed for 5800. FWIW, I have a temporary branch[1] based on the v3.17-rc branch of the exynos-reference tree where I've added the DT patch needed for CPUidle, this series (and it's dependencies) which is what I'm using for testing. Kevin [1] git://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux.git wip/exynos/integ [2] >From 72ee00246c0fbdcf5dbb0bf910b8a427da4ac002 Mon Sep 17 00:00:00 2001 From: Kevin Hilman Date: Fri, 22 Aug 2014 16:04:11 -0700 Subject: [PATCH] ARM: Exynos: use generic cpufreq driver for Exynos5800 As a derivative of the 5420, the 5800 SoC should use the generic big.LITTLE driver for Exynos5800 as well. Signed-off-by: Kevin Hilman --- arch/arm/mach-exynos/exynos.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exynos.c index 8923d37c3e85..debe50bf736a 100644 --- a/arch/arm/mach-exynos/exynos.c +++ b/arch/arm/mach-exynos/exynos.c @@ -283,6 +283,7 @@ static void __init exynos_init_irq(void) static const struct of_device_id exynos_cpufreq_matches[] = { { .compatible = "samsung,exynos5420", .data = "arm-bL-cpufreq-dt" }, + { .compatible = "samsung,exynos5800", .data = "arm-bL-cpufreq-dt" }, { .compatible = "samsung,exynos5250", .data = "cpufreq-cpu0" }, { .compatible = "samsung,exynos4210", .data = "cpufreq-cpu0" }, { .compatible = "samsung,exynos5440", .data = "exynos5440-cpufreq" },