Message ID | 20240926092519.6556-1-macpaul.lin@mediatek.com |
---|---|
State | New |
Headers | show |
Series | [1/3] ASoC: dt-bindings: mt6359: Update generic node name and dmic-mode | expand |
On 9/27/24 00:04, Conor Dooley wrote: > On Thu, Sep 26, 2024 at 05:25:18PM +0800, Macpaul Lin wrote: >> This patch updates the audio-codec properties includes: >> - compatible: >> - Re-order the supported device items. >> - Add 'mt6359-codec' to compatible since MT6359 PMIC has been included >> in this DT Schema. > >> - Set 'additionalProperties: true' for 'mt6359-codec'. > > Why? The mt6359-codec support these 3 properties: mediatek,mic-type0, mediatek,mic-type-1, mediatek-mic-type2. While mt6358-sound and mt6397-codec don't (at least, I didn't find these 3 properties in driver codes. Set 'additionalProperties: true' is also required to fix the following dtbs_check errors: pmic: audio-codec: 'mediatek,mic-type-0', 'mediatek,mic-type-1', 'mediatek,mic-type-2' do not match any of the regexes: 'pinctrl-[0-9]+' >> >> Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com> >> --- >> Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml b/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml >> index 40cabaf60d0d..ffb5848a96d5 100644 >> --- a/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml >> +++ b/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml >> @@ -104,7 +104,7 @@ properties: >> >> audio-codec: >> type: object >> - additionalProperties: false >> + additionalProperties: true >> description: >> Audio codec support with MT6397 and MT6358. >> >> @@ -112,8 +112,9 @@ properties: >> compatible: >> oneOf: >> - enum: >> - - mediatek,mt6397-codec >> - mediatek,mt6358-sound >> + - mediatek,mt6359-codec >> + - mediatek,mt6397-codec >> - items: >> - enum: >> - mediatek,mt6366-sound >> -- >> 2.45.2 >> Thanks Macpaul Lin
diff --git a/Documentation/devicetree/bindings/sound/mt6359.yaml b/Documentation/devicetree/bindings/sound/mt6359.yaml index 23d411fc4200..128698630c86 100644 --- a/Documentation/devicetree/bindings/sound/mt6359.yaml +++ b/Documentation/devicetree/bindings/sound/mt6359.yaml @@ -23,8 +23,8 @@ properties: Indicates how many data pins are used to transmit two channels of PDM signal. 0 means two wires, 1 means one wire. Default value is 0. enum: - - 0 # one wire - - 1 # two wires + - 0 # two wires + - 1 # one wire mediatek,mic-type-0: $ref: /schemas/types.yaml#/definitions/uint32 @@ -53,9 +53,9 @@ additionalProperties: false examples: - | - mt6359codec: mt6359codec { - mediatek,dmic-mode = <0>; - mediatek,mic-type-0 = <2>; + mt6359codec: audio-codec { + mediatek,dmic-mode = <0>; + mediatek,mic-type-0 = <2>; }; ...