| Message ID | 20240728114200.75559-6-wahrenst@gmx.net |
|---|---|
| State | Accepted |
| Commit | 562cdeadac06176b3a99bd457d9463a3b58df60f |
| Headers | show |
| Series | ARM: bcm2835: Implement initial S2Idle for Raspberry Pi | expand |
Hi, Am 28.07.24 um 13:41 schrieb Stefan Wahren: > Set flag GENPD_FLAG_ACTIVE_WAKEUP to rpi_power genpd, then when a device > is set as wakeup source using device_set_wakeup_enable, the power > domain could be kept on to make sure the device could wakeup the system. > > Signed-off-by: Stefan Wahren <wahrenst@gmx.net> I know a lot developer are in holidays, but it would be nice to get a review for the new pmdomain parts before i send V3. Best regards > --- > drivers/pmdomain/bcm/raspberrypi-power.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pmdomain/bcm/raspberrypi-power.c b/drivers/pmdomain/bcm/raspberrypi-power.c > index fadedfc9c645..b87ea7adb7be 100644 > --- a/drivers/pmdomain/bcm/raspberrypi-power.c > +++ b/drivers/pmdomain/bcm/raspberrypi-power.c > @@ -91,6 +91,7 @@ static void rpi_common_init_power_domain(struct rpi_power_domains *rpi_domains, > dom->fw = rpi_domains->fw; > > dom->base.name = name; > + dom->base.flags = GENPD_FLAG_ACTIVE_WAKEUP; > dom->base.power_on = rpi_domain_on; > dom->base.power_off = rpi_domain_off; > > -- > 2.34.1 >
On Sun, 28 Jul 2024 at 13:47, Stefan Wahren <wahrenst@gmx.net> wrote: > > Set flag GENPD_FLAG_ACTIVE_WAKEUP to rpi_power genpd, then when a device > is set as wakeup source using device_set_wakeup_enable, the power > domain could be kept on to make sure the device could wakeup the system. > > Signed-off-by: Stefan Wahren <wahrenst@gmx.net> Patch 3 -> 5, applied for next to my pmdomain tree, thanks! Kind regards Uffe > --- > drivers/pmdomain/bcm/raspberrypi-power.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pmdomain/bcm/raspberrypi-power.c b/drivers/pmdomain/bcm/raspberrypi-power.c > index fadedfc9c645..b87ea7adb7be 100644 > --- a/drivers/pmdomain/bcm/raspberrypi-power.c > +++ b/drivers/pmdomain/bcm/raspberrypi-power.c > @@ -91,6 +91,7 @@ static void rpi_common_init_power_domain(struct rpi_power_domains *rpi_domains, > dom->fw = rpi_domains->fw; > > dom->base.name = name; > + dom->base.flags = GENPD_FLAG_ACTIVE_WAKEUP; > dom->base.power_on = rpi_domain_on; > dom->base.power_off = rpi_domain_off; > > -- > 2.34.1 > >
diff --git a/drivers/pmdomain/bcm/raspberrypi-power.c b/drivers/pmdomain/bcm/raspberrypi-power.c index fadedfc9c645..b87ea7adb7be 100644 --- a/drivers/pmdomain/bcm/raspberrypi-power.c +++ b/drivers/pmdomain/bcm/raspberrypi-power.c @@ -91,6 +91,7 @@ static void rpi_common_init_power_domain(struct rpi_power_domains *rpi_domains, dom->fw = rpi_domains->fw; dom->base.name = name; + dom->base.flags = GENPD_FLAG_ACTIVE_WAKEUP; dom->base.power_on = rpi_domain_on; dom->base.power_off = rpi_domain_off;
Set flag GENPD_FLAG_ACTIVE_WAKEUP to rpi_power genpd, then when a device is set as wakeup source using device_set_wakeup_enable, the power domain could be kept on to make sure the device could wakeup the system. Signed-off-by: Stefan Wahren <wahrenst@gmx.net> --- drivers/pmdomain/bcm/raspberrypi-power.c | 1 + 1 file changed, 1 insertion(+) -- 2.34.1