| Message ID | 20230124115119.21451-1-jonathanh@nvidia.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2] dt-bindings: thermal: Add Tegra234 BPMP thermal zones | expand |
On 24/01/2023 11:51, Jon Hunter wrote: > From: Yi-Wei Wang <yiweiw@nvidia.com> > > Add the BPMP thermal device node and thermal-zones for Tegra234 and > enable thermal support for the Tegra234 Jetson AGX Orin board. > > Signed-off-by: Yi-Wei Wang <yiweiw@nvidia.com> > Signed-off-by: Jon Hunter <jonathanh@nvidia.com> > --- > .../boot/dts/nvidia/tegra234-p3701-0000.dtsi | 276 ++++++++++++++++++ > .../nvidia/tegra234-p3737-0000+p3701-0000.dts | 32 ++ > arch/arm64/boot/dts/nvidia/tegra234.dtsi | 59 ++++ > 3 files changed, 367 insertions(+) > > diff --git a/arch/arm64/boot/dts/nvidia/tegra234-p3701-0000.dtsi b/arch/arm64/boot/dts/nvidia/tegra234-p3701-0000.dtsi > index 2378da324273..7f798742df43 100644 > --- a/arch/arm64/boot/dts/nvidia/tegra234-p3701-0000.dtsi > +++ b/arch/arm64/boot/dts/nvidia/tegra234-p3701-0000.dtsi > @@ -80,6 +80,22 @@ pmc@c360000 { > }; > }; > > + bpmp { > + i2c { > + tegra_tmp451: thermal-sensor@4c { > + compatible = "ti,tmp451"; > + reg = <0x4c>; > + vcc-supply = <&vdd_1v8_ao>; > + #thermal-sensor-cells = <1>; > + status = "okay"; > + }; > + }; > + > + thermal { > + status = "okay"; > + }; > + }; > + > vdd_5v0_sys: regulator-vdd-5v0-sys { > compatible = "regulator-fixed"; > regulator-name = "VIN_SYS_5V0"; > @@ -139,4 +155,264 @@ vdd_12v_pcie: regulator-vdd-12v-pcie { > gpio = <&gpio TEGRA234_MAIN_GPIO(A, 1) GPIO_ACTIVE_LOW>; > regulator-boot-on; > }; > + > + thermal-zones { > + cpu-thermal { > + polling-delay = <1000>; > + polling-delay-passive = <1000>; > + thermal-sensors = <&{/bpmp/thermal} TEGRA234_THERMAL_ZONE_CPU>; > + status = "okay"; > + > + trips { > + cpu_sw_shutdown: cpu-sw-shutdown { > + temperature = <104500>; > + hysteresis = <0>; > + type = "critical"; > + }; > + > + cpu_sw_throttle: cpu-sw-throttle { > + temperature = <99000>; > + hysteresis = <0>; > + type = "passive"; > + }; > + }; > + > + cooling-maps { > + map0 { > + trip = <&cpu_sw_throttle>; > + cooling-device = <&cpu0_0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&cpu1_0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&cpu2_0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; > + }; > + }; > + }; > + > + gpu-thermal { > + polling-delay = <1000>; > + polling-delay-passive = <1000>; > + thermal-sensors = <&{/bpmp/thermal} TEGRA234_THERMAL_ZONE_GPU>; > + status = "okay"; > + status = "disabled"; Looks like I messed this up. I will send a V2 to fix. Jon
On Tue, Jan 24, 2023 at 11:51:18AM +0000, Jon Hunter wrote: > From: Yi-Wei Wang <yiweiw@nvidia.com> > > Add BPMP thermal zone definitions for Tegra234. > > Signed-off-by: Yi-Wei Wang <yiweiw@nvidia.com> > Signed-off-by: Jon Hunter <jonathanh@nvidia.com> > --- > .../thermal/tegra234-bpmp-thermal.h | 19 +++++++++++++++++++ Match the compatible name please. > 1 file changed, 19 insertions(+) > create mode 100644 include/dt-bindings/thermal/tegra234-bpmp-thermal.h > > diff --git a/include/dt-bindings/thermal/tegra234-bpmp-thermal.h b/include/dt-bindings/thermal/tegra234-bpmp-thermal.h > new file mode 100644 > index 000000000000..41a5efebcc7a > --- /dev/null > +++ b/include/dt-bindings/thermal/tegra234-bpmp-thermal.h > @@ -0,0 +1,19 @@ License? Dual please. > +/* > + * This header provides constants for binding nvidia,tegra234-bpmp-thermal. > + */ > + > +#ifndef _DT_BINDINGS_THERMAL_TEGRA234_BPMP_THERMAL_H > +#define _DT_BINDINGS_THERMAL_TEGRA234_BPMP_THERMAL_H > + > +#define TEGRA234_THERMAL_ZONE_CPU 0 > +#define TEGRA234_THERMAL_ZONE_GPU 1 > +#define TEGRA234_THERMAL_ZONE_CV0 2 > +#define TEGRA234_THERMAL_ZONE_CV1 3 > +#define TEGRA234_THERMAL_ZONE_CV2 4 > +#define TEGRA234_THERMAL_ZONE_SOC0 5 > +#define TEGRA234_THERMAL_ZONE_SOC1 6 > +#define TEGRA234_THERMAL_ZONE_SOC2 7 > +#define TEGRA234_THERMAL_ZONE_TJ_MAX 8 > +#define TEGRA234_THERMAL_ZONE_COUNT 9 > + > +#endif > -- > 2.25.1 >
On 25/01/2023 20:26, Rob Herring wrote: > On Tue, Jan 24, 2023 at 11:51:18AM +0000, Jon Hunter wrote: >> From: Yi-Wei Wang <yiweiw@nvidia.com> >> >> Add BPMP thermal zone definitions for Tegra234. >> >> Signed-off-by: Yi-Wei Wang <yiweiw@nvidia.com> >> Signed-off-by: Jon Hunter <jonathanh@nvidia.com> >> --- >> .../thermal/tegra234-bpmp-thermal.h | 19 +++++++++++++++++++ > > Match the compatible name please. OK, but to be clear, the compatible string is 'nvidia,tegra186-bpmp-thermal'. So should 'tegra186-bpmp-thermal.h', 'tegra194-bpmp- thermal.h' and this file be combined into a single filed called 'nvidia,tegra186-bpmp-thermal.h'? > >> 1 file changed, 19 insertions(+) >> create mode 100644 include/dt-bindings/thermal/tegra234-bpmp-thermal.h >> >> diff --git a/include/dt-bindings/thermal/tegra234-bpmp-thermal.h b/include/dt-bindings/thermal/tegra234-bpmp-thermal.h >> new file mode 100644 >> index 000000000000..41a5efebcc7a >> --- /dev/null >> +++ b/include/dt-bindings/thermal/tegra234-bpmp-thermal.h >> @@ -0,0 +1,19 @@ > > License? Dual please. Yes will fix this. Thanks Jon
diff --git a/include/dt-bindings/thermal/tegra234-bpmp-thermal.h b/include/dt-bindings/thermal/tegra234-bpmp-thermal.h new file mode 100644 index 000000000000..41a5efebcc7a --- /dev/null +++ b/include/dt-bindings/thermal/tegra234-bpmp-thermal.h @@ -0,0 +1,19 @@ +/* + * This header provides constants for binding nvidia,tegra234-bpmp-thermal. + */ + +#ifndef _DT_BINDINGS_THERMAL_TEGRA234_BPMP_THERMAL_H +#define _DT_BINDINGS_THERMAL_TEGRA234_BPMP_THERMAL_H + +#define TEGRA234_THERMAL_ZONE_CPU 0 +#define TEGRA234_THERMAL_ZONE_GPU 1 +#define TEGRA234_THERMAL_ZONE_CV0 2 +#define TEGRA234_THERMAL_ZONE_CV1 3 +#define TEGRA234_THERMAL_ZONE_CV2 4 +#define TEGRA234_THERMAL_ZONE_SOC0 5 +#define TEGRA234_THERMAL_ZONE_SOC1 6 +#define TEGRA234_THERMAL_ZONE_SOC2 7 +#define TEGRA234_THERMAL_ZONE_TJ_MAX 8 +#define TEGRA234_THERMAL_ZONE_COUNT 9 + +#endif