From patchwork Sun Jul 10 12:35:00 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Lezcano X-Patchwork-Id: 589321 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96FFFC43334 for ; Sun, 10 Jul 2022 12:35:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229625AbiGJMfW (ORCPT ); Sun, 10 Jul 2022 08:35:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58214 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229616AbiGJMfV (ORCPT ); Sun, 10 Jul 2022 08:35:21 -0400 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DA1491114C for ; Sun, 10 Jul 2022 05:35:18 -0700 (PDT) Received: by mail-wm1-x32a.google.com with SMTP id v10-20020a05600c15ca00b003a2db8aa2c4so1607720wmf.2 for ; Sun, 10 Jul 2022 05:35:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linexp-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=7UKKS5f7QbJpxlk+iXwxbcq70b7aqG7EJc4B5ZEy8YU=; b=By6v5r10L/lAATCEtUvIN9UyTUj23D9ixh8xCslWB5BV4bBLKCf97tNmLKl4p2J5Vj 6kpafYxSKNlwzHLzVTbGj5p9xVzVDeygR3U5xP3mfFDtVP2BEGhbElywcAu5HrgbS7xC 8D4h3P6DiI3v6claR6LLrOpL7js65S+5276sT/9nCckLsoyVigewZxD0QfmOW349joJs OYb58loCAq1/W6MR/TJ3OpVCRjWQZRGIq28GyyF/F3Hy1UvOBDayNJEZyHWPFLKyEsTL CgcAL6HZ62dwAUHAAFMYwVRBxae6s5xfkJb6kJSadQev7yRRo2UtztdnTNaQ49k/LW6+ tmOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7UKKS5f7QbJpxlk+iXwxbcq70b7aqG7EJc4B5ZEy8YU=; b=Fl5RZbRnzUe1q8L5b8HhYThvHfPTFAo3O9m4uIG/yC6HwBXzAMnYT2jckOL4zrZMtT 9HcKFx3DtPEmEiQK5+y7FUxFMNlYqG1oCJTxPzfKw8RC7OxTqiz6YMsBJd29gwJ54wIr rFDPmZnWY+ik+s2QB8XKTF2bJD1WQ+Ktgi3jScr9FFZsdkMh3SD88DM6GuOGrGhQ3d+H WEgSDNGXXsbWk12e2muYEMr4gEIiD1WeMHc/T4Ethb5sEyJTOd4SGQ5zQ98DtY0WRmaS 9OECLQHyuvK32vQf1qvN9lM3hqowkD0/36tBUcOnuxs13b5xiBp3URMGbnkEffMVZRkF +USw== X-Gm-Message-State: AJIora86614LoLm15+TlDBNmCG1XjrfIv5X/DQ7OZL152PDjKljciG/H Z0Hor0nmiq+c+T2cfdJzkjUlJw== X-Google-Smtp-Source: AGRyM1tHDEsVQduYimH8r3NljPB+Kato4ADWXh8GoJ/14eVbkAq2Q7IoN4V9CC1Ml0PyvstWVl8nCw== X-Received: by 2002:a05:600c:34c2:b0:3a0:5439:1f with SMTP id d2-20020a05600c34c200b003a05439001fmr9960836wmq.179.1657456517482; Sun, 10 Jul 2022 05:35:17 -0700 (PDT) Received: from localhost.localdomain (146725694.box.freepro.com. [130.180.211.218]) by smtp.gmail.com with ESMTPSA id 24-20020a05600c22d800b003a0375c4f73sm3775144wmg.44.2022.07.10.05.35.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 Jul 2022 05:35:17 -0700 (PDT) From: Daniel Lezcano To: daniel.lezcano@linaro.org, rafael@kernel.org Cc: rui.zhang@intel.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, khilman@baylibre.com, abailon@baylibre.com, lukasz.luba@arm.com, Amit Kucheria Subject: [PATCH v5 01/12] thermal/core: Remove duplicate information when an error occurs Date: Sun, 10 Jul 2022 14:35:00 +0200 Message-Id: <20220710123512.1714714-2-daniel.lezcano@linexp.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220710123512.1714714-1-daniel.lezcano@linexp.org> References: <20220710123512.1714714-1-daniel.lezcano@linexp.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org The pr_err already tells it is an error, it is pointless to add the 'Error:' string in the messages. Remove them. Cc: Alexandre Bailon Cc: Kevin Hilman Signed-off-by: Daniel Lezcano Reviewed-by: Lukasz Luba --- drivers/thermal/thermal_core.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c index cdc0552e8c42..e22e7d939c54 100644 --- a/drivers/thermal/thermal_core.c +++ b/drivers/thermal/thermal_core.c @@ -1198,23 +1198,23 @@ thermal_zone_device_register(const char *type, int trips, int mask, struct thermal_governor *governor; if (!type || strlen(type) == 0) { - pr_err("Error: No thermal zone type defined\n"); + pr_err("No thermal zone type defined\n"); return ERR_PTR(-EINVAL); } if (type && strlen(type) >= THERMAL_NAME_LENGTH) { - pr_err("Error: Thermal zone name (%s) too long, should be under %d chars\n", + pr_err("Thermal zone name (%s) too long, should be under %d chars\n", type, THERMAL_NAME_LENGTH); return ERR_PTR(-EINVAL); } if (trips > THERMAL_MAX_TRIPS || trips < 0 || mask >> trips) { - pr_err("Error: Incorrect number of thermal trips\n"); + pr_err("Incorrect number of thermal trips\n"); return ERR_PTR(-EINVAL); } if (!ops) { - pr_err("Error: Thermal zone device ops not defined\n"); + pr_err("Thermal zone device ops not defined\n"); return ERR_PTR(-EINVAL); }