| Message ID | 20220321095729.20655-9-lukasz.luba@arm.com |
|---|---|
| State | Accepted |
| Commit | 985a67709a66c456414182ed179544786e00321e |
| Headers | show |
| Series | Introduce support for artificial Energy Model | expand |
On Monday 21 Mar 2022 at 09:57:29 (+0000), Lukasz Luba wrote: > The Energy Model power values might be artificial. In such case > it's safe to bail out during the registration, since the PowerCap > framework supports only micro-Watts. > > Signed-off-by: Lukasz Luba <lukasz.luba@arm.com> > --- > drivers/powercap/dtpm_cpu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/powercap/dtpm_cpu.c b/drivers/powercap/dtpm_cpu.c > index bca2f912d349..f5eced0842b3 100644 > --- a/drivers/powercap/dtpm_cpu.c > +++ b/drivers/powercap/dtpm_cpu.c > @@ -211,7 +211,7 @@ static int __dtpm_cpu_setup(int cpu, struct dtpm *parent) > return 0; > > pd = em_cpu_get(cpu); > - if (!pd) > + if (!pd || em_is_artificial(pd)) > return -EINVAL; > > dtpm_cpu = kzalloc(sizeof(*dtpm_cpu), GFP_KERNEL); Reviewed-by: Ionela Voinescu <ionela.voinescu@arm.com> > -- > 2.17.1 >
diff --git a/drivers/powercap/dtpm_cpu.c b/drivers/powercap/dtpm_cpu.c index bca2f912d349..f5eced0842b3 100644 --- a/drivers/powercap/dtpm_cpu.c +++ b/drivers/powercap/dtpm_cpu.c @@ -211,7 +211,7 @@ static int __dtpm_cpu_setup(int cpu, struct dtpm *parent) return 0; pd = em_cpu_get(cpu); - if (!pd) + if (!pd || em_is_artificial(pd)) return -EINVAL; dtpm_cpu = kzalloc(sizeof(*dtpm_cpu), GFP_KERNEL);
The Energy Model power values might be artificial. In such case it's safe to bail out during the registration, since the PowerCap framework supports only micro-Watts. Signed-off-by: Lukasz Luba <lukasz.luba@arm.com> --- drivers/powercap/dtpm_cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)