diff mbox series

[-next,2/2] cpuidle: add put_device() after of_find_device_by_node()

Message ID 20211210043024.80884-1-yang.lee@linux.alibaba.com
State New
Headers show
Series [-next,1/2] cpuidle: Fix kernel-doc | expand

Commit Message

Yang Li Dec. 10, 2021, 4:30 a.m. UTC 
This was found by coccicheck:
./drivers/cpuidle/cpuidle-qcom-spm.c:129:1-7: ERROR: missing put_device;
call of_find_device_by_node on line 103, but without a corresponding
object release within this function.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
 drivers/cpuidle/cpuidle-qcom-spm.c | 1 +
 1 file changed, 1 insertion(+)
diff mbox series

Patch

diff --git a/drivers/cpuidle/cpuidle-qcom-spm.c b/drivers/cpuidle/cpuidle-qcom-spm.c
index 01e77913a414..3952ea600122 100644
--- a/drivers/cpuidle/cpuidle-qcom-spm.c
+++ b/drivers/cpuidle/cpuidle-qcom-spm.c
@@ -111,6 +111,7 @@  static int spm_cpuidle_register(struct device *cpuidle_dev, int cpu)
 		return -ENOMEM;
 
 	data->spm = dev_get_drvdata(&pdev->dev);
+	put_device(&pdev->dev);
 	if (!data->spm)
 		return -EINVAL;