From patchwork Thu Dec 10 12:15:13 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Daniel Lezcano X-Patchwork-Id: 341027 Delivered-To: patch@linaro.org Received: by 2002:a17:906:4755:0:0:0:0 with SMTP id j21csp5578247ejs; Thu, 10 Dec 2020 04:16:53 -0800 (PST) X-Google-Smtp-Source: ABdhPJx66NxvSmZBWdv1QkSkIA6t7AVK34QzNj89Mab1GxcrWSnBMVA2+VZ8taxq+rQU4684y1Wa X-Received: by 2002:a17:906:1408:: with SMTP id p8mr6189279ejc.213.1607602613481; Thu, 10 Dec 2020 04:16:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607602613; cv=none; d=google.com; s=arc-20160816; b=I9voHi5ym3/hO/n/NAguyAjlR6/G51qNsJ1st6pqEnF9lhlPgkaT4TV1R5nxdaqnKW rND2Ulp2KXiJTS5e3GHPtRm7tTSk9ikD5ljf2nyQeaNq+epg/TnTOY9JzBUj5RrA4NDy EbyrZhdkkLGIj8XkRJdeeMe+age++1ABmJvV8AL/UOwMJ5gYQdstvW1Zf+oXnI0bpwDP MbzC348ZtcvZKblB7y5exyE/Rv8wLhoA4Lp4ywdYt2TVMBcGTDJ5I+UF8wDl+8br23fi iM6VxrpAliB6zdAqbLNFaReaCWr5LsCQDfXLGpqUbf2Pu6M2FMJp0GQ8NEtfU1R8uKVi ImXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from:dkim-signature; bh=RFh2OYp1AIw9+1gIuk13B075+zUU8XY1s7bawa7LB6o=; b=KvXVIGUziIMHjUZU1grn4q/0iu8I3y6Nkgsjp6evuMGq85fNH7S2rkyrlKlIeBf5Su WJSG+v/tbj/KVYGASpWq+ItzO988l0gj8KfJ5wBZwapW2fxQYXKM/bP+altOtmWH0o3r 03abNJOVWbRCLlZNbAU/zpq2OVVGANiKlDvI9iYwvSC8Cas7Wv6LL/NXQG692m2/r9wF o1zKQzz9NFvwZA9b7PFVcDqgWX6CkqkzyfgHOr/+ikcye0ERYeC0DMETG+4W228AoGEg 1EAO/ecydX68q7uGYc8kSA97fK/kh2AgKx6K/keGl43EaJrCElHo4JF25da/+phF7Uab b2Kg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=LqyOHEu5; spf=pass (google.com: domain of linux-pm-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-pm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m26si2402535ejc.513.2020.12.10.04.16.53; Thu, 10 Dec 2020 04:16:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-pm-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=LqyOHEu5; spf=pass (google.com: domain of linux-pm-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-pm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731010AbgLJMQ3 (ORCPT + 8 others); Thu, 10 Dec 2020 07:16:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40072 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388019AbgLJMQU (ORCPT ); Thu, 10 Dec 2020 07:16:20 -0500 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0EBE1C0611C5 for ; Thu, 10 Dec 2020 04:15:29 -0800 (PST) Received: by mail-wr1-x441.google.com with SMTP id r14so5245254wrn.0 for ; Thu, 10 Dec 2020 04:15:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=RFh2OYp1AIw9+1gIuk13B075+zUU8XY1s7bawa7LB6o=; b=LqyOHEu5V+z03no0UW7ifZb3Jmi421rFx6DMwHbniRYbl42RKA29HPo8aLy1gNicy3 dViH025BgwnFuh9C9GrZUJRQ5XF8vXxyBeOmqbYR9f1NgN2QKb9rhVHCIlGQY1YOsg9a 1faZunKLsQpUaZIVZ6n0xnENErVN2t6vWbFnpIjHzZ/h0XREoD9QtgNqDE3dhb2zADEG Vh3F8O6JpQDSBqJqzSD/6P1w/UG5Mkg9SUxMsfQDi2CX5Ab2ir8Ilsf0PoyGOIhItVq7 CeFWq+8hTEJN8/cYNjjbs42QjgVGhc4VcTeOEP1+ja58DHCnf2yaWaSLp5sWcUJEuxz9 4WWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=RFh2OYp1AIw9+1gIuk13B075+zUU8XY1s7bawa7LB6o=; b=IYAJEKX9eYELDkC5a4h4m8yrER6/OySM7NYbq0PVDlmNYGaUAwzfUZMlfRl9hYdhcF OKYwGf3aLFUmqUe3suaZa+A1SRZkbF90XcV4easMEjM3l4vH0eyZ8leVrDYt1JPliOW4 s5rY4BvqgtPyHl4i0uhogmorzYRgPCMzmUTtagD+I2f4SK7TzCMGdMRoavNN9HLr5sNO ArAXCp3XTN5/1edeG8wp9Ez47QPya3q8PuAtpJX+rk/fJXyr95S/1SFdbfr18F7ZNOvj K+wq9l2/uBmrx2/xUMh5fCrKlfX9U1amHHb8LDxZmHkGPlup7kOiELCjr69cNc7r7+q+ b1bQ== X-Gm-Message-State: AOAM533AE5rc+3CXCz50fx+dFn4uhlhN/ogSSc3GPw7uhq42R+fDz2Fi yFuqdZVBYysX9nSRek7lse1BuA== X-Received: by 2002:adf:fc90:: with SMTP id g16mr8162873wrr.40.1607602527723; Thu, 10 Dec 2020 04:15:27 -0800 (PST) Received: from localhost.localdomain (lns-bzn-59-82-252-158-132.adsl.proxad.net. [82.252.158.132]) by smtp.gmail.com with ESMTPSA id k6sm8412863wmf.25.2020.12.10.04.15.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Dec 2020 04:15:27 -0800 (PST) From: Daniel Lezcano To: daniel.lezcano@linaro.org, rui.zhang@intel.com Cc: kai.heng.feng@canonical.com, lukasz.luba@arm.com, srinivas.pandruvada@linux.intel.com, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, =?utf-8?q?Niklas_S=C3=B6derlund?= , Amit Kucheria , linux-renesas-soc@vger.kernel.org (open list:RENESAS R-CAR THERMAL DRIVERS) Subject: [PATCH 4/5] thermal/drivers/rcar: Remove notification usage Date: Thu, 10 Dec 2020 13:15:13 +0100 Message-Id: <20201210121514.25760-4-daniel.lezcano@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201210121514.25760-1-daniel.lezcano@linaro.org> References: <20201210121514.25760-1-daniel.lezcano@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org The ops is only showing a trace telling a critical trip point is crossed. The same information is given by the thermal framework. This is redundant, remove the code. Signed-off-by: Daniel Lezcano --- drivers/thermal/rcar_thermal.c | 19 ------------------- 1 file changed, 19 deletions(-) -- 2.17.1 Reviewed-by: Niklas Söderlund diff --git a/drivers/thermal/rcar_thermal.c b/drivers/thermal/rcar_thermal.c index 6ae757d66f46..b49f04daaf47 100644 --- a/drivers/thermal/rcar_thermal.c +++ b/drivers/thermal/rcar_thermal.c @@ -323,24 +323,6 @@ static int rcar_thermal_get_trip_temp(struct thermal_zone_device *zone, return 0; } -static int rcar_thermal_notify(struct thermal_zone_device *zone, - int trip, enum thermal_trip_type type) -{ - struct rcar_thermal_priv *priv = rcar_zone_to_priv(zone); - struct device *dev = rcar_priv_to_dev(priv); - - switch (type) { - case THERMAL_TRIP_CRITICAL: - /* FIXME */ - dev_warn(dev, "Thermal reached to critical temperature\n"); - break; - default: - break; - } - - return 0; -} - static const struct thermal_zone_of_device_ops rcar_thermal_zone_of_ops = { .get_temp = rcar_thermal_of_get_temp, }; @@ -349,7 +331,6 @@ static struct thermal_zone_device_ops rcar_thermal_zone_ops = { .get_temp = rcar_thermal_get_temp, .get_trip_type = rcar_thermal_get_trip_type, .get_trip_temp = rcar_thermal_get_trip_temp, - .notify = rcar_thermal_notify, }; /*