From patchwork Tue May 16 05:22:43 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 99843 Delivered-To: patch@linaro.org Received: by 10.140.96.100 with SMTP id j91csp1856225qge; Mon, 15 May 2017 22:23:10 -0700 (PDT) X-Received: by 10.99.171.1 with SMTP id p1mr9898371pgf.16.1494912190019; Mon, 15 May 2017 22:23:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1494912190; cv=none; d=google.com; s=arc-20160816; b=CQICHfNtJ2YNInTLCaAV490vdziq9tH05h1vXKsHlH71NgIMRyLudyGJWJA5hcAeZ/ SKuxVTUBiUiVQ6EijxGVpIr+++cmamRRCJH+wkAdr9OJaCyb9QDTs3jtZW6Ml18n9skH uqzCCS7uIPl72Gu9r5A4cmkxDAeN73l4kX73+V+b4wwOqxi71xpcDNTkjlN/8vEgNYAz sdwbHlEGj4ZSXdc2u+X6yYy9PNS6XX6IY/LUDznaZ/bnsDiqLykzI56SsOjE1PKkqWcS 7CQCK3ExtHttymayNVN/uaJVtaCZh5/JBlFiKJD7/M7z9VHB73TPSDcbU0zsU/OV+cGY VugA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=erxYm/LN1hRpZI6cZp+O9MdG45Rnq3oF5lp3Pv39/I8=; b=ii2aOMXTUwpnuKRDpju3mLCFAzP4/guUnR+19DRrSmUA5MO/k0XLrzw/z529IE1qhp Ok/8c7CYtgTtMOk6mwJu9Wozn59B/r6qxmBaKbHSQ+2kKekwQtpxuKuZ+uL5FeXK+lOJ Kx1QA9EmDjhvYE2P4/MC556gPgIpWI8zlcBUI/BcgEgUhSqtIEowGS8ezZrCJ830g41A dseUJz8uwqUIJw6CxagBjnJcuvByBO/VapAHOsEyq4pjRLASuZ26ioAboHIS+rPJ2y40 vCx0p0durNRf3iMyvGqCNByvH/x/81/c3PXHvWJs3ZDGgMStuFcdySeXF2knAlpDO/p+ M+mg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-pm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-pm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i20si12772673pfd.20.2017.05.15.22.23.09; Mon, 15 May 2017 22:23:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-pm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-pm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-pm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751491AbdEPFXE (ORCPT + 14 others); Tue, 16 May 2017 01:23:04 -0400 Received: from mail-pg0-f52.google.com ([74.125.83.52]:32947 "EHLO mail-pg0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751437AbdEPFXC (ORCPT ); Tue, 16 May 2017 01:23:02 -0400 Received: by mail-pg0-f52.google.com with SMTP id u187so70590924pgb.0 for ; Mon, 15 May 2017 22:22:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=erxYm/LN1hRpZI6cZp+O9MdG45Rnq3oF5lp3Pv39/I8=; b=AqxYoh2U6UZiGOtT44GljK+QTD+bEkUJAvt8w/oLiYl/hTseTzGVktWwswsSW29epX GjmkdmcH2KLAF0WjLDy+N3GkWojP+DkeF1+lcmtIIzz2cu29rIbEnnv5rQrl9WzM9iDt +t/rquiC1/B2SeZjPpGJfOKLC1vZhI1K1kxso= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=erxYm/LN1hRpZI6cZp+O9MdG45Rnq3oF5lp3Pv39/I8=; b=ltQiOFhMvkUI+w3ADArzRL/uoY88fvl3Is/Codl+GhGBqpWCRMAYcHer+em0DwGxT/ eeDwjbiaolnckbKXIp2aC8WhP42tS8GahQUylEDx+Uyd7H2jJNcfVvHDkehaYUXer09R yzKn78bQbKL/C0jT9ZMERGVhiw+Q5vwuVXxpO2APlWhiw8hVGEAndLQiEwL6dsLU908X /B7qjxwh2BR14LabdrUF88nO+P1RecnUSLKsZ3dY6iCONfzr4lr0rra/TUSctTq5VFM2 f3PxJ4YX/KcaXVWzaVZhw/hMM2hQ6L8RS9SOptQ6DNBWHyMbxrbuGtT5EkEoKOaAF0Z3 aqLw== X-Gm-Message-State: AODbwcAvvYCoGw07JJIcbPLumtgjw+0NNacUafv7RA9e9JPKCtmIeHOu ig2aNBKX9yvPa4pH X-Received: by 10.99.42.199 with SMTP id q190mr9823609pgq.13.1494912176936; Mon, 15 May 2017 22:22:56 -0700 (PDT) Received: from localhost ([122.172.66.217]) by smtp.gmail.com with ESMTPSA id r21sm23172016pfg.95.2017.05.15.22.22.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 15 May 2017 22:22:55 -0700 (PDT) From: Viresh Kumar To: Rafael Wysocki , Kevin Hilman , Ulf Hansson , Pavel Machek , Len Brown Cc: linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Vincent Guittot , Viresh Kumar Subject: [PATCH] PM / Domains: pdd->dev can't be NULL in genpd_dev_pm_qos_notifier() Date: Tue, 16 May 2017 10:52:43 +0530 Message-Id: <201976beb620010271d6f842abbc40a93f55bd73.1494912124.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 2.13.0.303.g4ebf3021692d Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org The pm_domain_data (pdd) pointer is set from genpd_alloc_dev_data() and pdd->dev is guaranteed to be valid. There is no need to check pdd and pdd->dev in rest of the code as pdd->dev will always be valid for a non NULL pdd pointer. Signed-off-by: Viresh Kumar --- drivers/base/power/domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.13.0.303.g4ebf3021692d diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c index da49a8383dc3..71c95ad808d5 100644 --- a/drivers/base/power/domain.c +++ b/drivers/base/power/domain.c @@ -443,7 +443,7 @@ static int genpd_dev_pm_qos_notifier(struct notifier_block *nb, pdd = dev->power.subsys_data ? dev->power.subsys_data->domain_data : NULL; - if (pdd && pdd->dev) { + if (pdd) { to_gpd_data(pdd)->td.constraint_changed = true; genpd = dev_to_genpd(dev); } else {