From patchwork Tue May 29 10:04:13 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ulf Hansson X-Patchwork-Id: 137135 Delivered-To: patches@linaro.org Received: by 2002:a2e:9706:0:0:0:0:0 with SMTP id r6-v6csp3845336lji; Tue, 29 May 2018 03:04:29 -0700 (PDT) X-Received: by 2002:a19:b587:: with SMTP id g7-v6mr8975286lfk.144.1527588269449; Tue, 29 May 2018 03:04:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527588269; cv=none; d=google.com; s=arc-20160816; b=WQMuy+ACtmaSRMW3AoRBkyWo9/EYW8MD34UFgDKwfjXAlpI49vnLH/rsMGnoNWjIkE UUqBupSt/pmVQwlRlPZ5lp+TULX4iJtHa16KpEXO9hFSRDRFvEzYunfj3gvJVGRO7GHu hXXIsAJ+x1AKRoPuKgBXNMbq1A3JMBqO4x2JHB/3tyg1PUu5Nc09KXMzr2SYdPl+A8F2 rvoGgOlEt7u+Z/0COPlH/uuqieuYoCabaetpO1WISbEwdMkvwst4TvdQFv97+vhPGCbn z4ROI3LQHf8PZfiT4FI2dmYXPJG6+MJyecTmRqVCDfZqAXwADKaqX2zdzOaFWh9Wd7cm MEWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=RNBwx9Q11leZ2iF4Qt72vYGl8mmLcTrVpjkvTy5woOY=; b=OsRaTXDAJK1jtoLyQUw2kSD2eSEaCP6QY7e8HGeLHnPTFC5Igob/I/spcwXPJtixCx S6LvznqkAZG+Vaj2zbUc2MvmcsMyLufWO+eZbMfcsLkF4TLKsYbDD1MvVP0Q435VkHtr AkGKnCQiwnGX1XWG2/LIFQqwLPRiEO35vIByhFMskvOYIQlfzm77pBwbUH98h1gEhIQb /foJbrfgPWUEsej95fLsUZtpwqIseT2OV45NO+z4zDVmx/QnKEALxIOSV3hy50n9sMRv P1EvmMewCe53pdMtrUKv3LSaBDvui1ENZtQpopGwrLN2vNjzeH5nQHXiBaNEmpCQHR3W Kd1w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=JyiIbZ8w; spf=pass (google.com: domain of ulf.hansson@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=ulf.hansson@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id 82-v6sor1253144lje.13.2018.05.29.03.04.29 for (Google Transport Security); Tue, 29 May 2018 03:04:29 -0700 (PDT) Received-SPF: pass (google.com: domain of ulf.hansson@linaro.org designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=JyiIbZ8w; spf=pass (google.com: domain of ulf.hansson@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=ulf.hansson@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=RNBwx9Q11leZ2iF4Qt72vYGl8mmLcTrVpjkvTy5woOY=; b=JyiIbZ8wh7YZNGv9pnIcFOD5oafNJ+zlQqcKEE1CZ44YU7y7LlBh6hPVeKDXus0OS4 QlSFN8TsyThEt6g5vVS4rjGTLW7q3a2s1Ccd+NKSn2+apUgEfrWSwY7txaA0whWvepPw 8Jvo6TeOcWPvMYHRH/rhYcsq7k7mKrxs49V9Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=RNBwx9Q11leZ2iF4Qt72vYGl8mmLcTrVpjkvTy5woOY=; b=kGrS0Q1BTvfTw5r/F41lSxpFLhellnQWzEviNHEflnQorRzyKXYN8QeGO6QgsCK0hr jb22Tdh740S5lkC3UkvvHTqUqYKq2pUZweEjnkZiJGyc0yrNEZwyMLjVUqAKayuEaHcJ SgVutwFI9VP6yUc0J4ag54vq70HiSosHrPV05fhlWwzISbgc4Fj6qdsyHGV8MkZ7+vST 6ZktVzWT9yzsKe4iRI/AGy1FLW6vO14NgGa0yglN83D+bs0ekpXq6c42LcD87b0IZajq GplaupJMqhXwz9Yt4fSMq8a0VnQNRD9B9akV3AZ0SmmoZjgRAp8EbBsZ9W5V5UPX4TcP W+nQ== X-Gm-Message-State: ALKqPwcskYbLgSHZBWwGVrpypWaJHcqW6KkhFFhV5OwQZeBBxJWsWC6M 4VJooxiL3fgvum6FDYXj2As2AXvK X-Google-Smtp-Source: ADUXVKJMzT40/2PTq1QaebRlZduwZauw+klH1h7H1KOqei5y3Fn80g2TLQ7ZD3gflxPlsLgTXmyeqQ== X-Received: by 2002:a2e:8794:: with SMTP id n20-v6mr10640999lji.38.1527588269201; Tue, 29 May 2018 03:04:29 -0700 (PDT) Return-Path: Received: from localhost.localdomain (h-158-174-22-210.NA.cust.bahnhof.se. [158.174.22.210]) by smtp.gmail.com with ESMTPSA id e21-v6sm2561718lfg.74.2018.05.29.03.04.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 29 May 2018 03:04:28 -0700 (PDT) From: Ulf Hansson To: "Rafael J . Wysocki" , linux-pm@vger.kernel.org Cc: Ulf Hansson , Greg Kroah-Hartman , Jon Hunter , Geert Uytterhoeven , Todor Tomov , Rajendra Nayak , Viresh Kumar , Vincent Guittot , Kevin Hilman , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org Subject: [PATCH v2 1/9] PM / Domains: Drop extern declarations of functions in pm_domain.h Date: Tue, 29 May 2018 12:04:13 +0200 Message-Id: <20180529100421.31022-2-ulf.hansson@linaro.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180529100421.31022-1-ulf.hansson@linaro.org> References: <20180529100421.31022-1-ulf.hansson@linaro.org> Using "extern" to declare a function in a public header file is somewhat pointless, but also doesn't hurt. However, to make all the function declarations in pm_domain.h to be consistent, let's drop the use of "extern". Signed-off-by: Ulf Hansson --- include/linux/pm_domain.h | 51 ++++++++++++++++++--------------------- 1 file changed, 23 insertions(+), 28 deletions(-) -- 2.17.0 Acked-by: Viresh Kumar diff --git a/include/linux/pm_domain.h b/include/linux/pm_domain.h index 4e5764083fd8..c847e9a3033d 100644 --- a/include/linux/pm_domain.h +++ b/include/linux/pm_domain.h @@ -143,21 +143,17 @@ static inline struct generic_pm_domain_data *dev_gpd_data(struct device *dev) return to_gpd_data(dev->power.subsys_data->domain_data); } -extern int __pm_genpd_add_device(struct generic_pm_domain *genpd, - struct device *dev, - struct gpd_timing_data *td); - -extern int pm_genpd_remove_device(struct generic_pm_domain *genpd, - struct device *dev); -extern int pm_genpd_add_subdomain(struct generic_pm_domain *genpd, - struct generic_pm_domain *new_subdomain); -extern int pm_genpd_remove_subdomain(struct generic_pm_domain *genpd, - struct generic_pm_domain *target); -extern int pm_genpd_init(struct generic_pm_domain *genpd, - struct dev_power_governor *gov, bool is_off); -extern int pm_genpd_remove(struct generic_pm_domain *genpd); -extern int dev_pm_genpd_set_performance_state(struct device *dev, - unsigned int state); +int __pm_genpd_add_device(struct generic_pm_domain *genpd, struct device *dev, + struct gpd_timing_data *td); +int pm_genpd_remove_device(struct generic_pm_domain *genpd, struct device *dev); +int pm_genpd_add_subdomain(struct generic_pm_domain *genpd, + struct generic_pm_domain *new_subdomain); +int pm_genpd_remove_subdomain(struct generic_pm_domain *genpd, + struct generic_pm_domain *target); +int pm_genpd_init(struct generic_pm_domain *genpd, + struct dev_power_governor *gov, bool is_off); +int pm_genpd_remove(struct generic_pm_domain *genpd); +int dev_pm_genpd_set_performance_state(struct device *dev, unsigned int state); extern struct dev_power_governor simple_qos_governor; extern struct dev_power_governor pm_domain_always_on_gov; @@ -215,8 +211,8 @@ static inline int pm_genpd_add_device(struct generic_pm_domain *genpd, } #ifdef CONFIG_PM_GENERIC_DOMAINS_SLEEP -extern void pm_genpd_syscore_poweroff(struct device *dev); -extern void pm_genpd_syscore_poweron(struct device *dev); +void pm_genpd_syscore_poweroff(struct device *dev); +void pm_genpd_syscore_poweron(struct device *dev); #else static inline void pm_genpd_syscore_poweroff(struct device *dev) {} static inline void pm_genpd_syscore_poweron(struct device *dev) {} @@ -240,14 +236,13 @@ int of_genpd_add_provider_simple(struct device_node *np, int of_genpd_add_provider_onecell(struct device_node *np, struct genpd_onecell_data *data); void of_genpd_del_provider(struct device_node *np); -extern int of_genpd_add_device(struct of_phandle_args *args, - struct device *dev); -extern int of_genpd_add_subdomain(struct of_phandle_args *parent, - struct of_phandle_args *new_subdomain); -extern struct generic_pm_domain *of_genpd_remove_last(struct device_node *np); -extern int of_genpd_parse_idle_states(struct device_node *dn, - struct genpd_power_state **states, int *n); -extern unsigned int of_genpd_opp_to_performance_state(struct device *dev, +int of_genpd_add_device(struct of_phandle_args *args, struct device *dev); +int of_genpd_add_subdomain(struct of_phandle_args *parent, + struct of_phandle_args *new_subdomain); +struct generic_pm_domain *of_genpd_remove_last(struct device_node *np); +int of_genpd_parse_idle_states(struct device_node *dn, + struct genpd_power_state **states, int *n); +unsigned int of_genpd_opp_to_performance_state(struct device *dev, struct device_node *opp_node); int genpd_dev_pm_attach(struct device *dev); @@ -304,9 +299,9 @@ struct generic_pm_domain *of_genpd_remove_last(struct device_node *np) #endif /* CONFIG_PM_GENERIC_DOMAINS_OF */ #ifdef CONFIG_PM -extern int dev_pm_domain_attach(struct device *dev, bool power_on); -extern void dev_pm_domain_detach(struct device *dev, bool power_off); -extern void dev_pm_domain_set(struct device *dev, struct dev_pm_domain *pd); +int dev_pm_domain_attach(struct device *dev, bool power_on); +void dev_pm_domain_detach(struct device *dev, bool power_off); +void dev_pm_domain_set(struct device *dev, struct dev_pm_domain *pd); #else static inline int dev_pm_domain_attach(struct device *dev, bool power_on) {