From patchwork Tue Nov 3 02:29:33 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 55921 Delivered-To: patch@linaro.org Received: by 10.112.61.134 with SMTP id p6csp1597703lbr; Mon, 2 Nov 2015 18:29:43 -0800 (PST) X-Received: by 10.50.142.8 with SMTP id rs8mr15067643igb.87.1446517783435; Mon, 02 Nov 2015 18:29:43 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u102si19446082ioi.194.2015.11.02.18.29.43; Mon, 02 Nov 2015 18:29:43 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-pm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-pm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-pm-owner@vger.kernel.org; dkim=neutral (body hash did not verify) header.i=@linaro_org.20150623.gappssmtp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753861AbbKCC3j (ORCPT + 11 others); Mon, 2 Nov 2015 21:29:39 -0500 Received: from mail-pa0-f46.google.com ([209.85.220.46]:34581 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753824AbbKCC3i (ORCPT ); Mon, 2 Nov 2015 21:29:38 -0500 Received: by padec8 with SMTP id ec8so3950815pad.1 for ; Mon, 02 Nov 2015 18:29:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro_org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=+gohkf7gMV4aEMlozwxlWiqfKdp+2lO2GycVQU/QXsU=; b=y5hGZK35E2aHWayYYbg5YJuedQN4H/owMnQ/4h1Xx7TRfwxAOTgRCkvHNnC+RNndX2 r5POZ9DWMKuNnkBLbbaEh/oZQBi4aEIijn+uM9zharBG/qLri8OKnEnF6lyh0qfjCQEA Lyl7OZqEjmEdL9DnNLhoZofNwN9yqtmN4ONiOAeA5NM4V6bIol4/WgpfW7dZiUQPI6LE bPwiSZKZoHue+TsZccdatWFiXN6+ldTnQzADMCpKRxDPDNCMF2oHjW6n7dPoG5IPytqJ /yJitqb34w43ABoc3u87d6Y4wgH4cZ5NDLAmvvnBUPRkjOzbvkjQ7eMH/vVChEI+JQlp fCEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=+gohkf7gMV4aEMlozwxlWiqfKdp+2lO2GycVQU/QXsU=; b=SR8jG67+imO1JeoTCEJDds77E+OAw1FkzxH0bZ9HSUTg1ZGxTL+AX71rYlaFWPDBS4 UQj7+J7/CPdEdTJe36xISo49mUnuJ7nib6RpFkb+iLCs2JkA6ePG7aHqJnJN5Gs8V81J Gui9KOqoFauZfSb61VGjDbxLh8PgAL8jNr4fFDvc0zbwrhrndGA9pAXX/2Igvicj7Yx2 kKjH5zyWZ0EOwttPMVP8FKm9VnfWsAwa7/xFc9U+XITARhwwEWtRVi3npCHCrXa/8CVr S50G9LZP+7eGfrcHdO3u/mnJ9ceXBbSy3kItzsABuGcpLg4OpgRou6Ta1MoeWmryKafq 6mPw== X-Gm-Message-State: ALoCoQnjQOEItiXRET1+xo+kDO5ti8w2gdgBPG6gm2FTO3d3LPCveibRwlObRgFucdxfzs9y4QdP X-Received: by 10.66.184.42 with SMTP id er10mr31547267pac.117.1446517777872; Mon, 02 Nov 2015 18:29:37 -0800 (PST) Received: from localhost ([122.172.111.169]) by smtp.gmail.com with ESMTPSA id er1sm26474395pbb.6.2015.11.02.18.29.36 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 02 Nov 2015 18:29:37 -0800 (PST) Date: Tue, 3 Nov 2015 07:59:33 +0530 From: Viresh Kumar To: Stephen Boyd Cc: Rafael Wysocki , robh+dt@kernel.org, lee.jones@linaro.org, linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, mark.rutland@arm.com, pawel.moll@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, nm@ti.com, devicetree@vger.kernel.org, open list , "Rafael J. Wysocki" Subject: Re: [PATCH 1/3] PM / OPP: Add "opp-supported-hw" binding Message-ID: <20151103022933.GN3639@ubuntu> References: <2d52388bd7d3cc546ac3ab5afeb47bfcb3012213.1446167359.git.viresh.kumar@linaro.org> <20151030221826.GM19782@codeaurora.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20151030221826.GM19782@codeaurora.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On 30-10-15, 15:18, Stephen Boyd wrote: > A side-note. I wonder if it would be better style to have the > node name be: > > opp@600000000 { > > At least it seems that the assumption is we can store all the > possible combinations of OPP values for a particular frequency in > the same node. Following this style would make dt compilation > fail if two nodes have the same frequency. From: Viresh Kumar Date: Tue, 3 Nov 2015 07:51:09 +0530 Subject: [PATCH] PM / OPP: Rename OPP nodes as opp@ It would be better to name OPP nodes as opp@ as that will ensure that multiple DT nodes don't contain the same frequency. Of course we expect the writer to name the node with its opp-hz frequency and not any other frequency. And that will let the compile error out if multiple nodes are using the same opp-hz frequency. Suggested-by: Stephen Boyd Signed-off-by: Viresh Kumar --- Documentation/devicetree/bindings/opp/opp.txt | 38 +++++++++++++-------------- 1 file changed, 19 insertions(+), 19 deletions(-) -- viresh -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/Documentation/devicetree/bindings/opp/opp.txt b/Documentation/devicetree/bindings/opp/opp.txt index 8d4a4075d634..3af2eca7212a 100644 --- a/Documentation/devicetree/bindings/opp/opp.txt +++ b/Documentation/devicetree/bindings/opp/opp.txt @@ -183,20 +183,20 @@ Example 1: Single cluster Dual-core ARM cortex A9, switch DVFS states together. compatible = "operating-points-v2"; opp-shared; - opp00 { + opp@1000000000 { opp-hz = /bits/ 64 <1000000000>; opp-microvolt = <970000 975000 985000>; opp-microamp = <70000>; clock-latency-ns = <300000>; opp-suspend; }; - opp01 { + opp@1100000000 { opp-hz = /bits/ 64 <1100000000>; opp-microvolt = <980000 1000000 1010000>; opp-microamp = <80000>; clock-latency-ns = <310000>; }; - opp02 { + opp@1200000000 { opp-hz = /bits/ 64 <1200000000>; opp-microvolt = <1025000>; clock-latency-ns = <290000>; @@ -262,20 +262,20 @@ independently. * independently. */ - opp00 { + opp@1000000000 { opp-hz = /bits/ 64 <1000000000>; opp-microvolt = <970000 975000 985000>; opp-microamp = <70000>; clock-latency-ns = <300000>; opp-suspend; }; - opp01 { + opp@1100000000 { opp-hz = /bits/ 64 <1100000000>; opp-microvolt = <980000 1000000 1010000>; opp-microamp = <80000>; clock-latency-ns = <310000>; }; - opp02 { + opp@1200000000 { opp-hz = /bits/ 64 <1200000000>; opp-microvolt = <1025000>; opp-microamp = <90000; @@ -338,20 +338,20 @@ DVFS state together. compatible = "operating-points-v2"; opp-shared; - opp00 { + opp@1000000000 { opp-hz = /bits/ 64 <1000000000>; opp-microvolt = <970000 975000 985000>; opp-microamp = <70000>; clock-latency-ns = <300000>; opp-suspend; }; - opp01 { + opp@1100000000 { opp-hz = /bits/ 64 <1100000000>; opp-microvolt = <980000 1000000 1010000>; opp-microamp = <80000>; clock-latency-ns = <310000>; }; - opp02 { + opp@1200000000 { opp-hz = /bits/ 64 <1200000000>; opp-microvolt = <1025000>; opp-microamp = <90000>; @@ -364,20 +364,20 @@ DVFS state together. compatible = "operating-points-v2"; opp-shared; - opp10 { + opp@1300000000 { opp-hz = /bits/ 64 <1300000000>; opp-microvolt = <1045000 1050000 1055000>; opp-microamp = <95000>; clock-latency-ns = <400000>; opp-suspend; }; - opp11 { + opp@1400000000 { opp-hz = /bits/ 64 <1400000000>; opp-microvolt = <1075000>; opp-microamp = <100000>; clock-latency-ns = <400000>; }; - opp12 { + opp@1500000000 { opp-hz = /bits/ 64 <1500000000>; opp-microvolt = <1010000 1100000 1110000>; opp-microamp = <95000>; @@ -404,7 +404,7 @@ Example 4: Handling multiple regulators compatible = "operating-points-v2"; opp-shared; - opp00 { + opp@1000000000 { opp-hz = /bits/ 64 <1000000000>; opp-microvolt = <970000>, /* Supply 0 */ <960000>, /* Supply 1 */ @@ -417,7 +417,7 @@ Example 4: Handling multiple regulators /* OR */ - opp00 { + opp@1000000000 { opp-hz = /bits/ 64 <1000000000>; opp-microvolt = <970000 975000 985000>, /* Supply 0 */ <960000 965000 975000>, /* Supply 1 */ @@ -430,7 +430,7 @@ Example 4: Handling multiple regulators /* OR */ - opp00 { + opp@1000000000 { opp-hz = /bits/ 64 <1000000000>; opp-microvolt = <970000 975000 985000>, /* Supply 0 */ <960000 965000 975000>, /* Supply 1 */ @@ -462,7 +462,7 @@ Example 5: opp-supported-hw status = "okay"; opp-shared; - opp00 { + opp@600000000 { /* * Supports all substrate and process versions for 0xF * cuts, i.e. only first four cuts. @@ -473,7 +473,7 @@ Example 5: opp-supported-hw ... }; - opp01 { + opp@800000000 { /* * Supports: * - cuts: only one, 6th cut (represented by 6th bit). @@ -506,7 +506,7 @@ Example 6: opp-microvolt-, opp-microamp-, turbo-mode-, compatible = "operating-points-v2"; opp-shared; - opp00 { + opp@1000000000 { opp-hz = /bits/ 64 <1000000000>; opp-microvolt-slow = <900000 915000 925000>; opp-microvolt-fast = <970000 975000 985000>; @@ -516,7 +516,7 @@ Example 6: opp-microvolt-, opp-microamp-, turbo-mode-, opp-suspend-slow; /* Will be used as suspend-opp only if 'slow' is chosen */ }; - opp01 { + opp@1200000000 { opp-hz = /bits/ 64 <1200000000>; opp-microvolt-slow = <900000 915000 925000>, /* Supply vcc0 */ <910000 925000 935000>; /* Supply vcc1 */