From patchwork Mon Aug 3 03:46:42 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 51841 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-la0-f69.google.com (mail-la0-f69.google.com [209.85.215.69]) by patches.linaro.org (Postfix) with ESMTPS id 9B1F1229FD for ; Mon, 3 Aug 2015 03:46:53 +0000 (UTC) Received: by labth1 with SMTP id th1sf16164751lab.2 for ; Sun, 02 Aug 2015 20:46:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:date:from:to:cc:subject:message-id :references:mime-version:content-type:content-disposition :in-reply-to:user-agent:sender:precedence:list-id:x-original-sender :x-original-authentication-results:mailing-list:list-post:list-help :list-archive:list-unsubscribe; bh=z2bjqw3nJCnNZzJJGi4AAUvQrD8eNWkHR2otwQEUsao=; b=Pw1/ShP4mCra5Ojp3FtNhMu1FFq/tJdnj4JS03hK3zERqa5q5/yTFvku78SuwsiscN hEj1S/t1AY8avuJWbJ2N12fPuj9rLsjk2w4dM00snhS476ESxVOekvY6vFKKcc2dm2F8 FcobobJXOUOIBekw7urfgUKlqlEARDghbHMeQbjYLbLwGoGuS06njoDDzy/3YFWYE/qN 0ajTHD268Lzt+7qgnQgftIPsgVVpO905O6+wPd19vIhkbXVSKRTKWCWuPDpcMjEcCDkE f/1Rg7B89yNngKXuKL5baGzTqo/r4ZbUFuLeucpQtpR7BI5Q5ISB+mJOIjtBJFbG3cIX OBrw== X-Gm-Message-State: ALoCoQnVKFgcWi9U8F+H9zQnLgdo3pdXrGL13DSadCMF6/tNT1R8zQSj3lmAtD8rpBpdFlTRZQEj X-Received: by 10.152.88.111 with SMTP id bf15mr4892297lab.9.1438573612478; Sun, 02 Aug 2015 20:46:52 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.23.162 with SMTP id n2ls560278laf.82.gmail; Sun, 02 Aug 2015 20:46:52 -0700 (PDT) X-Received: by 10.112.52.2 with SMTP id p2mr14514573lbo.8.1438573612330; Sun, 02 Aug 2015 20:46:52 -0700 (PDT) Received: from mail-lb0-f171.google.com (mail-lb0-f171.google.com. [209.85.217.171]) by mx.google.com with ESMTPS id xs6si572882lac.46.2015.08.02.20.46.52 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 02 Aug 2015 20:46:52 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.171 as permitted sender) client-ip=209.85.217.171; Received: by lbbyj8 with SMTP id yj8so70978108lbb.0 for ; Sun, 02 Aug 2015 20:46:52 -0700 (PDT) X-Received: by 10.152.25.228 with SMTP id f4mr14416579lag.112.1438573612187; Sun, 02 Aug 2015 20:46:52 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.7.198 with SMTP id l6csp1637048lba; Sun, 2 Aug 2015 20:46:50 -0700 (PDT) X-Received: by 10.68.217.102 with SMTP id ox6mr19533615pbc.158.1438573610686; Sun, 02 Aug 2015 20:46:50 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id rt10si10553672pbc.165.2015.08.02.20.46.49; Sun, 02 Aug 2015 20:46:50 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752587AbbHCDqs (ORCPT + 8 others); Sun, 2 Aug 2015 23:46:48 -0400 Received: from mail-pa0-f51.google.com ([209.85.220.51]:35537 "EHLO mail-pa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752324AbbHCDqr (ORCPT ); Sun, 2 Aug 2015 23:46:47 -0400 Received: by pasy3 with SMTP id y3so3759527pas.2 for ; Sun, 02 Aug 2015 20:46:46 -0700 (PDT) X-Received: by 10.68.138.166 with SMTP id qr6mr19506560pbb.57.1438573606623; Sun, 02 Aug 2015 20:46:46 -0700 (PDT) Received: from localhost ([122.171.186.190]) by smtp.gmail.com with ESMTPSA id bx13sm15747779pac.7.2015.08.02.20.46.45 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sun, 02 Aug 2015 20:46:45 -0700 (PDT) Date: Mon, 3 Aug 2015 09:16:42 +0530 From: Viresh Kumar To: Stephen Boyd Cc: Rob Herring , Lee Jones , Nishanth Menon , kernel@stlinux.com, "linux-pm@vger.kernel.org" , Dmitry Eremin-Solenikov , Rafael Wysocki , "linux-kernel@vger.kernel.org" , Sebastian Reichel , "devicetree@vger.kernel.org" , Arnd Bergmann , Ajit Pal Singh , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v4 2/2] dt: power: st: Provide bindings for ST's OPPs Message-ID: <20150803034642.GV899@linux> References: <1438010430-5802-1-git-send-email-lee.jones@linaro.org> <1438010430-5802-2-git-send-email-lee.jones@linaro.org> <20150728022936.GB1229@linux> <20150728225510.GB3159@codeaurora.org> <20150729081403.GH2284@x1> <20150729221526.GE3159@codeaurora.org> <20150730084634.GD9319@x1> <20150731163715.GV3159@codeaurora.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20150731163715.GV3159@codeaurora.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: devicetree-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: devicetree@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: viresh.kumar@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.171 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , On 31-07-15, 09:37, Stephen Boyd wrote: > For qcom platforms, the frequency is almost always constant. > There may be some tables where we have a couple higher > frequencies than others because the speed bin is different. > Otherwise the voltage/current is changing based on the silicon > characteristics. So the biggest duplication is the frequency > property. > > As far as I know there isn't any algorithm to generate the > voltage values. It's all hand tuned tables based on the silicon > characterization, so we're left to store these tables in DT and > pick the right one at runtime. With regards to the table > explosion, on qcom platforms we haven't worried that we have ~40 > tables, but I'm not opposed to expressing it in a smaller set of > nodes, tables, etc. if that's what's desired. > > Do we need vendor specific properties for that though? Or do we > need some sort of extended frequency/voltage properties that are > arrays of values that we can index into based on some silicon > characteristics? I like the name based approach because it's > simple. Use this OPP table because it's called > x-y-z-characteristics and be done. Cramming the tables into less > lines may save us some typing and dtb space, but I'm not sure > what else it does. What about something like this: diff --git a/Documentation/devicetree/bindings/opp/opp.txt b/Documentation/devicetree/bindings/opp/opp.txt index 0cb44dc21f97..bad7a8299b9c 100644 --- a/Documentation/devicetree/bindings/opp/opp.txt +++ b/Documentation/devicetree/bindings/opp/opp.txt @@ -74,6 +74,8 @@ This describes the OPPs belonging to a device. This node can have following reference an OPP. Optional properties: +- opp-cuts: One or more strings, describing the versions of hardware the OPPs + can support. - opp-shared: Indicates that device nodes using this OPP Table Node's phandle switch their DVFS state together, i.e. they share clock/voltage/current lines. Missing property means devices have independent clock/voltage/current lines, @@ -100,6 +102,9 @@ properties. Entries for multiple regulators must be present in the same order as regulators are specified in device's DT node. + If used with 'opp-cuts', then the number of entries present here must match + the number of strings present in 'opp-cuts'. + - opp-microamp: The maximum current drawn by the device in microamperes considering system specific parameters (such as transients, process, aging, maximum operating temperature range etc.) as necessary. This may be used to