From patchwork Thu Apr 24 16:20:16 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 884170 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B6769284B5C for ; Thu, 24 Apr 2025 16:20:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745511638; cv=none; b=CYHN11qoq4ds2EK/a1JKh3KcCRlnj3LOuAZUJ0IERgT+7ehb9p9OerknJQJN0IWBYLyRiwtzww2hkkBLPRfBPFE8tvV2ZXjyOVpjWb0AnjZJiIyRf2T0AWTk8E7N3XxNQscdiXHPz5PHz73fReHh6u9XUK5OO/6LEspCvI1ccLU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745511638; c=relaxed/simple; bh=Oyi1VC9Aa9JQ7UlLN4XL/e3gaecAn+Lfe0RV04nRiz4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ZgjMIKrgTchq/V95u93FbzlA8/pckYbpArOk2GIStPxoiSPtV8ZNs0StO3FvAuMdlh+SCq+Y3BIzS8CQyBAi8MyGbmDxSUV9F7/UPtUfBz7gc/JkMqbu7mehGSwDSKV7XQqxwsUrxIu2o8AfyjfeDQjkmKaBWTBJorzLvlLKVG0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=lrHPe4Iy; arc=none smtp.client-ip=209.85.216.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="lrHPe4Iy" Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-3081f72c271so1260012a91.0 for ; Thu, 24 Apr 2025 09:20:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1745511636; x=1746116436; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=k3Iw9xQG/mrFyYZCbOAjR0BlEmMfeP4/b2L1nOaJiVM=; b=lrHPe4IyLQVnfHpCkQcgHZVwjohbgfRkQqoMxdeJvmkHuCH9I60NIxEelw8xvV90RO VtmtnZxUcKHWMJw/yGiCzkrTn9EdXeClaZeoAZVtO7fi5d61RbSn+GXafEwA6y4Ac01S dpaIinBhbU2AvVqLUjzXgB+1DLBkWyU8mamP7ck9i9HfLY3HuU7m20RE9va05Kbl8SJQ hU3b7QUbVDy1EETpugBabfn+tT7/TKUChvWs9TwrZJk0k/QgFrXoOtlNGiA+a1y4G4Tz Ohco33Fh7Nxr4FqDrW4XdpxJi1b9Muq9COC0yPs8MEuW/HYjWTkz09UcrlGtTCWSxCeV R7iQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745511636; x=1746116436; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=k3Iw9xQG/mrFyYZCbOAjR0BlEmMfeP4/b2L1nOaJiVM=; b=UIWsMiOwjcwuGOYCI9vvGcFtXjqQAaU6c1qvGPlp6l1EEOjtWsSkeJyDcB4ijRflgL x7AhAwBIk+AcraSQ6koTT847GLJBSHcApoiyhNrxjoVoTtozDUl/TV/uF6dOVNt8haiN DGX8TfcRQgsqZ8MO5qqgjXVVwe3Luk6yHLdwTGfPXsMvEb/v+XOT8+SQeQg3cEXukSD5 HeFhBTNeKFtSNdaKl1/vWFVvLRxkjnqU+sWJ7Hq67ETh1ln8rceRHWpUL+QUePaiCJoP VnQLNXn7FdTvxOK7eCr07B2eYYvgFvHDULVdqTGMQXo3i5eFJOxP7Yy3+PT6tU4nBkPB CuiQ== X-Gm-Message-State: AOJu0YwaNu5OWaXvB6ezgp46DqeymubS9s+MZ0SMqKTsaPl+BOua4p6x cp8JjnbUp8le0vdvxmz8yWvsina+TFDRSgeGGS9IQWMGP6/PM7iU6bX0bA4quGM= X-Gm-Gg: ASbGnctqsN87Wk0nXVF4uXOfOP+osFBRg8x9gyS8oyPfkygqzOa4D05ECuBnBVTGfLu RgAm4P7IC+XqVsIudw6dvakSlc77+QUBO43J7wYBGY1MYpdm74bdz28PmKa4sYGZ8JkTPlobHYe DMBPHPs4Gud2fWHrWmMc65305QrMiBQnV0WlnvTBPC9OfxX6BnxiedkfzHOWZjJygUpxo96EbFd 7CHfqIetg4iF/1lVLheWwQOFg1GqTurK/iIVvk1sqj8unWCyw3xOL3aTRzcezHOgbgKcbynPKiU 9W4qjPfyR+A1UiSx4k75HwMYYmaZb75lLHagh0kFag== X-Google-Smtp-Source: AGHT+IHGXeYbJl+WVCP6syWgqbdXcskKjaFSK6A+47jDuoLV06ng53DbEMZnSaX1tXXmXEMs6y+aTg== X-Received: by 2002:a17:90a:f94e:b0:2f8:4a3f:dd2d with SMTP id 98e67ed59e1d1-309f554b804mr421908a91.15.1745511635971; Thu, 24 Apr 2025 09:20:35 -0700 (PDT) Received: from localhost ([122.172.83.32]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-309ef060362sm1570181a91.16.2025.04.24.09.20.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Apr 2025 09:20:35 -0700 (PDT) From: Viresh Kumar To: "Rafael J. Wysocki" , Viresh Kumar Cc: linux-pm@vger.kernel.org, Vincent Guittot , Lifeng Zheng , Nicholas Chin , linux-kernel@vger.kernel.org Subject: [PATCH V2 3/5] cpufreq: Introduce policy_set_boost() Date: Thu, 24 Apr 2025 21:50:16 +0530 Message-Id: <1863178ac17340c810519c8593014b8e561797ea.1745511526.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 2.31.1.272.g89b43f80a514 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Introduce policy_set_boost() to update boost state of a cpufreq policy. No intentional function change. Reviewed-by: Lifeng Zheng Signed-off-by: Viresh Kumar --- drivers/cpufreq/cpufreq.c | 49 +++++++++++++++++++++------------------ 1 file changed, 26 insertions(+), 23 deletions(-) diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c index e31891c7b500..24745088403b 100644 --- a/drivers/cpufreq/cpufreq.c +++ b/drivers/cpufreq/cpufreq.c @@ -620,6 +620,22 @@ static ssize_t show_local_boost(struct cpufreq_policy *policy, char *buf) return sysfs_emit(buf, "%d\n", policy->boost_enabled); } +static int policy_set_boost(struct cpufreq_policy *policy, bool enable) +{ + int ret; + + if (policy->boost_enabled == enable) + return 0; + + policy->boost_enabled = enable; + + ret = cpufreq_driver->set_boost(policy, enable); + if (ret) + policy->boost_enabled = !policy->boost_enabled; + + return ret; +} + static ssize_t store_local_boost(struct cpufreq_policy *policy, const char *buf, size_t count) { @@ -635,21 +651,14 @@ static ssize_t store_local_boost(struct cpufreq_policy *policy, if (!policy->boost_supported) return -EINVAL; - if (policy->boost_enabled == enable) - return count; - - policy->boost_enabled = enable; - cpus_read_lock(); - ret = cpufreq_driver->set_boost(policy, enable); + ret = policy_set_boost(policy, enable); cpus_read_unlock(); - if (ret) { - policy->boost_enabled = !policy->boost_enabled; - return ret; - } + if (!ret) + return count; - return count; + return ret; } static struct freq_attr local_boost = __ATTR(boost, 0644, show_local_boost, store_local_boost); @@ -1618,15 +1627,12 @@ static int cpufreq_online(unsigned int cpu) policy->cdev = of_cpufreq_cooling_register(policy); /* Let the per-policy boost flag mirror the cpufreq_driver boost during init */ - if (cpufreq_driver->set_boost && policy->boost_supported && - policy->boost_enabled != cpufreq_boost_enabled()) { - policy->boost_enabled = cpufreq_boost_enabled(); - ret = cpufreq_driver->set_boost(policy, policy->boost_enabled); + if (cpufreq_driver->set_boost && policy->boost_supported) { + ret = policy_set_boost(policy, cpufreq_boost_enabled()); if (ret) { /* If the set_boost fails, the online operation is not affected */ pr_info("%s: CPU%d: Cannot %s BOOST\n", __func__, policy->cpu, - str_enable_disable(policy->boost_enabled)); - policy->boost_enabled = !policy->boost_enabled; + str_enable_disable(cpufreq_boost_enabled())); } } @@ -2861,15 +2867,12 @@ static int cpufreq_boost_trigger_state(int state) cpus_read_lock(); for_each_active_policy(policy) { - if (!policy->boost_supported || policy->boost_enabled == state) + if (!policy->boost_supported) continue; - policy->boost_enabled = state; - ret = cpufreq_driver->set_boost(policy, state); - if (ret) { - policy->boost_enabled = !policy->boost_enabled; + ret = policy_set_boost(policy, state); + if (ret) goto err_reset_state; - } } cpus_read_unlock();