From patchwork Thu Oct 31 18:37:28 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Kucheria X-Patchwork-Id: 178221 Delivered-To: patch@linaro.org Received: by 2002:a92:409a:0:0:0:0:0 with SMTP id d26csp3242515ill; Thu, 31 Oct 2019 11:38:09 -0700 (PDT) X-Google-Smtp-Source: APXvYqxgf4XE47OnW8nqbMNjdwDnew5yL7hzLmS0J/khWB5C71wLbM2waJm8HqZe9/+THAZMGrMj X-Received: by 2002:a17:906:f15:: with SMTP id z21mr5671333eji.119.1572547089774; Thu, 31 Oct 2019 11:38:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572547089; cv=none; d=google.com; s=arc-20160816; b=K6JWmlgovWKRSIk1X8ZX8NY3TJi3JtSguYi9aTo5/ksEfTBX8eTUUdelaquHLuaN1i BvBOpCW01KJ3xu/utWEWNdKK6lY5a6lVw2IpPIDkHZ0MUbLTYMpOLg5fQ1sv+Uk8zAlz TSg+dDaGLzv/QG8iaQ/Gj03oM7iBfbztretGWBfySqg7SNRp1CjWhd4tBXswdXa8uIaB avQfa6WaPFkSrGa4kir9aatvmV8m2+/jKRdS+20WMszILypgrQo/tTOt3ItiL6dTr8iD svXiQTBmRy3bONzjNPBBI8fGKONphgXFCWsJ5KwJUJie0sIN8UO8lecqQLMN9crcYjcp w71g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature; bh=X8pbmbvndxxAH4F0z0Ew7Vd1EABZ+OrJe/0vppnAxes=; b=bgGs+B9Fe43dVgNRVimTTqrgPzh+4C/DQgTKPBBjJKw0Cc6vBManq0K8FaJ6iI+5O2 ZdpFZibX4wPF6qKwfJdg68UfChiHEYyDo7N+6jsjreoMj86jjHQdYLsYHjyppddTZcEd NbICvB1nTO1lEcdqBfFc7M3tii1LRPd6s3zIdCDXdEvcu1/p3Df1yFkV4pjyX4TjHA3n porWxYUXofrNAn0kFA12Y+3tNyyJligf8XHOtXNrthBD/JJ1jX3c5lGh/nvPjRY3jHZC kzqStHVRalKxY/KhNPQRNm0E95jKTi/ZwamrsZX7gEhywouc2BZ9WWCZzI89a917URdR uElQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=CDLBLbFq; spf=pass (google.com: best guess record for domain of linux-pm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-pm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h5si5293264edj.25.2019.10.31.11.38.09; Thu, 31 Oct 2019 11:38:09 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-pm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=CDLBLbFq; spf=pass (google.com: best guess record for domain of linux-pm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-pm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729282AbfJaSiI (ORCPT + 10 others); Thu, 31 Oct 2019 14:38:08 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:33763 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729402AbfJaSiI (ORCPT ); Thu, 31 Oct 2019 14:38:08 -0400 Received: by mail-pg1-f195.google.com with SMTP id u23so4618266pgo.0 for ; Thu, 31 Oct 2019 11:38:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=X8pbmbvndxxAH4F0z0Ew7Vd1EABZ+OrJe/0vppnAxes=; b=CDLBLbFqr/0ON8o38wGiBrEar70y2rg1osFmOTQ1XeqaFGprwtUrGC/X6RsonRkOpu 6o96MexTFegENdKBXGp4gqx8C2uTAE5lamxgKl8BAlXBnKAZP2OZ4WtDWcupX5wzWQTg +evjsN+w1z+KpmKZfJ851YqgziA2Ai5vy8+DNA5XnuXpDDE8643HaBa8ZM2BUXufEKO+ i1iRd/tGS0EU0IYxlMJpWmPSkq8dfIU1L1OM7egeywMKDLzT7fhUsXU/zjk697yKS6lo Colri0UuvK8LPW+OSG9C8WYJvAZzNwuBgi3dkkca1Z7KIYggZqpb1L1ms+XXrLXhgk4c A9Uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=X8pbmbvndxxAH4F0z0Ew7Vd1EABZ+OrJe/0vppnAxes=; b=b9BsaexYmgmvdwC9tGXr0szPl/nA/gLfPEvJhgmRJssLd8HE1RYFZmm8MVmpsw1Ch8 6U+OdHMiYm6iUzq23/w9vJ67qQ8JVMgEbsB4uZ+szqo0/UnyvwNVGpt6JLqh9OK0wEa1 YiIV0zaN34IpTJR3IgHB76DAqWZqEsTaAATZXZuBliBe8KKuT3hzAUOtnhsV6kbfVcFp F4k0dyH9q+0um1nPkDf+FwNoy2niSoXWnwzUVUb8PtLgsg6wcOGAm7WNnQMkcLVdfXin s39ptMkiTcuwXv/LlWwlsWW10w4W8AXxrzgnpadHGeXXzqSzWD5xMvFg274lOsdZLeF+ KyCw== X-Gm-Message-State: APjAAAWr7FMfBid2xzqCIVtzQ5Ve9nWes+aEGm6qX1aB5Vw+05Q8o7EQ W5i2O/tyR1rc8FZZ3UrCw+UCDg== X-Received: by 2002:a63:1b59:: with SMTP id b25mr8347745pgm.267.1572547087268; Thu, 31 Oct 2019 11:38:07 -0700 (PDT) Received: from localhost ([49.248.58.234]) by smtp.gmail.com with ESMTPSA id c12sm4812571pfp.67.2019.10.31.11.38.06 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 31 Oct 2019 11:38:06 -0700 (PDT) From: Amit Kucheria To: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, bjorn.andersson@linaro.org, edubezval@gmail.com, agross@kernel.org, masneyb@onstation.org, swboyd@chromium.org, julia.lawall@lip6.fr, Amit Kucheria , Daniel Lezcano , Mark Rutland , Rob Herring , Zhang Rui Cc: linux-pm@vger.kernel.org Subject: [PATCH v7 04/15] drivers: thermal: tsens: Add debugfs support Date: Fri, 1 Nov 2019 00:07:28 +0530 Message-Id: <16e39c1bbfc18b5cf6274620cd72cc63205f53a5.1572526427.git.amit.kucheria@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Dump some basic version info and sensor details into debugfs. Example from qcs404 below: --(/sys/kernel/debug) $ ls tsens/ 4a9000.thermal-sensor version --(/sys/kernel/debug) $ cat tsens/version 1.4.0 --(/sys/kernel/debug) $ cat tsens/4a9000.thermal-sensor/sensors max: 11 num: 10 id slope offset ------------------------ 0 3200 404000 1 3200 404000 2 3200 404000 3 3200 404000 4 3200 404000 5 3200 404000 6 3200 404000 7 3200 404000 8 3200 404000 9 3200 404000 Signed-off-by: Amit Kucheria Reviewed-by: Stephen Boyd --- drivers/thermal/qcom/tsens-common.c | 83 +++++++++++++++++++++++++++++ drivers/thermal/qcom/tsens.c | 2 + drivers/thermal/qcom/tsens.h | 6 +++ 3 files changed, 91 insertions(+) -- 2.17.1 diff --git a/drivers/thermal/qcom/tsens-common.c b/drivers/thermal/qcom/tsens-common.c index 7437bfe196e5..ea2c46cc6a66 100644 --- a/drivers/thermal/qcom/tsens-common.c +++ b/drivers/thermal/qcom/tsens-common.c @@ -3,6 +3,7 @@ * Copyright (c) 2015, The Linux Foundation. All rights reserved. */ +#include #include #include #include @@ -139,6 +140,77 @@ int get_temp_common(struct tsens_sensor *s, int *temp) return 0; } +#ifdef CONFIG_DEBUG_FS +static int dbg_sensors_show(struct seq_file *s, void *data) +{ + struct platform_device *pdev = s->private; + struct tsens_priv *priv = platform_get_drvdata(pdev); + int i; + + seq_printf(s, "max: %2d\nnum: %2d\n\n", + priv->feat->max_sensors, priv->num_sensors); + + seq_puts(s, " id slope offset\n--------------------------\n"); + for (i = 0; i < priv->num_sensors; i++) { + seq_printf(s, "%8d %8d %8d\n", priv->sensor[i].hw_id, + priv->sensor[i].slope, priv->sensor[i].offset); + } + + return 0; +} + +static int dbg_version_show(struct seq_file *s, void *data) +{ + struct platform_device *pdev = s->private; + struct tsens_priv *priv = platform_get_drvdata(pdev); + u32 maj_ver, min_ver, step_ver; + int ret; + + if (tsens_ver(priv) > VER_0_1) { + ret = regmap_field_read(priv->rf[VER_MAJOR], &maj_ver); + if (ret) + return ret; + ret = regmap_field_read(priv->rf[VER_MINOR], &min_ver); + if (ret) + return ret; + ret = regmap_field_read(priv->rf[VER_STEP], &step_ver); + if (ret) + return ret; + seq_printf(s, "%d.%d.%d\n", maj_ver, min_ver, step_ver); + } else { + seq_puts(s, "0.1.0\n"); + } + + return 0; +} + +DEFINE_SHOW_ATTRIBUTE(dbg_version); +DEFINE_SHOW_ATTRIBUTE(dbg_sensors); + +static void tsens_debug_init(struct platform_device *pdev) +{ + struct tsens_priv *priv = platform_get_drvdata(pdev); + struct dentry *root, *file; + + root = debugfs_lookup("tsens", NULL); + if (!root) + priv->debug_root = debugfs_create_dir("tsens", NULL); + else + priv->debug_root = root; + + file = debugfs_lookup("version", priv->debug_root); + if (!file) + debugfs_create_file("version", 0444, priv->debug_root, + pdev, &dbg_version_fops); + + /* A directory for each instance of the TSENS IP */ + priv->debug = debugfs_create_dir(dev_name(&pdev->dev), priv->debug_root); + debugfs_create_file("sensors", 0444, priv->debug, pdev, &dbg_sensors_fops); +} +#else +static inline void tsens_debug_init(struct platform_device *pdev) {} +#endif + static const struct regmap_config tsens_config = { .name = "tm", .reg_bits = 32, @@ -199,6 +271,15 @@ int __init init_common(struct tsens_priv *priv) goto err_put_device; } + if (tsens_ver(priv) > VER_0_1) { + for (i = VER_MAJOR; i <= VER_STEP; i++) { + priv->rf[i] = devm_regmap_field_alloc(dev, priv->srot_map, + priv->fields[i]); + if (IS_ERR(priv->rf[i])) + return PTR_ERR(priv->rf[i]); + } + } + priv->rf[TSENS_EN] = devm_regmap_field_alloc(dev, priv->srot_map, priv->fields[TSENS_EN]); if (IS_ERR(priv->rf[TSENS_EN])) { @@ -238,6 +319,8 @@ int __init init_common(struct tsens_priv *priv) } } + tsens_debug_init(op); + return 0; err_put_device: diff --git a/drivers/thermal/qcom/tsens.c b/drivers/thermal/qcom/tsens.c index 06c6bbd69a1a..772aa76b50e1 100644 --- a/drivers/thermal/qcom/tsens.c +++ b/drivers/thermal/qcom/tsens.c @@ -3,6 +3,7 @@ * Copyright (c) 2015, The Linux Foundation. All rights reserved. */ +#include #include #include #include @@ -176,6 +177,7 @@ static int tsens_remove(struct platform_device *pdev) { struct tsens_priv *priv = platform_get_drvdata(pdev); + debugfs_remove_recursive(priv->debug_root); if (priv->ops->disable) priv->ops->disable(priv); diff --git a/drivers/thermal/qcom/tsens.h b/drivers/thermal/qcom/tsens.h index 84e5447c5686..00899c17e848 100644 --- a/drivers/thermal/qcom/tsens.h +++ b/drivers/thermal/qcom/tsens.h @@ -293,6 +293,8 @@ struct tsens_context { * @feat: features of the IP * @fields: bitfield locations * @ops: pointer to list of callbacks supported by this device + * @debug_root: pointer to debugfs dentry for all tsens + * @debug: pointer to debugfs dentry for tsens controller * @sensor: list of sensors attached to this device */ struct tsens_priv { @@ -306,6 +308,10 @@ struct tsens_priv { const struct tsens_features *feat; const struct reg_field *fields; const struct tsens_ops *ops; + + struct dentry *debug_root; + struct dentry *debug; + struct tsens_sensor sensor[0]; };