From patchwork Thu Aug 4 23:04:51 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lina Iyer X-Patchwork-Id: 73326 Delivered-To: patch@linaro.org Received: by 10.140.29.52 with SMTP id a49csp1636764qga; Thu, 4 Aug 2016 16:05:53 -0700 (PDT) X-Received: by 10.98.152.6 with SMTP id q6mr130492761pfd.86.1470351947138; Thu, 04 Aug 2016 16:05:47 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id vs3si16869248pab.2.2016.08.04.16.05.46; Thu, 04 Aug 2016 16:05:47 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-pm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-pm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-pm-owner@vger.kernel.org; dmarc=fail (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759366AbcHDXFp (ORCPT + 14 others); Thu, 4 Aug 2016 19:05:45 -0400 Received: from mail-pf0-f175.google.com ([209.85.192.175]:33451 "EHLO mail-pf0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759140AbcHDXFo (ORCPT ); Thu, 4 Aug 2016 19:05:44 -0400 Received: by mail-pf0-f175.google.com with SMTP id y134so90786122pfg.0 for ; Thu, 04 Aug 2016 16:05:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ooWHYypMDqHa9pNerZsPHrKt0ajIHCApjEjh0Bdi8bA=; b=eRaTmg3Un5gHHHSITC4XSx6V61ED4oF6ZUHbVM47YKdMCeXBPwWWvKldwqAcfJ0uWF IemfPqHuej2WigWayxEUnxh+vSh6aS4X0fcWiuSc7rLXYlzmESvxI7h1dupL6wCItUl/ GPxAy084fRlhhWqsLE7IBj99SlQXh6WkSsopw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ooWHYypMDqHa9pNerZsPHrKt0ajIHCApjEjh0Bdi8bA=; b=OULXWlv6J5Z4QfoohxC2qvZa9tm/FiPUV6FNNbAPEeetpFN4+3EKw6+QgOwAQa9Jfo uC/DxwiOgS8hWWd0WM5EKieIX5pR5StlgtgrCOp3SSJdZzzCQVMWo4+TKcoaVqducwTl d0nDpXllTJWk+zYha9cK/45+OYNfzhO3vynbGjupAcCFhsHb+a6SKNVe5zg0eOcvoPR4 xIWkeT4zaSje08wbyL6erDBz9NdZfEywxUDiaaJJuUezR8+T10u4YlffIxfVg0UgSOFC rVOtqxctXU8Nq6DbyI/sfyV2qq9MuLlHKt/QMEvBVK5/OOUQOjFp1Ry5HIMCeGwjLReB 0umQ== X-Gm-Message-State: AEkoousW7wma3/i4a86QbT3cldeY3KLXIq7u74u9H2KoxU4avrF8g5nrFfpt+zmDUtM6Mig9 X-Received: by 10.98.68.148 with SMTP id m20mr126909130pfi.0.1470351943288; Thu, 04 Aug 2016 16:05:43 -0700 (PDT) Received: from ubuntu.localdomain (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id x66sm22736214pfb.86.2016.08.04.16.05.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 04 Aug 2016 16:05:41 -0700 (PDT) From: Lina Iyer To: ulf.hansson@linaro.org, khilman@kernel.org, rjw@rjwysocki.net, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: andy.gross@linaro.org, sboyd@codeaurora.org, linux-arm-msm@vger.kernel.org, Lina Iyer , Kevin Hilman , Geert Uytterhoeven , =?UTF-8?q?Krzysztof=20Koz=C5=82owski?= Subject: [PATCH v3 04/15] PM / Domains: Support IRQ safe PM domains Date: Thu, 4 Aug 2016 17:04:51 -0600 Message-Id: <1470351902-43103-5-git-send-email-lina.iyer@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1470351902-43103-1-git-send-email-lina.iyer@linaro.org> References: <1470351902-43103-1-git-send-email-lina.iyer@linaro.org> MIME-Version: 1.0 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Generic Power Domains currently support turning on/off only in process context. This prevents the usage of PM domains for domains that could be powered on/off in a context where IRQs are disabled. Many such domains exist today and do not get powered off, when the IRQ safe devices in that domain are powered off, because of this limitation. However, not all domains can operate in IRQ safe contexts. Genpd therefore, has to support both cases where the domain may or may not operate in IRQ safe contexts. Configuring genpd to use an appropriate lock for that domain, would allow domains that have IRQ safe devices to runtime suspend and resume, in atomic context. To achieve domain specific locking, set the domain's ->flag to GENPD_FLAG_IRQ_SAFE while defining the domain. This indicates that genpd should use a spinlock instead of a mutex for locking the domain. Locking is abstracted through genpd_lock() and genpd_unlock() functions that use the flag to determine the appropriate lock to be used for that domain. Domains that have lower latency to suspend and resume and can operate with IRQs disabled may now be able to save power, when the component devices and sub-domains are idle at runtime. The restriction this imposes on the domain hierarchy is that non-IRQ safe domains may not have IRQ-safe subdomains, but IRQ safe domains may have IRQ safe and non-IRQ safe subdomains and devices. Cc: Ulf Hansson Cc: Kevin Hilman Cc: Rafael J. Wysocki Cc: Geert Uytterhoeven Cc: Krzysztof Kozłowski Signed-off-by: Lina Iyer [Ulf: Rebased and solved a conflict] Signed-off-by: Ulf Hansson --- drivers/base/power/domain.c | 107 +++++++++++++++++++++++++++++++++++++++----- include/linux/pm_domain.h | 10 ++++- 2 files changed, 106 insertions(+), 11 deletions(-) -- 2.7.4 -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c index ce1dbfdd..4fc5688 100644 --- a/drivers/base/power/domain.c +++ b/drivers/base/power/domain.c @@ -74,11 +74,61 @@ static const struct genpd_lock_fns genpd_mtx_fns = { .unlock = genpd_unlock_mtx, }; +static void genpd_lock_spin(struct generic_pm_domain *genpd) + __acquires(&genpd->slock) +{ + unsigned long flags; + + spin_lock_irqsave(&genpd->slock, flags); + genpd->lock_flags = flags; +} + +static void genpd_lock_nested_spin(struct generic_pm_domain *genpd, + int depth) + __acquires(&genpd->slock) +{ + unsigned long flags; + + spin_lock_irqsave_nested(&genpd->slock, flags, depth); + genpd->lock_flags = flags; +} + +static int genpd_lock_interruptible_spin(struct generic_pm_domain *genpd) + __acquires(&genpd->slock) +{ + unsigned long flags; + + spin_lock_irqsave(&genpd->slock, flags); + genpd->lock_flags = flags; + return 0; +} + +static void genpd_unlock_spin(struct generic_pm_domain *genpd) + __releases(&genpd->slock) +{ + spin_unlock_irqrestore(&genpd->slock, genpd->lock_flags); +} + +static const struct genpd_lock_fns genpd_spin_fns = { + .lock = genpd_lock_spin, + .lock_nested = genpd_lock_nested_spin, + .lock_interruptible = genpd_lock_interruptible_spin, + .unlock = genpd_unlock_spin, +}; + #define genpd_lock(p) p->lock_fns->lock(p) #define genpd_lock_nested(p, d) p->lock_fns->lock_nested(p, d) #define genpd_lock_interruptible(p) p->lock_fns->lock_interruptible(p) #define genpd_unlock(p) p->lock_fns->unlock(p) +#define genpd_is_irq_safe(genpd) (genpd->flags & GENPD_FLAG_IRQ_SAFE) + +static inline bool irq_safe_dev_in_no_sleep_domain(struct device *dev, + struct generic_pm_domain *genpd) +{ + return pm_runtime_is_irq_safe(dev) && !genpd_is_irq_safe(genpd); +} + /* * Get the generic PM domain for a particular struct device. * This validates the struct device pointer, the PM domain pointer, @@ -343,7 +393,12 @@ static int genpd_poweroff(struct generic_pm_domain *genpd, bool is_async) if (stat > PM_QOS_FLAGS_NONE) return -EBUSY; - if (!pm_runtime_suspended(pdd->dev) || pdd->dev->power.irq_safe) + /* + * Do not allow PM domain to be powered off, when an IRQ safe + * device is part of a non-IRQ safe domain. + */ + if (!pm_runtime_suspended(pdd->dev) || + irq_safe_dev_in_no_sleep_domain(pdd->dev, genpd)) not_suspended++; } @@ -506,10 +561,10 @@ static int genpd_runtime_suspend(struct device *dev) } /* - * If power.irq_safe is set, this routine will be run with interrupts - * off, so it can't use mutexes. + * If power.irq_safe is set, this routine may be run with + * IRQs disabled, so suspend only if the PM domain also is irq_safe. */ - if (dev->power.irq_safe) + if (irq_safe_dev_in_no_sleep_domain(dev, genpd)) return 0; genpd_lock(genpd); @@ -543,8 +598,11 @@ static int genpd_runtime_resume(struct device *dev) if (IS_ERR(genpd)) return -EINVAL; - /* If power.irq_safe, the PM domain is never powered off. */ - if (dev->power.irq_safe) { + /* + * As we don't power off a non IRQ safe domain, which holds + * an IRQ safe device, we don't need to restore power to it. + */ + if (irq_safe_dev_in_no_sleep_domain(dev, genpd)) { timed = false; goto out; } @@ -586,7 +644,8 @@ static int genpd_runtime_resume(struct device *dev) err_stop: genpd_stop_dev(genpd, dev); err_poweroff: - if (!dev->power.irq_safe) { + if (!dev->power.irq_safe || + (dev->power.irq_safe && genpd_is_irq_safe(genpd))) { genpd_lock(genpd); genpd_poweroff(genpd, 0); genpd_unlock(genpd); @@ -1117,6 +1176,11 @@ int __pm_genpd_add_device(struct generic_pm_domain *genpd, struct device *dev, if (IS_ERR(gpd_data)) return PTR_ERR(gpd_data); + /* Check if we are adding an IRQ safe device to non-IRQ safe domain */ + if (irq_safe_dev_in_no_sleep_domain(dev, genpd)) + dev_warn_once(dev, "PM domain %s will not be powered off\n", + genpd->name); + genpd_lock(genpd); if (genpd->prepared_count > 0) { @@ -1211,6 +1275,17 @@ int pm_genpd_add_subdomain(struct generic_pm_domain *genpd, || genpd == subdomain) return -EINVAL; + /* + * If the domain can be powered on/off in an IRQ safe + * context, ensure that the subdomain can also be + * powered on/off in that context. + */ + if (!genpd_is_irq_safe(genpd) && genpd_is_irq_safe(subdomain)) { + WARN("Parent %s of subdomain %s must be IRQ safe\n", + genpd->name, subdomain->name); + return -EINVAL; + } + link = kzalloc(sizeof(*link), GFP_KERNEL); if (!link) return -ENOMEM; @@ -1377,6 +1452,17 @@ static int genpd_of_parse(struct generic_pm_domain *genpd) return pm_genpd_of_parse_power_states(genpd); } +static void genpd_lock_init(struct generic_pm_domain *genpd) +{ + if (genpd->flags & GENPD_FLAG_IRQ_SAFE) { + spin_lock_init(&genpd->slock); + genpd->lock_fns = &genpd_spin_fns; + } else { + mutex_init(&genpd->mlock); + genpd->lock_fns = &genpd_mtx_fns; + } +} + /** * pm_genpd_init - Initialize a generic I/O PM domain object. * @genpd: PM domain object to initialize. @@ -1396,8 +1482,7 @@ int pm_genpd_init(struct generic_pm_domain *genpd, INIT_LIST_HEAD(&genpd->master_links); INIT_LIST_HEAD(&genpd->slave_links); INIT_LIST_HEAD(&genpd->dev_list); - mutex_init(&genpd->mlock); - genpd->lock_fns = &genpd_mtx_fns; + genpd_lock_init(genpd); genpd->gov = gov; INIT_WORK(&genpd->power_off_work, genpd_power_off_work_fn); atomic_set(&genpd->sd_count, 0); @@ -1841,7 +1926,9 @@ static int pm_genpd_summary_one(struct seq_file *s, } list_for_each_entry(pm_data, &genpd->dev_list, list_node) { - kobj_path = kobject_get_path(&pm_data->dev->kobj, GFP_KERNEL); + kobj_path = kobject_get_path(&pm_data->dev->kobj, + genpd_is_irq_safe(genpd) ? + GFP_ATOMIC : GFP_KERNEL); if (kobj_path == NULL) continue; diff --git a/include/linux/pm_domain.h b/include/linux/pm_domain.h index d37bf11..688dc57 100644 --- a/include/linux/pm_domain.h +++ b/include/linux/pm_domain.h @@ -15,9 +15,11 @@ #include #include #include +#include /* Defines used for the flags field in the struct generic_pm_domain */ #define GENPD_FLAG_PM_CLK (1U << 0) /* PM domain uses PM clk */ +#define GENPD_FLAG_IRQ_SAFE (1U << 1) /* PM domain operates in atomic */ #define GENPD_MAX_NUM_STATES 8 /* Number of possible low power states */ @@ -77,7 +79,13 @@ struct generic_pm_domain { unsigned int state_count; /* number of states */ unsigned int state_idx; /* state that genpd will go to when off */ const struct genpd_lock_fns *lock_fns; - struct mutex mlock; + union { + struct mutex mlock; + struct { + spinlock_t slock; + unsigned long lock_flags; + }; + }; };