From patchwork Mon May 30 09:33:11 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ulf Hansson X-Patchwork-Id: 68830 Delivered-To: patches@linaro.org Received: by 10.140.92.199 with SMTP id b65csp1308773qge; Mon, 30 May 2016 02:33:25 -0700 (PDT) X-Received: by 10.25.43.85 with SMTP id r82mr8587747lfr.63.1464600805037; Mon, 30 May 2016 02:33:25 -0700 (PDT) Return-Path: Received: from mail-lf0-x236.google.com (mail-lf0-x236.google.com. [2a00:1450:4010:c07::236]) by mx.google.com with ESMTPS id e5si22109344lbc.164.2016.05.30.02.33.24 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 30 May 2016 02:33:25 -0700 (PDT) Received-SPF: pass (google.com: domain of ulf.hansson@linaro.org designates 2a00:1450:4010:c07::236 as permitted sender) client-ip=2a00:1450:4010:c07::236; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: domain of ulf.hansson@linaro.org designates 2a00:1450:4010:c07::236 as permitted sender) smtp.mailfrom=ulf.hansson@linaro.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: by mail-lf0-x236.google.com with SMTP id b73so47339034lfb.3 for ; Mon, 30 May 2016 02:33:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=f/5rtxPj88e4itPpEZIG4OldDHfpvCl+RQ6sxmyzZWY=; b=SDQP5QqLgwTs8rSoowHJkCbVtgDbHYurra0LOI3JUiviwI1z2E46/C6fTvKmFkrcEt RhkJM+3C++mj8hz+aTuQLW+Nl3W5esgKm+fgYYcfNdx0bxzpTxQJAyoNM+be0fj4LVus 3QX0uKFM+Ll4QuuNOfWr/aGtR6l/N1yn3cxG0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=f/5rtxPj88e4itPpEZIG4OldDHfpvCl+RQ6sxmyzZWY=; b=Zsc2snTBHoSVJvQ2np6KobD+O+PTJIiakiZQlYY2eXhXLFtkIVvPr+yRELLA8QoxQ/ 4SlnY+EdIXiLeWIcVBeul4WsN3c/gK+UHKKDnn7JQC+WpJIEzfNPpUzT5sD2cGMJl+Jj kv9GkeIOIATpxtYZVoJPfQijFDOdwMb3TOd6Ni+XbKTOSV816jf8dBOxpL+6NSnMpZO8 JIGkvwhTZpYKgrz1JwH0ARS2Tx6jEihK4V8Aj/30DUXU1SLMK7cH2fiBExg2ImFqQeuw CVIUrYQ67xh5Mx2aiZz7l2MhtHd2bxQJdEQbE7YYbkiGDN+j9+2dBWeMpBCvehsXsSgl ETxg== X-Gm-Message-State: ALyK8tJ3aXKJQD/wnfKaxdkuxd6kZ+f3qUoN3e+w8WNyOUHY9rMNbrBbCUKaQMsXBgGv4+6RiBs= X-Received: by 10.25.24.65 with SMTP id o62mr6980987lfi.23.1464600804686; Mon, 30 May 2016 02:33:24 -0700 (PDT) Return-Path: Received: from uffe-Latitude-E6430s.ideon.se ([85.235.10.227]) by smtp.gmail.com with ESMTPSA id 75sm4596853lfw.25.2016.05.30.02.33.22 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 30 May 2016 02:33:23 -0700 (PDT) From: Ulf Hansson To: "Rafael J. Wysocki" , Kevin Hilman , Ulf Hansson , linux-pm@vger.kernel.org Cc: Len Brown , Pavel Machek , Geert Uytterhoeven , Lina Iyer , Axel Haslam , Marek Szyprowski , Jon Hunter , Andy Gross , Laurent Pinchart Subject: [PATCH v2 1/5] PM / Domains: Remove redundant call to pm_request_idle() in genpd Date: Mon, 30 May 2016 11:33:11 +0200 Message-Id: <1464600795-26307-2-git-send-email-ulf.hansson@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1464600795-26307-1-git-send-email-ulf.hansson@linaro.org> References: <1464600795-26307-1-git-send-email-ulf.hansson@linaro.org> The PM core increases the runtime PM usage count at the system PM prepare phase. Later when the system resumes, it does a pm_runtime_put() in the complete phase, which in addition to decrementing the usage count, does the equivalent of a pm_request_idle(). Therefore the call to pm_request_idle() from within genpd's ->complete() callback is redundant, so let's remove it. Signed-off-by: Ulf Hansson --- Changes in v2: - Updated changelog. --- drivers/base/power/domain.c | 1 - 1 file changed, 1 deletion(-) -- 1.9.1 diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c index 658eb1b..60a9971 100644 --- a/drivers/base/power/domain.c +++ b/drivers/base/power/domain.c @@ -938,7 +938,6 @@ static void pm_genpd_complete(struct device *dev) pm_generic_complete(dev); pm_runtime_set_active(dev); pm_runtime_enable(dev); - pm_request_idle(dev); } /**