From patchwork Mon Apr 21 07:22:07 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 883483 Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CCA971BCA0E for ; Mon, 21 Apr 2025 07:22:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745220167; cv=none; b=jgVHgcEdK1AyXykXPa7DBB9hGN7zCZOJT8Q4B/dhX6nGfwuVvNtu6m4us78sbUi2RdHLY0NbS79JgFZ+U8naekymxQzJgMQESYLE57+i5HkpzCHL1jmpWAbkv6SVZOVCnxPMa5qVXKAnq3cwpJMUw9jzq/VcgHZDFEk9nzVAcuY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745220167; c=relaxed/simple; bh=u130Nqv9yQVBBp5u5MXJKkv1c28steTVKMoPZ9gakPw=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=WVzoGZnIFsrfl3llBULNA59w1BOCHGjuBxPdjUCLy2NgEpeEdIIcWQdgZa+pibPOzdinkEPOWeTSJdCCZj+QfxycpHfCniJmRzPlGxEPZWWtaq+BheKVrzkWovpppfWE4dSEhTsBFxp1xVXdDZnUmGIPazv7ThgD1jdfnyyjdIY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=melGF3KR; arc=none smtp.client-ip=209.85.215.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="melGF3KR" Received: by mail-pg1-f180.google.com with SMTP id 41be03b00d2f7-af9925bbeb7so2434577a12.3 for ; Mon, 21 Apr 2025 00:22:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1745220164; x=1745824964; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=WLpgHNLudPUMEs+eRk9LcU0/SR8wkW/EVthqJwNyIs0=; b=melGF3KRtmeff3KFjJYxdkAs3hLpNgnIlUOa/a5muTspP7qG5n8ZNoLuoXLzVzB4SF CFFpm90kaLkqvJz5a2W3Ea9gbtZ9OclLvBgOQ67CMEHFNu8G+Qzi8nUKQ86+SISEMBtH Zeii7K/gmr0mnvfSozwTGfUI6EqmxZoDLnWA6pdzprG2BPaXhiUyoAM1j8BfIhncql0e 9wJmIhcvp/Or7Qc4GoiFw8dSjkcFuWwADZ7dHDTVwlDWIso4HQmf2ks9sgOlmE8pQXEX 5aFF9nFdZuKt3gSOKbccylUDAScwoFo9Sj3/CluEpdFVGi7+ySWz+4ouCB/yZnSYVR70 K5bA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745220164; x=1745824964; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WLpgHNLudPUMEs+eRk9LcU0/SR8wkW/EVthqJwNyIs0=; b=vIcUU6NsdcNs+41ccJZO6+tAQ10BNmC6lFtt4BbL1kSDk6R0CnoeMM3fpznXcWrJV6 Vf2Z0aSfqpbDzThE9HfZZR5LV2/v+sIPQ0zUjQD+dbnHTcK4rzYA0owhoafc+3gRcpRE OO6k6HIZCeYT8Cu5/CGnJXRhunRkaTuL/8mG2NixHhjaYwsdt8YPJdsUJrYISNDfa5/R KPwcgTyRTaYJ9+LnpWJJ3MxzKcHiMLL/z8lkGyJGTEWQRmfIxdMks8kqQKwwIvraPGnE V9HO/11J7VvhLE0zEOFXMlw2IbuoHaccyAkEGI1tT2MWqV5jguUZ5Q2/6mJb6IbYaK6W eyQw== X-Gm-Message-State: AOJu0YyaCJF2DVsHhAX69UMiIMQF1x59b+J1fVyHz0FeWaDqPSD7M1E3 lJGU7S4A5d4IlSF+3HdQtyyu4EUf9OQw8OP4uEerbVlKA9a0q1CorceDkZ3mOTE= X-Gm-Gg: ASbGncu+hXBPIwZSPR5GSlDRFeDRtVWBqCmTN9W40ZlAmqqDk1SCeKCbjBOpcue1jCM plOQSk93UDgDjdmWgcY8UGagVdZN+pEy1i4z9c8Yo7nl6jqfabGOrrFt63RSL0vXClkfsZ5dV6u PnmwLRHQuoj+CggH5X+VvmgXhqUT76b+zCwHT/LvQdNbWIIxa+WvhtqnrSRXuVB/opp9iQfwOAH QOFCimIvg2obo4iGy+yA9NZt8v+P880W6npelPOV3lB+0zKuJipcg1PNubNaU8ybhbObtPjg1vz aYXpx1sqQnYCvtauE4x6B+z5p/69TlY6ikHLu1G8XQ== X-Google-Smtp-Source: AGHT+IGPuH/7u2VS6G97KWEqeHwz+7VAvOISPOAykdnAUstUup7zRyEZdl7Ea2PFTSecYm5rR1QE5A== X-Received: by 2002:a05:6a20:3953:b0:1ee:dd60:194f with SMTP id adf61e73a8af0-203cbd17c21mr13816651637.26.1745220164031; Mon, 21 Apr 2025 00:22:44 -0700 (PDT) Received: from localhost ([122.172.83.32]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b0db157c739sm5083625a12.74.2025.04.21.00.22.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Apr 2025 00:22:43 -0700 (PDT) From: Viresh Kumar To: "Rafael J. Wysocki" , Miguel Ojeda , Danilo Krummrich , Alex Gaynor , Alice Ryhl , Andreas Hindborg , Benno Lossin , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Boqun Feng , Danilo Krummrich , Gary Guo , Michael Turquette , Miguel Ojeda , Nishanth Menon , Peter Zijlstra , Stephen Boyd , Thomas Gleixner , Trevor Gross , Viresh Kumar , Viresh Kumar , Yury Norov Cc: linux-pm@vger.kernel.org, Vincent Guittot , rust-for-linux@vger.kernel.org, Manos Pitsidianakis , =?utf-8?q?Alex_Benn?= =?utf-8?q?=C3=A9e?= , Joakim Bech , Rob Herring , Burak Emir , Rasmus Villemoes , Russell King , linux-clk@vger.kernel.org, Anisse Astier , Daniel Almeida , linux-kernel@vger.kernel.org Subject: [PATCH V11 00/15] Rust abstractions for clk, cpumask, cpufreq, OPP Date: Mon, 21 Apr 2025 12:52:07 +0530 Message-Id: X-Mailer: git-send-email 2.31.1.272.g89b43f80a514 Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Hello, This series introduces initial Rust abstractions for a few subsystems: clk, cpumask, cpufreq and Operating Performance Points (OPP). The abstractions cover most of the interfaces exposed by cpufreq and OPP subsystems. It also includes minimal abstractions for the clk and cpumask frameworks, which are required by the cpufreq / OPP abstractions. Additionally, a sample `rcpufreq-dt` driver is included. This is a duplicate of the existing `cpufreq-dt` driver, which is a platform-agnostic, device-tree based cpufreq driver commonly used on ARM platforms. The implementation has been tested using QEMU, ensuring that frequency transitions, various configurations, and driver binding/unbinding work as expected. However, performance measurements have not been conducted yet. For those interested in testing these patches, they can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/vireshk/pm.git rust/cpufreq-dt Based on 6.15-rc1. V10->V11: - cpufreq: Add TableIndex and make table methods safe. - opp: Add freq module to keep all cfg stuff together. - Use /// instead of // for documentation comments, even for private definitions. - Switch back to heap allocation for `struct cpufreq_driver` as it needs to be a mutable object. - Remove allow(dead_code) - Improve few safety comments. - Danilo: I haven't added your RBY tag to patch 13/15 as there were significant changes from the initial version. V9->V10: - Don't remove atomic cpumask bindings from rust/helpers/cpumask.c - Rename from_raw/from_raw_mut to as_ref/as_mut_ref (cpumask). - Improved comments for non-atomic methods (cpumask). - s/new/new_zero/ and s/new_uninit/new/ (cpumask). - Avoid using explicit casts `as *const` or `as *mut`. - Renamed `cpumask_box` to `cpumask_var` and `cpus`. - Add local types in Rust for cpufreq flags that use BIT(). - Add const initializer for cpufreq::Registration and simplify new(). - Improved few safety comments. V8->V9: - clk (changes since V4): - V4: https://lore.kernel.org/all/cover.1742276963.git.viresh.kumar@linaro.org/ - Add more methods in Hertz (as_khz/mhz/ghz). - Reword a comment. - cpumask (changes since V4): - V4: https://lore.kernel.org/all/cover.1743572195.git.viresh.kumar@linaro.org/ - Add support for cpumask_{test_cpu|empty|full} and switch to using non-atomic helpers for set/clear. - s/CpumaskBox/CpumaskVar/ - s/set_all/setall/ - Improved examples, comments and commit logs. - cpufreq/opp: - V8: https://lore.kernel.org/all/cover.1738832118.git.viresh.kumar@linaro.org/ - Based on review comments received for clk/cpumask, a lot of changes were made to cpufreq/opp bindings in code, comments, examples, etc.. - `attr` fields were dropped from cpufreq support, not required anymore because of latest changes in cpufreq core. - Use Hertz/MicroVolt/MicroWatt as units. - Lots of other cleanups. - Dropped Reviewed-by from Manos (there were too many changes). V7->V8: - Updated cpumask bindings to work with !CONFIG_CPUMASK_OFFSTACK case. - Dropped few patches (property_present() and opp helpers), as they are already merged. - from_cpu() is marked unsafe. - Included a patch by Anisse Astier, to solve a long standing issue with this series. - Dropped: "DO-NOT_MERGE: cpufreq: Rename cpufreq-dt platdev." - Updated MAINTAINERS for new files. - Other minor changes / cleanups. V6->V7: - from_cpu() is moved to cpu.rs and doesn't return ARef anymore, but just a reference. - Dropped cpufreq_table_len() and related validation in cpufreq core. - Solved the issue with BIT() macro differently, using an enum now. - Few patches are broken into smaller / independent patches. - Improved Commit logs and SAFETY comments at few places. - Removed print message from cpufreq driver. - Rebased over linux-next/master. - Few other minor changes. V5->V6: - Rebase over latest rust/dev branch, which changed few interfaces that the patches were using. - Included all other patches, which weren't included until now to focus only on core APIs. - Other minor cleanups, additions. V4->V5: - Rename Registration::register() as new(). - Provide a new API: Registration::new_foreign_owned() and use it for rcpufreq_dt driver. - Update MAINTAINERS file. V3->V4: - Fix bugs with freeing of OPP structure. Dropped the Drop routine and fixed reference counting. - Registration object of the cpufreq core is modified a bit to remove the registered field, and few other cleanups. - Use Devres for instead of platform data. - Improve SAFETY comments. V2->V3: - Rebased on latest rust-device changes, which removed `Data` and so few changes were required to make it work. - use srctree links (Alice Ryhl). - Various changes the OPP creation APIs, new APIs: from_raw_opp() and from_raw_opp_owned() (Alice Ryhl). - Inline as_raw() helpers (Alice Ryhl). - Add new interface (`OPP::Token`) for dynamically created OPPs. - Add Reviewed-by tag from Manos. - Modified/simplified cpufreq registration structure / method a bit. V1->V2: - Create and use separate bindings for OF, clk, cpumask, etc (not included in this patchset but pushed to the above branch). This helped removing direct calls from the driver. - Fix wrong usage of Pinning + Vec. - Use Token for OPP Config. - Use Opaque, transparent and Aref for few structures. - Broken down into smaller patches to make it easy for reviewers. - Based over staging/rust-device. --- Viresh Anisse Astier (1): rust: macros: enable use of hyphens in module names Viresh Kumar (14): rust: cpumask: Add few more helpers rust: cpumask: Add initial abstractions MAINTAINERS: Add entry for Rust cpumask API rust: clk: Add helpers for Rust code rust: clk: Add initial abstractions rust: cpu: Add from_cpu() rust: opp: Add initial abstractions for OPP framework rust: opp: Add abstractions for the OPP table rust: opp: Add abstractions for the configuration options rust: cpufreq: Add initial abstractions for cpufreq framework rust: cpufreq: Extend abstractions for policy and driver ops rust: cpufreq: Extend abstractions for driver registration rust: opp: Extend OPP abstractions with cpufreq support cpufreq: Add Rust-based cpufreq-dt driver MAINTAINERS | 11 + drivers/cpufreq/Kconfig | 12 + drivers/cpufreq/Makefile | 1 + drivers/cpufreq/rcpufreq_dt.rs | 229 ++++++ rust/bindings/bindings_helper.h | 4 + rust/helpers/clk.c | 66 ++ rust/helpers/cpufreq.c | 10 + rust/helpers/cpumask.c | 25 + rust/helpers/helpers.c | 2 + rust/kernel/clk.rs | 318 ++++++++ rust/kernel/cpu.rs | 30 + rust/kernel/cpufreq.rs | 1305 +++++++++++++++++++++++++++++++ rust/kernel/cpumask.rs | 330 ++++++++ rust/kernel/lib.rs | 8 + rust/kernel/opp.rs | 1143 +++++++++++++++++++++++++++ rust/macros/module.rs | 20 +- 16 files changed, 3506 insertions(+), 8 deletions(-) create mode 100644 drivers/cpufreq/rcpufreq_dt.rs create mode 100644 rust/helpers/clk.c create mode 100644 rust/helpers/cpufreq.c create mode 100644 rust/kernel/clk.rs create mode 100644 rust/kernel/cpu.rs create mode 100644 rust/kernel/cpufreq.rs create mode 100644 rust/kernel/cpumask.rs create mode 100644 rust/kernel/opp.rs