| Message ID | cover.1718787627.git.perry.yuan@amd.com |
|---|---|
| Headers | show |
| Series | AMD Pstate Driver Core Performance Boost | expand |
On 6/19/2024 04:16, Perry Yuan wrote: > From: Perry Yuan <Perry.Yuan@amd.com> > > With this new sysfs entry `cpb_boost`created, user can change CPU boost > state dynamically under `active`, `guided` and `passive` modes. > And the highest perf and frequency will also be updated as the boost > state changing. s/changing/changes/ > > 0): check current boost state > cat /sys/devices/system/cpu/amd_pstate/cpb_boost > > 1): disable CPU boost > sudo bash -c "echo 0 > /sys/devices/system/cpu/amd_pstate/cpb_boost" > > 2): enable CPU boost > sudo bash -c "echo 1 > /sys/devices/system/cpu/amd_pstate/cpb_boost" > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=217931 > Link: https://bugzilla.kernel.org/show_bug.cgi?id=217618 > Signed-off-by: Perry Yuan <Perry.Yuan@amd.com> > --- > drivers/cpufreq/amd-pstate-ut.c | 2 +- > drivers/cpufreq/amd-pstate.c | 112 +++++++++++++++++++++++++++++++- > drivers/cpufreq/amd-pstate.h | 1 + > 3 files changed, 113 insertions(+), 2 deletions(-) > > diff --git a/drivers/cpufreq/amd-pstate-ut.c b/drivers/cpufreq/amd-pstate-ut.c > index fc275d41d51e..b528f198f4c3 100644 > --- a/drivers/cpufreq/amd-pstate-ut.c > +++ b/drivers/cpufreq/amd-pstate-ut.c > @@ -227,7 +227,7 @@ static void amd_pstate_ut_check_freq(u32 index) > goto skip_test; > } > > - if (cpudata->boost_supported) { > + if (amd_pstate_global_params.cpb_boost) { > if ((policy->max == cpudata->max_freq) || > (policy->max == cpudata->nominal_freq)) > amd_pstate_ut_cases[index].result = AMD_PSTATE_UT_RESULT_PASS; > diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c > index 0c50b8ba16b6..1c2320808ae1 100644 > --- a/drivers/cpufreq/amd-pstate.c > +++ b/drivers/cpufreq/amd-pstate.c > @@ -104,6 +104,7 @@ static bool amd_pstate_prefcore = true; > static struct quirk_entry *quirks; > struct amd_pstate_global_params amd_pstate_global_params; > EXPORT_SYMBOL_GPL(amd_pstate_global_params); > +static int amd_pstate_cpu_boost(int cpu, bool state); > > /* > * AMD Energy Preference Performance (EPP) > @@ -736,6 +737,7 @@ static int amd_pstate_boost_set(struct amd_cpudata *cpudata) > if (amd_pstate_global_params.cpb_supported) { > current_pstate_driver->boost_enabled = true; > WRITE_ONCE(cpudata->boost_supported, true); > + WRITE_ONCE(cpudata->boost_state, true); > } > > amd_pstate_global_params.cpb_boost = amd_pstate_global_params.cpb_supported; > @@ -743,6 +745,7 @@ static int amd_pstate_boost_set(struct amd_cpudata *cpudata) > > exit_err: > WRITE_ONCE(cpudata->boost_supported, false); > + WRITE_ONCE(cpudata->boost_state, false); > current_pstate_driver->boost_enabled = false; > amd_pstate_global_params.cpb_boost = false; > return ret; > @@ -1346,6 +1349,111 @@ static ssize_t prefcore_show(struct device *dev, > return sysfs_emit(buf, "%s\n", str_enabled_disabled(amd_pstate_prefcore)); > } > > +static int amd_pstate_cpu_boost_update(struct cpufreq_policy *policy, bool on) > +{ > + struct amd_cpudata *cpudata = policy->driver_data; > + struct cppc_perf_ctrls perf_ctrls; > + u32 highest_perf, nominal_perf, nominal_freq, max_freq; > + int ret; > + > + highest_perf = READ_ONCE(cpudata->highest_perf); > + nominal_perf = READ_ONCE(cpudata->nominal_perf); > + nominal_freq = READ_ONCE(cpudata->nominal_freq); > + max_freq = READ_ONCE(cpudata->max_freq); > + > + if (boot_cpu_has(X86_FEATURE_CPPC)) { > + u64 value = READ_ONCE(cpudata->cppc_req_cached); > + > + value &= ~GENMASK_ULL(7, 0); > + value |= on ? highest_perf : nominal_perf; > + WRITE_ONCE(cpudata->cppc_req_cached, value); > + > + wrmsrl_on_cpu(cpudata->cpu, MSR_AMD_CPPC_REQ, value); > + } else { > + perf_ctrls.max_perf = on ? highest_perf : nominal_perf; > + ret = cppc_set_epp_perf(cpudata->cpu, &perf_ctrls, 1); > + if (ret) { > + cpufreq_cpu_release(policy); > + pr_debug("failed to set energy perf value (%d)\n", ret); > + return ret; > + } > + } > + > + if (on) > + policy->cpuinfo.max_freq = max_freq; > + else > + policy->cpuinfo.max_freq = nominal_freq * 1000; > + > + policy->max = policy->cpuinfo.max_freq; > + > + if (cppc_state == AMD_PSTATE_PASSIVE) { > + ret = freq_qos_update_request(&cpudata->req[1], policy->cpuinfo.max_freq); > + if (ret < 0) > + pr_debug("Failed to update freq constraint: CPU%d\n", cpudata->cpu); > + } > + > + return ret < 0 ? ret : 0; > +} > + > +static int amd_pstate_cpu_boost(int cpu, bool state) > +{ > + int ret; > + struct cpufreq_policy *policy = cpufreq_cpu_get(cpu); > + struct amd_cpudata *cpudata = policy->driver_data; > + > + if (!policy) { > + pr_err("policy is NULL\n"); > + ret = -ENODATA; > + goto err_exit; > + } > + > + ret = amd_pstate_cpu_boost_update(policy, state); > + refresh_frequency_limits(policy); > + WRITE_ONCE(cpudata->boost_state, state); > + policy->boost_enabled = state; > + > +err_exit: > + cpufreq_cpu_put(policy); > + return ret < 0 ? ret : 0; > +} > + > +static ssize_t cpb_boost_show(struct device *dev, > + struct device_attribute *attr, char *buf) > +{ > + return sysfs_emit(buf, "%u\n", amd_pstate_global_params.cpb_boost); > +} It is incongruent that this returns a 0/1 but prefcore returns enabled/disabled using str_enabled_disabled(). Can we make this consistent and alos use str_enabled_disabled() please? > + > +static ssize_t cpb_boost_store(struct device *dev, struct device_attribute *b, > + const char *buf, size_t count) > +{ > + bool new_state; > + ssize_t ret; > + int cpu; > + > + if (!amd_pstate_global_params.cpb_supported) { > + pr_err("Boost mode is not supported by this processor or SBIOS\n"); > + return -EINVAL; > + } > + > + ret = kstrtobool(buf, &new_state); > + if (ret) > + return ret; > + > + mutex_lock(&amd_pstate_driver_lock); > + for_each_present_cpu(cpu) { > + ret = amd_pstate_cpu_boost(cpu, new_state); > + if (ret < 0) { > + pr_warn("failed to update cpu boost for CPU%d (%zd)\n", cpu, ret); > + goto err_exit; > + } > + } > + amd_pstate_global_params.cpb_boost = !!new_state; > + > +err_exit: > + mutex_unlock(&amd_pstate_driver_lock); > + return ret < 0 ? ret : count; > +} > + > cpufreq_freq_attr_ro(amd_pstate_max_freq); > cpufreq_freq_attr_ro(amd_pstate_lowest_nonlinear_freq); > > @@ -1356,6 +1464,7 @@ cpufreq_freq_attr_rw(energy_performance_preference); > cpufreq_freq_attr_ro(energy_performance_available_preferences); > static DEVICE_ATTR_RW(status); > static DEVICE_ATTR_RO(prefcore); > +static DEVICE_ATTR_RW(cpb_boost); > > static struct freq_attr *amd_pstate_attr[] = { > &amd_pstate_max_freq, > @@ -1380,6 +1489,7 @@ static struct freq_attr *amd_pstate_epp_attr[] = { > static struct attribute *pstate_global_attributes[] = { > &dev_attr_status.attr, > &dev_attr_prefcore.attr, > + &dev_attr_cpb_boost.attr, > NULL > }; > > @@ -1418,7 +1528,7 @@ static int amd_pstate_init_boost(struct cpufreq_policy *policy) > if (ret) > return ret; > > - policy->boost_enabled = READ_ONCE(cpudata->boost_supported); > + policy->boost_enabled = READ_ONCE(cpudata->boost_state); > > return 0; > } > diff --git a/drivers/cpufreq/amd-pstate.h b/drivers/cpufreq/amd-pstate.h > index 133042370a8f..fb240a870289 100644 > --- a/drivers/cpufreq/amd-pstate.h > +++ b/drivers/cpufreq/amd-pstate.h > @@ -100,6 +100,7 @@ struct amd_cpudata { > u64 cppc_cap1_cached; > bool suspended; > s16 epp_default; > + bool boost_state; > }; > > /**
On 6/19/2024 04:16, Perry Yuan wrote: > From: Perry Yuan <Perry.Yuan@amd.com> > > Introduce AMD CPU frequency boosting control sysfs entry which used for > switching boost on and boost off. > > If core performance boost is disabled while a core is in a boosted P-state, > the core automatically transitions to the highest performance non-boosted P-state > The highest perf and frequency will be limited by the setting value. > > Signed-off-by: Perry Yuan <Perry.Yuan@amd.com> > Reviewed-by: Mario Limonciello <mario.limonciello@amd.com> > --- > Documentation/admin-guide/pm/amd-pstate.rst | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/Documentation/admin-guide/pm/amd-pstate.rst b/Documentation/admin-guide/pm/amd-pstate.rst > index 1e0d101b020a..bcc0d9404c18 100644 > --- a/Documentation/admin-guide/pm/amd-pstate.rst > +++ b/Documentation/admin-guide/pm/amd-pstate.rst > @@ -440,6 +440,16 @@ control its functionality at the system level. They are located in the > This attribute is read-only to check the state of preferred core set > by the kernel parameter. > > +``cpb_boost`` > + Specifies whether core performance boost is requested to be enabled or disabled > + If core performance boost is disabled while a core is in a boosted P-state, the > + core automatically transitions to the highest performance non-boosted P-state. > + AMD Core Performance Boost(CPB) is controlled by this attribute file which allows > + user to change all cores frequency boosting state. It supports all amd-pstate modes. > + > + "0" Disable Core Performance Boosting > + "1" Enable Core Performance Boosting > + Please switch to disabled/enabled as suggested in patch 5. > ``cpupower`` tool support for ``amd-pstate`` > =============================================== >
Perry Yuan <perry.yuan@amd.com> writes: > Update the cpufreq store function to use kstrtobool for parsing boolean > values. This simplifies the code and improves readability by using a > standard kernel function for boolean string conversion. > > Signed-off-by: Perry Yuan <perry.yuan@amd.com> > Reviewed-by: Mario Limonciello <mario.limonciello@amd.com> Reviewed-by: Gautham R. Shenoy <gautham.shenoy@amd.com> > --- > drivers/cpufreq/cpufreq.c | 11 +++++------ > 1 file changed, 5 insertions(+), 6 deletions(-) > > diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c > index a45aac17c20f..1fdabb660231 100644 > --- a/drivers/cpufreq/cpufreq.c > +++ b/drivers/cpufreq/cpufreq.c > @@ -614,10 +614,9 @@ static ssize_t show_boost(struct kobject *kobj, > static ssize_t store_boost(struct kobject *kobj, struct kobj_attribute *attr, > const char *buf, size_t count) > { > - int ret, enable; > + bool enable; > > - ret = sscanf(buf, "%d", &enable); > - if (ret != 1 || enable < 0 || enable > 1) > + if (kstrtobool(buf, &enable)) > return -EINVAL; > > if (cpufreq_boost_trigger_state(enable)) { > @@ -641,10 +640,10 @@ static ssize_t show_local_boost(struct cpufreq_policy *policy, char *buf) > static ssize_t store_local_boost(struct cpufreq_policy *policy, > const char *buf, size_t count) > { > - int ret, enable; > + int ret; > + bool enable; > > - ret = kstrtoint(buf, 10, &enable); > - if (ret || enable < 0 || enable > 1) > + if (kstrtobool(buf, &enable)) > return -EINVAL; > > if (!cpufreq_driver->boost_enabled) > -- > 2.34.1
Mario Limonciello <mario.limonciello@amd.com> writes: > On 6/19/2024 04:16, Perry Yuan wrote: >> From: Perry Yuan <Perry.Yuan@amd.com> >> >> With this new sysfs entry `cpb_boost`created, user can change CPU boost >> state dynamically under `active`, `guided` and `passive` modes. >> And the highest perf and frequency will also be updated as the boost >> state changing. > > s/changing/changes/ > >> >> 0): check current boost state >> cat /sys/devices/system/cpu/amd_pstate/cpb_boost >> >> 1): disable CPU boost >> sudo bash -c "echo 0 > /sys/devices/system/cpu/amd_pstate/cpb_boost" >> >> 2): enable CPU boost >> sudo bash -c "echo 1 > /sys/devices/system/cpu/amd_pstate/cpb_boost"
Hi all, This patch series implements the Core Performance Boost (CPB) feature for the AMD pstate driver, including support for passive, guided, and active modes. Users can change the global core frequency boost control with a new sysfs entry: /sys/devices/system/cpu/amd_pstate/cpb_boost It also supports updating the individual CPU boost state in the sysfs boost file: /sys/devices/system/cpu/cpuX/cpufreq/boost By default, the global control will override the individual CPU boost state. 1) disable core boost globally: $ sudo bash -c "echo 0 > /sys/devices/system/cpu/amd_pstate/cpb_boost" $ lscpu -ae CPU NODE SOCKET CORE L1d:L1i:L2:L3 ONLINE MAXMHZ MINMHZ MHZ 0 0 0 0 0:0:0:0 yes 4201.0000 400.0000 2983.578 1 0 0 1 1:1:1:0 yes 4201.0000 400.0000 2983.578 2 0 0 2 2:2:2:0 yes 4201.0000 400.0000 2583.855 3 0 0 3 3:3:3:0 yes 4201.0000 400.0000 2983.578 4 0 0 4 4:4:4:0 yes 4201.0000 400.0000 2983.578 2) enable core boost globally: $ sudo bash -c "echo 1 > /sys/devices/system/cpu/amd_pstate/cpb_boost" $ lscpu -ae 0 0 0 0 0:0:0:0 yes 5759.0000 400.0000 2983.578 1 0 0 1 1:1:1:0 yes 5759.0000 400.0000 2983.578 2 0 0 2 2:2:2:0 yes 5759.0000 400.0000 2983.578 3 0 0 3 3:3:3:0 yes 5759.0000 400.0000 2983.578 4 0 0 4 4:4:4:0 yes 5759.0000 400.0000 2983.578 ============================================================================ The V9 patches add per CPU boost control, user can enable/disable CPUs boost as the below command tested on a laptop system. # before CPU NODE SOCKET CORE L1d:L1i:L2:L3 ONLINE MAXMHZ MINMHZ MHZ 0 0 0 0 0:0:0:0 yes 4208.0000 400.0000 1666.7740 1 0 0 0 0:0:0:0 yes 4208.0000 400.0000 400.0000 2 0 0 1 1:1:1:0 yes 4208.0000 400.0000 3386.1260 3 0 0 1 1:1:1:0 yes 4208.0000 400.0000 400.0000 $ sudo rdmsr 0xc00102b3 -p 0 10a6 $ sudo bash -c "echo 1 > /sys/devices/system/cpu/cpu0/cpufreq/boost" # after CPU NODE SOCKET CORE L1d:L1i:L2:L3 ONLINE MAXMHZ MINMHZ MHZ 0 0 0 0 0:0:0:0 yes 3501.0000 400.0000 400.0000 1 0 0 0 0:0:0:0 yes 4208.0000 400.0000 1391.0690 2 0 0 1 1:1:1:0 yes 4208.0000 400.0000 3654.4541 3 0 0 1 1:1:1:0 yes 4208.0000 400.0000 400.0000 $ sudo rdmsr 0xc00102b3 -p 0 108a rebasd to keep syncing to Mario kernel tree: bleeding-edge https://git.kernel.org/pub/scm/linux/kernel/git/superm1/linux.git Tested result: CPU NODE SOCKET CORE L1d:L1i:L2:L3 ONLINE MAXMHZ MINMHZ MHZ 0 0 0 0 0:0:0:0 yes 4354.0000 400.0000 1110.7140 1 0 0 0 0:0:0:0 yes 4354.0000 400.0000 1110.7140 2 0 0 1 1:1:1:0 yes 4354.0000 400.0000 1110.7140 3 0 0 1 1:1:1:0 yes 4354.0000 400.0000 3110.0000 4 0 0 2 2:2:2:0 yes 4354.0000 400.0000 2732.3569 5 0 0 2 2:2:2:0 yes 4354.0000 400.0000 1110.7140 6 0 0 3 3:3:3:0 yes 4354.0000 400.0000 1110.7140 7 0 0 3 3:3:3:0 yes 4354.0000 400.0000 1110.7140 8 0 0 4 4:4:4:0 yes 4354.0000 400.0000 2312.2109 9 0 0 4 4:4:4:0 yes 4354.0000 400.0000 1110.7140 10 0 0 5 5:5:5:0 yes 4354.0000 400.0000 2310.1011 11 0 0 5 5:5:5:0 yes 4354.0000 400.0000 1110.7140 sudo bash -c "echo 0 > /sys/devices/system/cpu/cpu11/cpufreq/boost" sudo bash -c "echo 0 > /sys/devices/system/cpu/cpu10/cpufreq/boost" sudo bash -c "echo 0 > /sys/devices/system/cpu/cpu9/cpufreq/boost" CPU NODE SOCKET CORE L1d:L1i:L2:L3 ONLINE MAXMHZ MINMHZ MHZ 0 0 0 0 0:0:0:0 yes 4354.0000 400.0000 1242.7240 1 0 0 0 0:0:0:0 yes 4354.0000 400.0000 1110.7140 2 0 0 1 1:1:1:0 yes 4354.0000 400.0000 2754.5710 3 0 0 1 1:1:1:0 yes 4354.0000 400.0000 2659.8159 4 0 0 2 2:2:2:0 yes 4354.0000 400.0000 2308.9929 5 0 0 2 2:2:2:0 yes 4354.0000 400.0000 1110.7140 6 0 0 3 3:3:3:0 yes 4354.0000 400.0000 1110.7140 7 0 0 3 3:3:3:0 yes 4354.0000 400.0000 1110.7140 8 0 0 4 4:4:4:0 yes 4354.0000 400.0000 1110.7140 9 0 0 4 4:4:4:0 yes 2801.0000 400.0000 1110.7140 10 0 0 5 5:5:5:0 yes 2801.0000 400.0000 1110.7140 11 0 0 5 5:5:5:0 yes 2801.0000 400.0000 1110.7140 sudo bash -c "echo 0 > /sys/devices/system/cpu/amd_pstate/cpb_boost" CPU NODE SOCKET CORE L1d:L1i:L2:L3 ONLINE MAXMHZ MINMHZ MHZ 0 0 0 0 0:0:0:0 yes 2801.0000 400.0000 1233.8630 1 0 0 0 0:0:0:0 yes 2801.0000 400.0000 1110.7140 2 0 0 1 1:1:1:0 yes 2801.0000 400.0000 2714.4851 3 0 0 1 1:1:1:0 yes 2801.0000 400.0000 2732.3569 4 0 0 2 2:2:2:0 yes 2801.0000 400.0000 2564.2639 5 0 0 2 2:2:2:0 yes 2801.0000 400.0000 1110.7140 6 0 0 3 3:3:3:0 yes 2801.0000 400.0000 2732.3569 7 0 0 3 3:3:3:0 yes 2801.0000 400.0000 1110.7140 8 0 0 4 4:4:4:0 yes 2801.0000 400.0000 1233.8660 9 0 0 4 4:4:4:0 yes 2801.0000 400.0000 1110.7140 10 0 0 5 5:5:5:0 yes 2801.0000 400.0000 1233.6630 11 0 0 5 5:5:5:0 yes 2801.0000 400.0000 1233.5050 sudo bash -c "echo 1 > /sys/devices/system/cpu/amd_pstate/cpb_boost" CPU NODE SOCKET CORE L1d:L1i:L2:L3 ONLINE MAXMHZ MINMHZ MHZ 0 0 0 0 0:0:0:0 yes 4354.0000 400.0000 1234.0200 1 0 0 0 0:0:0:0 yes 4354.0000 400.0000 1110.7140 2 0 0 1 1:1:1:0 yes 4354.0000 400.0000 1110.7140 3 0 0 1 1:1:1:0 yes 4354.0000 400.0000 1110.7140 4 0 0 2 2:2:2:0 yes 4354.0000 400.0000 1110.7140 5 0 0 2 2:2:2:0 yes 4354.0000 400.0000 1110.7140 6 0 0 3 3:3:3:0 yes 4354.0000 400.0000 2278.8491 7 0 0 3 3:3:3:0 yes 4354.0000 400.0000 2732.3569 8 0 0 4 4:4:4:0 yes 4354.0000 400.0000 1110.7140 9 0 0 4 4:4:4:0 yes 4354.0000 400.0000 1110.7140 10 0 0 5 5:5:5:0 yes 4354.0000 400.0000 2353.0449 11 0 0 5 5:5:5:0 yes 4354.0000 400.0000 1110.7140 Perry. Changes from v11: * add “goto out_free_policy" for error handling and update error mesasge for init_boost in cpufreq.c (Mario) * drop dead code policy check in amd_pstate_cpu_boost_update (Mario) * pick RB flags and Ack flags from Mario * rebased to Mario bleeding edge kerne branch Changes from v10: * rework the boost interface with cpufreq core boost control, align the sysfs file created from cpufreq.c and allow indivial CPU boost control (Mario) * fix the pr_warn code format with %zd (Oleksandr Natalenko) * replace sscanf with kstrtobool for cpufreq.c (new) * drop the boost sysfs file creation from amd pstate patch #6 * add init_boost for cpufreq.c to unify the boost file creation(Mario) * add set_boost callback for EPP driver mode * fix syncronization issue for indivial boost control and global CPB control, now the two control way will keep syncronization after anyone CPU boost state changed. * rebased to Mario kernel tree: bleeding-edge * run testing on local system, no regression issue found so far. Changes from v9: * change per CPU boost sysfs file name to `boost` (Mario) * rebased to latest linux-pm/bleeding-edge Changes from v8: * pick RB flag for patch 4 (Mario) * change boot_cpu_has to cpu_feature_enabled for patch 2 (Boris) * merge patch 6 into patch 3 (Mario) * add two patch for per CPU boost control patch 6 & 7(Mario) * rebased to latest linux-pm/bleeding-edge Changes from v7: * fix the mutext locking issue in the sysfs file update(Ray, Mario) * pick ack flag from Ray * use X86_FEATURE_CPB to verify the CPB function in Patch #2(Ray) * rerun the testing to check function works well * rebased to linux-pm/bleeding-edge latest Changes from v6: * reword patch 2 commit log (Gautham) * update cover letter description(Gautham) * rebase to kernel v6.9-rc5 Changes from v4: * drop the legacy boost remove patch, let us keep the legacy interface in case some applications break. * rebase to linux-pm/bleeding-edge branch * rework the patchset base on [PATCH v8 0/8] AMD Pstate Fixes And Enhancements which has some intial work done there. Changes from v4: * move MSR_K7_HWCR_CPB_DIS_BIT into msr-index.h * pick RB flag from Gautham R. Shenoy * add Cc Oleksandr Natalenko <oleksandr@natalenko.name> * rebase to latest linux-pm/bleeding-edge branch * rebase the patch set on top of [PATCH v7 0/6] AMD Pstate Fixes And Enhancements * update [PATCH v7 2/6] to use MSR_K7_HWCR_CPB_DIS_BIT Changes from v3: * rebased to linux-pm/bleeding-edge v6.8 * rename global to amd_pstate_global_params(Oleksandr Natalenko) * remove comments for boot_supported in amd_pstate.h * fix the compiler warning for amd-pstate-ut.ko * use for_each_online_cpu in cpb_boost_store which fix the null pointer error during testing * fix the max frequency value to be KHz when cpb boost disabled(Gautham R. Shenoy) Changes from v2: * move global struct to amd-pstate.h * fix the amd-pstate-ut with new cpb control interface Changes from v1: * drop suspend/resume fix patch 6/7 because of the fix should be in another fix series instead of CPB feature * move the set_boost remove patch to the last(Mario) * Fix commit info with "Closes:" (Mario) * simplified global.cpb_supported initialization(Mario) * Add guide mode support for CPB control * Fixed some Doc typos and add guide mode info to Doc as well. v1: https://lore.kernel.org/all/cover.1706255676.git.perry.yuan@amd.com/ v2: https://lore.kernel.org/lkml/cover.1707047943.git.perry.yuan@amd.com/ v3: https://lore.kernel.org/lkml/cover.1707297581.git.perry.yuan@amd.com/ v4: https://lore.kernel.org/lkml/cover.1710322310.git.perry.yuan@amd.com/ v5: https://lore.kernel.org/lkml/cover.1710473712.git.perry.yuan@amd.com/ v6: https://lore.kernel.org/lkml/cover.1710754236.git.perry.yuan@amd.com/ v7: https://lore.kernel.org/lkml/cover.1713861200.git.perry.yuan@amd.com/ v8: https://lore.kernel.org/lkml/cover.1714112854.git.perry.yuan@amd.com/ v9: https://lore.kernel.org/lkml/cover.1714989803.git.perry.yuan@amd.com/ v10: https://lore.kernel.org/lkml/cover.1715152592.git.perry.yuan@amd.com/ v11: https://lore.kernel.org/lkml/cover.1718262992.git.perry.yuan@amd.com/ Perry Yuan (9): cpufreq: acpi: move MSR_K7_HWCR_CPB_DIS_BIT into msr-index.h cpufreq: simplify boolean parsing with kstrtobool in store function cpufreq: introduce init_boost callback to initialize boost state for pstate drivers cpufreq: amd-pstate: initialize new core precision boost state cpufreq: amd-pstate: implement cpb_boost sysfs entry for boost control cpufreq: amd-pstate: Add set_boost callback for active mode cpufreq: amd-pstate: fix the MSR highest perf will be reset issue while cpb boost off Documentation: cpufreq: amd-pstate: introduce the new cpu boost control method Documentation: cpufreq: amd-pstate: update doc for Per CPU boost control method Documentation/admin-guide/pm/amd-pstate.rst | 30 +++ arch/x86/include/asm/msr-index.h | 2 + drivers/cpufreq/acpi-cpufreq.c | 2 - drivers/cpufreq/amd-pstate-ut.c | 2 +- drivers/cpufreq/amd-pstate.c | 192 +++++++++++++++++--- drivers/cpufreq/amd-pstate.h | 14 ++ drivers/cpufreq/cpufreq.c | 24 ++- include/linux/cpufreq.h | 2 + 8 files changed, 233 insertions(+), 35 deletions(-)