mbox series

[v1,0/4] ACPI: Get rid of ACPICA message printing from core

Message ID 5138173.kHyPcihzTF@kreacher
Headers show
Series ACPI: Get rid of ACPICA message printing from core | expand

Message

Rafael J. Wysocki Feb. 22, 2021, 6:57 p.m. UTC 
Hi All,

This series replaces ACPI_DEBUG_PRINT() and ACPI_EXCEPTION() in the ACPI
processor driver and sysfs code and drops definitions of related symbols
that are not used for anything meaningful any more.

Please refer to the patch changelogs for details.

Thanks!

Comments

Hanjun Guo Feb. 23, 2021, 11:30 a.m. UTC | #1 
On 2021/2/23 2:59, Rafael J. Wysocki wrote:
> Index: linux-pm/drivers/acpi/processor_idle.c

> ===================================================================

> --- linux-pm.orig/drivers/acpi/processor_idle.c

> +++ linux-pm/drivers/acpi/processor_idle.c


In this file, function acpi_processor_cstate_first_run_checks()
has a wrong pr_notice():

pr_notice("ACPI: processor limited to max C-state %d\n",
		max_cstate);

Since we have pr_fmt() for this file, "ACPI:" is duplicate,
we'd better cleanup this as below:

pr_notice("processor limited to max C-state %d\n", max_cstate);

Thanks
Hanjun
Hanjun Guo Feb. 23, 2021, 11:50 a.m. UTC | #2 
On 2021/2/23 2:57, Rafael J. Wysocki wrote:
> Hi All,
> 
> This series replaces ACPI_DEBUG_PRINT() and ACPI_EXCEPTION() in the ACPI
> processor driver and sysfs code and drops definitions of related symbols
> that are not used for anything meaningful any more.
> 
> Please refer to the patch changelogs for details.

Except patch 1/4, others are looking good to me. some
legacy printk(PRIFIX ...) are still there, but we can
clean up them later.

Feel feel to add my review tag with minor issue addressed.

Reviewed-by: Hanjun Guo <guohanjun@huawei.com>

Thanks
Hanjun
Rafael J. Wysocki Feb. 23, 2021, 2:45 p.m. UTC | #3 
On Tue, Feb 23, 2021 at 12:31 PM Hanjun Guo <guohanjun@huawei.com> wrote:
>
> On 2021/2/23 2:59, Rafael J. Wysocki wrote:
> > Index: linux-pm/drivers/acpi/processor_idle.c
> > ===================================================================
> > --- linux-pm.orig/drivers/acpi/processor_idle.c
> > +++ linux-pm/drivers/acpi/processor_idle.c
>
> In this file, function acpi_processor_cstate_first_run_checks()
> has a wrong pr_notice():
>
> pr_notice("ACPI: processor limited to max C-state %d\n",
>                 max_cstate);
>
> Since we have pr_fmt() for this file, "ACPI:" is duplicate,
> we'd better cleanup this as below:
>
> pr_notice("processor limited to max C-state %d\n", max_cstate);

Thanks for pointing this out, I'll make this change when applying the patch.
Rafael J. Wysocki Feb. 24, 2021, 6:06 p.m. UTC | #4 
On Tue, Feb 23, 2021 at 3:45 PM Rafael J. Wysocki <rafael@kernel.org> wrote:
>
> On Tue, Feb 23, 2021 at 12:31 PM Hanjun Guo <guohanjun@huawei.com> wrote:
> >
> > On 2021/2/23 2:59, Rafael J. Wysocki wrote:
> > > Index: linux-pm/drivers/acpi/processor_idle.c
> > > ===================================================================
> > > --- linux-pm.orig/drivers/acpi/processor_idle.c
> > > +++ linux-pm/drivers/acpi/processor_idle.c
> >
> > In this file, function acpi_processor_cstate_first_run_checks()
> > has a wrong pr_notice():
> >
> > pr_notice("ACPI: processor limited to max C-state %d\n",
> >                 max_cstate);
> >
> > Since we have pr_fmt() for this file, "ACPI:" is duplicate,
> > we'd better cleanup this as below:
> >
> > pr_notice("processor limited to max C-state %d\n", max_cstate);
>
> Thanks for pointing this out, I'll make this change when applying the patch.

Actually, this issue is not strictly related to the patch here, so I'm
going to send a separate patch to fix it.
Hanjun Guo Feb. 25, 2021, 2:17 p.m. UTC | #5 
On 2021/2/25 2:06, Rafael J. Wysocki wrote:
> On Tue, Feb 23, 2021 at 3:45 PM Rafael J. Wysocki <rafael@kernel.org> wrote:

>>

>> On Tue, Feb 23, 2021 at 12:31 PM Hanjun Guo <guohanjun@huawei.com> wrote:

>>>

>>> On 2021/2/23 2:59, Rafael J. Wysocki wrote:

>>>> Index: linux-pm/drivers/acpi/processor_idle.c

>>>> ===================================================================

>>>> --- linux-pm.orig/drivers/acpi/processor_idle.c

>>>> +++ linux-pm/drivers/acpi/processor_idle.c

>>>

>>> In this file, function acpi_processor_cstate_first_run_checks()

>>> has a wrong pr_notice():

>>>

>>> pr_notice("ACPI: processor limited to max C-state %d\n",

>>>                  max_cstate);

>>>

>>> Since we have pr_fmt() for this file, "ACPI:" is duplicate,

>>> we'd better cleanup this as below:

>>>

>>> pr_notice("processor limited to max C-state %d\n", max_cstate);

>>

>> Thanks for pointing this out, I'll make this change when applying the patch.

> 

> Actually, this issue is not strictly related to the patch here, so I'm

> going to send a separate patch to fix it.


Make sense to me as well.

Thanks
Hanjun