| Message ID | 20250505-mt8395-dtb-errors-v1-0-9c4714dcdcdb@collabora.com |
|---|---|
| Headers | show |
| Series | mt8395/mt6359: Fix several dtb-check errors | expand |
Il 05/05/25 15:23, Julien Massot ha scritto: > Some Mediatek IOMMU can have up to five interrupts so increase > the 'maxItems' to 5. > > Fix the following dtb-check error: > > mediatek/mt8395-radxa-nio-12l.dtb: infra-iommu@10315000: interrupts: > [[0, 795, 4, 0], [0, 796, 4, 0], [0, 797, 4, 0], [0, 798, 4, 0], [0, 799, 4, 0]] is too long > > Fixes: 3b5838d1d82e3 ("arm64: dts: mt8195: Add iommu and smi nodes") > Signed-off-by: Julien Massot <julien.massot@collabora.com> > --- > Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml b/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml > index 75750c64157c868725c087500ac81be4e282c829..035941c2db32170e9a69a5363d8c05ef767bb251 100644 > --- a/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml > +++ b/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml > @@ -97,7 +97,8 @@ properties: > maxItems: 1 > > interrupts: > - maxItems: 1 > + minItems: 1 Isn't minItems already implicitly 1? :-) Cheers, Angelo > + maxItems: 5 > > clocks: > items: >
Il 05/05/25 15:23, Julien Massot ha scritto: > The 'compatible' property is required by the > 'mfd/mediatek,mt6397.yaml' binding. Add it to fix the following > dtb-check error: > mediatek/mt8395-radxa-nio-12l.dtb: pmic: regulators: > 'compatible' is a required property > > Fixes: 3b7d143be4b7 ("arm64: dts: mt6359: add PMIC MT6359 related nodes") > Signed-off-by: Julien Massot <julien.massot@collabora.com> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
On Mon, 05 May 2025 15:23:36 +0200, Julien Massot wrote: > This patch series addresses several dtb-check errors reported for the mt8395-genio-1200-evk.dtb and mt8395-radxa-nio-12l.dtb device trees. > > The fixes include: > - Adding the missing #sound-dai-cells property in the mt6397 binding. > - Allowing up to 5 interrupts in the MediaTek IOMMU binding to support MT8395 properly. > - Defining the required compatible property in the regulators node of the mt6359.dtsi. > - Renaming the rtc node to match expected schema naming. > > [...] Applied to v6.15-next/dts64, thanks! [3/4] arm64: dts: mt6359: Add missing 'compatible' property to regulators node commit: 1fe38d2a19950fa6dbc384ee8967c057aef9faf4 Cheers, Angelo
Hi Angelo, On Tue, 2025-05-06 at 10:34 +0200, AngeloGioacchino Del Regno wrote: > Il 05/05/25 15:23, Julien Massot ha scritto: > > Some Mediatek IOMMU can have up to five interrupts so increase > > the 'maxItems' to 5. > > > > Fix the following dtb-check error: > > > > mediatek/mt8395-radxa-nio-12l.dtb: infra-iommu@10315000: interrupts: > > [[0, 795, 4, 0], [0, 796, 4, 0], [0, 797, 4, 0], [0, 798, 4, 0], [0, 799, 4, 0]] is too long > > > > Fixes: 3b5838d1d82e3 ("arm64: dts: mt8195: Add iommu and smi nodes") > > Signed-off-by: Julien Massot <julien.massot@collabora.com> > > --- > > Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml > > b/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml > > index 75750c64157c868725c087500ac81be4e282c829..035941c2db32170e9a69a5363d8c05ef767bb251 100644 > > --- a/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml > > +++ b/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml > > @@ -97,7 +97,8 @@ properties: > > maxItems: 1 > > > > interrupts: > > - maxItems: 1 > > + minItems: 1 > > Isn't minItems already implicitly 1? :-) > > Looks not, from my understanding if 'minItems' is omitted then dt-schema is setting it to 'maxItems'. https://github.com/devicetree-org/dt-schema/blob/v2025.02/dtschema/fixups.py#L129 And you will have an error for a one item interrupts: Documentation/devicetree/bindings/iommu/mediatek,iommu.example.dtb: iommu@10205000: interrupts: [[0, 139, 8]] is too short Regards, Julien
On 05/05/2025 15:23, Julien Massot wrote: > > Fixes: 3b5838d1d82e3 ("arm64: dts: mt8195: Add iommu and smi nodes") > Signed-off-by: Julien Massot <julien.massot@collabora.com> > --- > Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml b/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml > index 75750c64157c868725c087500ac81be4e282c829..035941c2db32170e9a69a5363d8c05ef767bb251 100644 > --- a/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml > +++ b/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml > @@ -97,7 +97,8 @@ properties: > maxItems: 1 > > interrupts: > - maxItems: 1 > + minItems: 1 > + maxItems: 5 > Every iommu or just some (as described in commit msg) can have 5 interrupts? Looks you miss here proper constraints per variant. Best regards, Krzysztof
Hi, This patch series addresses several dtb-check errors reported for the mt8395-genio-1200-evk.dtb and mt8395-radxa-nio-12l.dtb device trees. The fixes include: - Adding the missing #sound-dai-cells property in the mt6397 binding. - Allowing up to 5 interrupts in the MediaTek IOMMU binding to support MT8395 properly. - Defining the required compatible property in the regulators node of the mt6359.dtsi. - Renaming the rtc node to match expected schema naming. Signed-off-by: Julien Massot <julien.massot@collabora.com> --- Julien Massot (4): dt-bindings: mfd: mediatek: mt6397: Add #sound-dai-cells property dt-bindings: iommu: mediatek: mt8195 Accept up to 5 interrupts arm64: dts: mt6359: Add missing 'compatible' property to regulators node arm64: dts: mt6359: Rename RTC node to match binding expectations Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml | 3 ++- Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml | 3 +++ arch/arm64/boot/dts/mediatek/mt6359.dtsi | 4 +++- 3 files changed, 8 insertions(+), 2 deletions(-) --- base-commit: 407f60a151df3c44397e5afc0111eb9b026c38d3 change-id: 20250505-mt8395-dtb-errors-0847ffc12f44 Best regards,