mbox series

[v2,0/2] Bitmap bindings for rust

Message ID 20250224233938.3158-1-yury.norov@gmail.com
Headers show
Series Bitmap bindings for rust | expand

Message

Yury Norov Feb. 24, 2025, 11:39 p.m. UTC 
The bindings and a new maintenance entry together with the API changes
policy.

v1: https://lore.kernel.org/all/20250221205649.141305-1-yury.norov@gmail.com/T/
v2:
 - export alloc_cpumask_var() @ Viresh;
 - clarify that the maintenance rules apply to all bitmap interfaces,
   including those not mentioned explicitly in the helpers @ Miguel.

Viresh Kumar (1):
  rust: Add cpumask helpers

Yury Norov [NVIDIA] (1):
  MAINTAINERS: add rust bindings entry for bitmap API

 MAINTAINERS                     |  5 ++++
 rust/bindings/bindings_helper.h |  1 +
 rust/helpers/cpumask.c          | 45 +++++++++++++++++++++++++++++++++
 rust/helpers/helpers.c          |  1 +
 4 files changed, 52 insertions(+)
 create mode 100644 rust/helpers/cpumask.c

Comments

Alice Ryhl Feb. 25, 2025, 9:24 a.m. UTC | #1 
On Tue, Feb 25, 2025 at 12:39 AM Yury Norov <yury.norov@gmail.com> wrote:
>
> From: Viresh Kumar <viresh.kumar@linaro.org>
>
> In order to prepare for adding Rust abstractions for cpumask, add
> the required helpers for inline cpumask functions that cannot be
> called by rust code directly.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> Signed-off-by: Yury Norov [NVIDIA] <yury.norov@gmail.com>

Reviewed-by: Alice Ryhl <aliceryhl@google.com>
Viresh Kumar Feb. 25, 2025, 9:50 a.m. UTC | #2 
On 25-02-25, 06:43, Daniel Almeida wrote:
> I don’t understand what is going on here. You apparently did not provide the
> Rust code itself.
> 
> Usually, when I see a “in order to prepare for …” I expect the actual patch to
> follow in the same series.
> 
> Right now - and correct me if I'm wrong - it seems like you’ve essentially added
> dead code.

Rust abstractions:

https://lore.kernel.org/all/cover.1740475625.git.viresh.kumar@linaro.org/
Yury Norov Feb. 26, 2025, 4:17 p.m. UTC | #3 
On Tue, Feb 25, 2025 at 03:20:54PM +0530, Viresh Kumar wrote:
> On 25-02-25, 06:43, Daniel Almeida wrote:
> > I don’t understand what is going on here. You apparently did not provide the
> > Rust code itself.
> > 
> > Usually, when I see a “in order to prepare for …” I expect the actual patch to
> > follow in the same series.
> > 
> > Right now - and correct me if I'm wrong - it seems like you’ve essentially added
> > dead code.
> 
> Rust abstractions:
> 
> https://lore.kernel.org/all/cover.1740475625.git.viresh.kumar@linaro.org/

Yes, it's a dead code. 

Cpumasks is a library, and people sometimes submit library code separately
from their main projects, so it becomes unused for a while. GENMASK_U128()
is one recent example.

I'm not happy about it, but I understand why people do so - it's important
for them to have stable API, and their big project may take longer to get
upstreamed.

So, if nobody's strongly opposite, I will move it myself. Alternatively,
we can ask Viresh to take over the patches and move them together with
his series.

Thanks,
Yury
Yury Norov Feb. 28, 2025, 6:42 p.m. UTC | #4 
On Mon, Feb 24, 2025 at 06:39:34PM -0500, Yury Norov wrote:
> The bindings and a new maintenance entry together with the API changes
> policy.
> 
> v1: https://lore.kernel.org/all/20250221205649.141305-1-yury.norov@gmail.com/T/
> v2:
>  - export alloc_cpumask_var() @ Viresh;
>  - clarify that the maintenance rules apply to all bitmap interfaces,
>    including those not mentioned explicitly in the helpers @ Miguel.

OK, adding in bitmap-for-next for testing.

Thanks,
Yury
 
> Viresh Kumar (1):
>   rust: Add cpumask helpers
> 
> Yury Norov [NVIDIA] (1):
>   MAINTAINERS: add rust bindings entry for bitmap API
> 
>  MAINTAINERS                     |  5 ++++
>  rust/bindings/bindings_helper.h |  1 +
>  rust/helpers/cpumask.c          | 45 +++++++++++++++++++++++++++++++++
>  rust/helpers/helpers.c          |  1 +
>  4 files changed, 52 insertions(+)
>  create mode 100644 rust/helpers/cpumask.c
> 
> -- 
> 2.43.0