| Message ID | 20240508034352.18414-1-ricardo.neri-calderon@linux.intel.com |
|---|---|
| Headers | show |
| Series | thermal: intel: hfi: Update thermal netlink parameters | expand |
On Tue, 2024-05-07 at 20:43 -0700, Ricardo Neri wrote: > When processing a hardware update, HFI generates as many thermal > netlink > events as needed to relay all the updated CPU capabilities to user > space. > The constant HFI_MAX_THERM_NOTIFY_COUNT is the number of CPU > capabilities > updated per each of those events. > > Give this constant a more descriptive name. > > Signed-off-by: Ricardo Neri <ricardo.neri-calderon@linux.intel.com> Acked-by: Zhang Rui <rui.zhang@intel.com> -rui > --- > Cc: Len Brown <len.brown@intel.com> > Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> > Cc: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com> > Cc: Zhang Rui <rui.zhang@intel.com> > Cc: linux-pm@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > --- > Changes since v1: > * None > --- > drivers/thermal/intel/intel_hfi.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/thermal/intel/intel_hfi.c > b/drivers/thermal/intel/intel_hfi.c > index d82b8788b0f8..c6658f8c5cca 100644 > --- a/drivers/thermal/intel/intel_hfi.c > +++ b/drivers/thermal/intel/intel_hfi.c > @@ -167,7 +167,7 @@ static DEFINE_MUTEX(hfi_instance_lock); > > static struct workqueue_struct *hfi_updates_wq; > #define HFI_UPDATE_DELAY_MS 100 > -#define HFI_MAX_THERM_NOTIFY_COUNT 16 > +#define HFI_THERMNL_CAPS_PER_EVENT 16 > > static void get_hfi_caps(struct hfi_instance *hfi_instance, > struct thermal_genl_cpu_caps *cpu_caps) > @@ -218,14 +218,14 @@ static void update_capabilities(struct > hfi_instance *hfi_instance) > > get_hfi_caps(hfi_instance, cpu_caps); > > - if (cpu_count < HFI_MAX_THERM_NOTIFY_COUNT) > + if (cpu_count < HFI_THERMNL_CAPS_PER_EVENT) > goto last_cmd; > > - /* Process complete chunks of HFI_MAX_THERM_NOTIFY_COUNT > capabilities. */ > + /* Process complete chunks of HFI_THERMNL_CAPS_PER_EVENT > capabilities. */ > for (i = 0; > - (i + HFI_MAX_THERM_NOTIFY_COUNT) <= cpu_count; > - i += HFI_MAX_THERM_NOTIFY_COUNT) > - > thermal_genl_cpu_capability_event(HFI_MAX_THERM_NOTIFY_ > COUNT, > + (i + HFI_THERMNL_CAPS_PER_EVENT) <= cpu_count; > + i += HFI_THERMNL_CAPS_PER_EVENT) > + thermal_genl_cpu_capability_event(HFI_THERMNL_CAPS_PE > R_EVENT, > &cpu_caps[i]); > > cpu_count = cpu_count - i;
Hi, This is v2 of a series previously known as "Add debugfs files for tuning" [1]. Changes since v1: Rui and Rafael pointed out various problems with using debugfs for tuning how HFI uses thermal netlink. Instead, in this version I attempt to fix the issues that motivated v1 (see the cover letter of v1 for details). I update the two parameters that control how HFI uses thermal netlink: the delay between an HFI interrupt and the thermal netlink event as well as the size of the message payload. Added Acked-by: tag from Rui on patch 1 (thanks!). These patches apply cleanly on top of the testing branch of Rafael's linux-pm. Thanks and BR, Ricardo [1]. https://lore.kernel.org/linux-pm/20240429234152.16230-1-ricardo.neri-calderon@linux.intel.com/ Ricardo Neri (4): thermal: intel: hfi: Rename HFI_UPDATE_INTERVAL thermal: intel: hfi: Shorten the thermal netlink event delay to 100ms thermal: intel: hfi: Rename HFI_MAX_THERM_NOTIFY_COUNT thermal: intel: hfi: Increase the number of CPU capabilities per netlink event drivers/thermal/intel/intel_hfi.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)