| Message ID | 20231120145049.310509-1-m.majewski2@samsung.com |
|---|---|
| Headers | show |
| Series | Improve Exynos thermal driver | expand |
On 11/20/23 14:50, Mateusz Majewski wrote: > Currently, each trip point defined in the device tree corresponds to a > single hardware interrupt. This commit instead switches to using two > hardware interrupts, whose values are set dynamically using the > set_trips callback. Additionally, the critical temperature threshold is > handled specifically. > > Setting interrupts in this way also fixes a long-standing lockdep > warning, which was caused by calling thermal_zone_get_trips with our > lock being held. Do note that this requires TMU initialization to be > split into two parts, as done by the parent commit: parts of the > initialization call into the thermal_zone_device structure and so must > be done after its registration, but the initialization is also > responsible for setting up calibration, which must be done before > thermal_zone_device registration, which will call set_trips for the > first time; if the calibration is not done in time, the interrupt values > will be silently wrong! > > Signed-off-by: Mateusz Majewski <m.majewski2@samsung.com> > --- > v4 -> v5: Simplified Exynos 7 code, used the correct register offsets > for Exynos 7 and refactored some common register-setting code. > v2 -> v3: Fixed formatting of some comments. > v1 -> v2: We take clocks into account; anything that sets temperature > thresholds needs clk. > > drivers/thermal/samsung/exynos_tmu.c | 393 ++++++++++++++------------- > 1 file changed, 209 insertions(+), 184 deletions(-) The code LGTM and I like the idea of dynamically configured IRQs for trips. Reviewed-by: Lukasz Luba <lukasz.luba@arm.com> Regards, Lukasz
This work improves Exynos thermal driver in various ways. This is related to the discussion in https://lore.kernel.org/all/97201878-3bb8-eac5-7fac-a690322ac43a@linaro.org/ The primary issue being fixed is a lockdep warning, which is fixed by the thermal: exynos: use set_trips patch. We also simplify the code in general. Changelog: v5: - Used BIT wherever possible - Simplified Exynos 7 code and used the correct register offsets for Exynos 7 - Refactored some common register-setting code v4: - Resolved merge conflict when applying thermal: exynos: split initialization of TMU and the thermal zone - Reordered calls done when leaving exynos_tmu_initialize for symmetry v3: - Fixed regulator initialization - Fixed formatting of some comments v2: - Added missing field descriptions - Removed an unnecessary field description - Removed the commits that made clock management more fine-grained (need more discussion), and adapted the new code to manage clocks - Removed the devicetree changes (will be uploaded separately), changing the recipient list accordingly - Improved formatting of the devm_request_threaded_irq call Mateusz Majewski (9): thermal: exynos: remove an unnecessary field description thermal: exynos: drop id field thermal: exynos: switch from workqueue-driven interrupt handling to threaded interrupts thermal: exynos: handle devm_regulator_get_optional return value correctly thermal: exynos: simplify regulator (de)initialization thermal: exynos: stop using the threshold mechanism on Exynos 4210 thermal: exynos: split initialization of TMU and the thermal zone thermal: exynos: use BIT wherever possible thermal: exynos: use set_trips drivers/thermal/samsung/exynos_tmu.c | 532 +++++++++++++-------------- 1 file changed, 258 insertions(+), 274 deletions(-)