mbox series

[0/6] Enable MSM8226 TSENS support

Message ID 20230507201225.89694-1-matti.lehtimaki@gmail.com
Headers show
Series Enable MSM8226 TSENS support | expand

Message

Matti Lehtimäki May 7, 2023, 8:12 p.m. UTC
Add support for tsens in MSM8226. Add qfprom compatible for MSM8226.
Add device tree nodes for qfprom, tsens and thermal zones for MSM8226.

Matti Lehtimäki (6):
  dt-bindings: nvmem: qfprom: Add compatible for MSM8226
  dt-bindings: thermal: tsens: Add compatible for MSM8226
  thermal/drivers/qcom/tsens-v0_1: Add support for MSM8226
  ARM: dts: msm8226: Add qfprom node
  ARM: dts: msm8226: Add tsens node and related nvmem cells
  ARM: dts: msm8226: Add thermal zones node

 .../bindings/nvmem/qcom,qfprom.yaml           |   1 +
 .../bindings/thermal/qcom-tsens.yaml          |   1 +
 arch/arm/boot/dts/qcom-msm8226.dtsi           | 164 ++++++++++++++++++
 drivers/thermal/qcom/tsens-v0_1.c             |  27 ++-
 drivers/thermal/qcom/tsens.c                  |   3 +
 drivers/thermal/qcom/tsens.h                  |   2 +-
 6 files changed, 196 insertions(+), 2 deletions(-)

Comments

Luca Weiss May 7, 2023, 8:22 p.m. UTC | #1
On Sonntag, 7. Mai 2023 22:12:20 CEST Matti Lehtimäki wrote:
> Qualcomm MSM8226 has tsens v0.1 block.
> 
> Signed-off-by: Matti Lehtimäki <matti.lehtimaki@gmail.com>

Reviewed-by: Luca Weiss <luca@z3ntu.xyz>

> ---
>  Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml index
> 926e9c51c93c..d6b2957d5137 100644
> --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> @@ -29,6 +29,7 @@ properties:
>          items:
>            - enum:
>                - qcom,mdm9607-tsens
> +              - qcom,msm8226-tsens
>                - qcom,msm8916-tsens
>                - qcom,msm8939-tsens
>                - qcom,msm8974-tsens
Rob Herring May 7, 2023, 9:25 p.m. UTC | #2
On Sun, 07 May 2023 23:12:20 +0300, Matti Lehtimäki wrote:
> Qualcomm MSM8226 has tsens v0.1 block.
> 
> Signed-off-by: Matti Lehtimäki <matti.lehtimaki@gmail.com>
> ---
>  Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.example.dtb: pcie-ep@33800000: Unevaluated properties are not allowed ('assigned-clock-parents', 'assigned-clock-rates', 'assigned-clocks' were unexpected)
	From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/rockchip-isp1.example.dtb: camera@3c: port:endpoint:data-lanes: [[1]] is too short
	From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/ovti,ov2685.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/ovti,ov2685.example.dtb: camera-sensor@3c: port:endpoint:data-lanes: [[1]] is too short
	From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/ovti,ov2685.yaml

doc reference errors (make refcheckdocs):
Documentation/usb/gadget_uvc.rst: Documentation/userspace-api/media/v4l/pixfmt-packed.yuv.rst
MAINTAINERS: Documentation/devicetree/bindings/pwm/pwm-apple.yaml

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230507201225.89694-3-matti.lehtimaki@gmail.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
Bjorn Andersson June 13, 2023, 11:48 p.m. UTC | #3
On Sun, 7 May 2023 23:12:18 +0300, Matti Lehtimäki wrote:
> Add support for tsens in MSM8226. Add qfprom compatible for MSM8226.
> Add device tree nodes for qfprom, tsens and thermal zones for MSM8226.
> 
> Matti Lehtimäki (6):
>   dt-bindings: nvmem: qfprom: Add compatible for MSM8226
>   dt-bindings: thermal: tsens: Add compatible for MSM8226
>   thermal/drivers/qcom/tsens-v0_1: Add support for MSM8226
>   ARM: dts: msm8226: Add qfprom node
>   ARM: dts: msm8226: Add tsens node and related nvmem cells
>   ARM: dts: msm8226: Add thermal zones node
> 
> [...]

Applied, thanks!

[4/6] ARM: dts: msm8226: Add qfprom node
      commit: 16a9fa7ab27b69be3a34b97ff8c7b034fcc73b88
[5/6] ARM: dts: msm8226: Add tsens node and related nvmem cells
      commit: 0f8861c9fc7cc9af6d6f65d6657aa9cf2531b29c
[6/6] ARM: dts: msm8226: Add thermal zones node
      commit: 8d4236f62f3acbc6a0def79106c13fe7344d8238

Best regards,