Message ID | 20221118224540.619276-1-uwe@kleine-koenig.org |
---|---|
Headers | show |
Series | i2c: Complete conversion to i2c_probe_new | expand |
Hello: This patch was applied to chrome-platform/linux.git (for-kernelci) by Tzung-Bi Shih <tzungbi@kernel.org>: On Fri, 18 Nov 2022 23:35:34 +0100 you wrote: > Hello, > > since commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new() > call-back type") from 2016 there is a "temporary" alternative probe > callback for i2c drivers. > > This series completes all drivers to this new callback (unless I missed > something). It's based on current next/master. > A part of the patches depend on commit 662233731d66 ("i2c: core: > Introduce i2c_client_get_device_id helper function"), there is a branch that > you can pull into your tree to get it: > > [...] Here is the summary with links: - [512/606] platform/chrome: cros_ec: Convert to i2c's .probe_new() https://git.kernel.org/chrome-platform/c/f9e510dc92df You are awesome, thank you!
Hi, On 11/18/22 23:44, Uwe Kleine-König wrote: > From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > > .probe_new() doesn't get the i2c_device_id * parameter, so determine > that explicitly in the probe function. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Thanks, patch looks good to me: Reviewed-by: Hans de Goede <hdegoede@redhat.com> Regards, Hans > --- > drivers/power/supply/max17042_battery.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/power/supply/max17042_battery.c b/drivers/power/supply/max17042_battery.c > index ab031bbfbe78..89cabe8ed3b0 100644 > --- a/drivers/power/supply/max17042_battery.c > +++ b/drivers/power/supply/max17042_battery.c > @@ -1031,9 +1031,9 @@ static const struct power_supply_desc max17042_no_current_sense_psy_desc = { > .num_properties = ARRAY_SIZE(max17042_battery_props) - 2, > }; > > -static int max17042_probe(struct i2c_client *client, > - const struct i2c_device_id *id) > +static int max17042_probe(struct i2c_client *client) > { > + const struct i2c_device_id *id = i2c_client_get_device_id(client); > struct i2c_adapter *adapter = client->adapter; > const struct power_supply_desc *max17042_desc = &max17042_psy_desc; > struct power_supply_config psy_cfg = {}; > @@ -1220,7 +1220,7 @@ static struct i2c_driver max17042_i2c_driver = { > .of_match_table = of_match_ptr(max17042_dt_match), > .pm = &max17042_pm_ops, > }, > - .probe = max17042_probe, > + .probe_new = max17042_probe, > .id_table = max17042_id, > }; > module_i2c_driver(max17042_i2c_driver);
Queued all of the below: with one tweaked as per your suggestion and the highlighted one dropped on basis I was already carrying the equivalent - as you pointed out. I was already carrying the required dependency. Includes the IIO ones in staging. Thanks, Jonathan p.s. I perhaps foolishly did this in a highly manual way so as to also pick up Andy's RB. So might have dropped one... Definitely would have been better as one patch per subsystem with a cover letter suitable for replies like Andy's to be picked up by b4. > iio: accel: adxl372_i2c: Convert to i2c's .probe_new() > iio: accel: bma180: Convert to i2c's .probe_new() > iio: accel: bma400: Convert to i2c's .probe_new() > iio: accel: bmc150: Convert to i2c's .probe_new() > iio: accel: da280: Convert to i2c's .probe_new() > iio: accel: kxcjk-1013: Convert to i2c's .probe_new() > iio: accel: mma7455_i2c: Convert to i2c's .probe_new() > iio: accel: mma8452: Convert to i2c's .probe_new() > iio: accel: mma9551: Convert to i2c's .probe_new() > iio: accel: mma9553: Convert to i2c's .probe_new() > iio: adc: ad7091r5: Convert to i2c's .probe_new() > iio: adc: ad7291: Convert to i2c's .probe_new() > iio: adc: ad799x: Convert to i2c's .probe_new() > iio: adc: ina2xx-adc: Convert to i2c's .probe_new() > iio: adc: ltc2471: Convert to i2c's .probe_new() > iio: adc: ltc2485: Convert to i2c's .probe_new() > iio: adc: ltc2497: Convert to i2c's .probe_new() > iio: adc: max1363: Convert to i2c's .probe_new() > iio: adc: max9611: Convert to i2c's .probe_new() > iio: adc: mcp3422: Convert to i2c's .probe_new() > iio: adc: ti-adc081c: Convert to i2c's .probe_new() > iio: adc: ti-ads1015: Convert to i2c's .probe_new() > iio: cdc: ad7150: Convert to i2c's .probe_new() > iio: cdc: ad7746: Convert to i2c's .probe_new() > iio: chemical: ams-iaq-core: Convert to i2c's .probe_new() > iio: chemical: atlas-ezo-sensor: Convert to i2c's .probe_new() > iio: chemical: atlas-sensor: Convert to i2c's .probe_new() > iio: chemical: bme680_i2c: Convert to i2c's .probe_new() > iio: chemical: ccs811: Convert to i2c's .probe_new() > iio: chemical: scd4x: Convert to i2c's .probe_new() > iio: chemical: sgp30: Convert to i2c's .probe_new() > iio: chemical: sgp40: Convert to i2c's .probe_new() > iio: chemical: vz89x: Convert to i2c's .probe_new() > iio: dac: ad5064: Convert to i2c's .probe_new() > iio: dac: ad5380: Convert to i2c's .probe_new() > iio: dac: ad5446: Convert to i2c's .probe_new() > iio: dac: ad5593r: Convert to i2c's .probe_new() > iio: dac: ad5696-i2c: Convert to i2c's .probe_new() > iio: dac: ds4424: Convert to i2c's .probe_new() > iio: dac: m62332: Convert to i2c's .probe_new() > iio: dac: max517: Convert to i2c's .probe_new() > iio: dac: max5821: Convert to i2c's .probe_new() > iio: dac: mcp4725: Convert to i2c's .probe_new() > iio: dac: ti-dac5571: Convert to i2c's .probe_new() > iio: gyro: bmg160_i2c: Convert to i2c's .probe_new() > iio: gyro: itg3200_core: Convert to i2c's .probe_new() > iio: gyro: mpu3050-i2c: Convert to i2c's .probe_new() > iio: gyro: st_gyro_i2c: Convert to i2c's .probe_new() > iio: health: afe4404: Convert to i2c's .probe_new() > iio: health: max30100: Convert to i2c's .probe_new() > iio: health: max30102: Convert to i2c's .probe_new() > iio: humidity: am2315: Convert to i2c's .probe_new() > iio: humidity: hdc100x: Convert to i2c's .probe_new() > iio: humidity: hdc2010: Convert to i2c's .probe_new() > iio: humidity: hts221_i2c: Convert to i2c's .probe_new() > iio: humidity: htu21: Convert to i2c's .probe_new() > iio: humidity: si7005: Convert to i2c's .probe_new() > iio: humidity: si7020: Convert to i2c's .probe_new() > iio: imu: bmi160/bmi160_i2c: Convert to i2c's .probe_new() > iio: imu: fxos8700_i2c: Convert to i2c's .probe_new() > iio: imu: inv_mpu6050: Convert to i2c's .probe_new() > iio: imu: kmx61: Convert to i2c's .probe_new() > iio: imu: st_lsm6dsx: Convert to i2c's .probe_new() > iio: light: adjd_s311: Convert to i2c's .probe_new() > iio: light: adux1020: Convert to i2c's .probe_new() > iio: light: al3010: Convert to i2c's .probe_new() > iio: light: al3320a: Convert to i2c's .probe_new() > iio: light: apds9300: Convert to i2c's .probe_new() > iio: light: apds9960: Convert to i2c's .probe_new() > iio: light: bh1750: Convert to i2c's .probe_new() > iio: light: bh1780: Convert to i2c's .probe_new() > iio: light: cm3232: Convert to i2c's .probe_new() > iio: light: cm3323: Convert to i2c's .probe_new() > iio: light: cm36651: Convert to i2c's .probe_new() > iio: light: gp2ap002: Convert to i2c's .probe_new() > iio: light: gp2ap020a00f: Convert to i2c's .probe_new() > iio: light: isl29018: Convert to i2c's .probe_new() > iio: light: isl29028: Convert to i2c's .probe_new() > iio: light: isl29125: Convert to i2c's .probe_new() > iio: light: jsa1212: Convert to i2c's .probe_new() > iio: light: ltr501: Convert to i2c's .probe_new() > iio: light: lv0104cs: Convert to i2c's .probe_new() > iio: light: max44000: Convert to i2c's .probe_new() > iio: light: max44009: Convert to i2c's .probe_new() > iio: light: noa1305: Convert to i2c's .probe_new() > iio: light: opt3001: Convert to i2c's .probe_new() > iio: light: pa12203001: Convert to i2c's .probe_new() > iio: light: rpr0521: Convert to i2c's .probe_new() > iio: light: si1133: Convert to i2c's .probe_new() > iio: light: si1145: Convert to i2c's .probe_new() > iio: light: st_uvis25_i2c: Convert to i2c's .probe_new() > iio: light: stk3310: Convert to i2c's .probe_new() > iio: light: tcs3414: Convert to i2c's .probe_new() > iio: light: tcs3472: Convert to i2c's .probe_new() > iio: light: tsl2563: Convert to i2c's .probe_new() > iio: light: tsl2583: Convert to i2c's .probe_new() > iio: light: tsl2772: Convert to i2c's .probe_new() > iio: light: tsl4531: Convert to i2c's .probe_new() > iio: light: us5182d: Convert to i2c's .probe_new() > iio: light: vcnl4000: Convert to i2c's .probe_new() > iio: light: vcnl4035: Convert to i2c's .probe_new() > iio: light: veml6030: Convert to i2c's .probe_new() > iio: light: veml6070: Convert to i2c's .probe_new() > iio: light: zopt2201: Convert to i2c's .probe_new() > iio: magnetometer: ak8974: Convert to i2c's .probe_new() > iio: magnetometer: ak8975: Convert to i2c's .probe_new() > iio: magnetometer: bmc150_magn_i2c: Convert to i2c's .probe_new() > iio: magnetometer: hmc5843: Convert to i2c's .probe_new() > iio: magnetometer: mag3110: Convert to i2c's .probe_new() > iio: magnetometer: mmc35240: Convert to i2c's .probe_new() > iio: magnetometer: yamaha-yas530: Convert to i2c's .probe_new() > iio: potentiometer: ad5272: Convert to i2c's .probe_new() > iio: potentiometer: ds1803: Convert to i2c's .probe_new() > iio: potentiometer: max5432: Convert to i2c's .probe_new() > iio: potentiometer: tpl0102: Convert to i2c's .probe_new() > iio: potentiostat: lmp91000: Convert to i2c's .probe_new() > iio: pressure: abp060mg: Convert to i2c's .probe_new() Not this one > iio: pressure: bmp280-i2c: Convert to i2c's .probe_new() > iio: pressure: dlhl60d: Convert to i2c's .probe_new() > iio: pressure: dps310: Convert to i2c's .probe_new() > iio: pressure: hp03: Convert to i2c's .probe_new() > iio: pressure: hp206c: Convert to i2c's .probe_new() > iio: pressure: icp10100: Convert to i2c's .probe_new() > iio: pressure: mpl115_i2c: Convert to i2c's .probe_new() > iio: pressure: mpl3115: Convert to i2c's .probe_new() > iio: pressure: ms5611_i2c: Convert to i2c's .probe_new() > iio: pressure: ms5637: Convert to i2c's .probe_new() > iio: pressure: st_pressure_i2c: Convert to i2c's .probe_new() > iio: pressure: t5403: Convert to i2c's .probe_new() > iio: pressure: zpa2326_i2c: Convert to i2c's .probe_new() > iio: proximity: isl29501: Convert to i2c's .probe_new() > iio: proximity: mb1232: Convert to i2c's .probe_new() > iio: proximity: pulsedlight-lidar-lite-v2: Convert to i2c's > .probe_new() > iio: proximity: rfd77402: Convert to i2c's .probe_new() > iio: proximity: srf08: Convert to i2c's .probe_new() > iio: proximity: sx9500: Convert to i2c's .probe_new() > iio: temperature: mlx90614: Convert to i2c's .probe_new() > iio: temperature: mlx90632: Convert to i2c's .probe_new() > iio: temperature: tmp006: Convert to i2c's .probe_new() > iio: temperature: tmp007: Convert to i2c's .probe_new() > iio: temperature: tsys01: Convert to i2c's .probe_new() > iio: temperature: tsys02d: Convert to i2c's .probe_new() ... > staging: iio: adt7316: Convert to i2c's .probe_new() > staging: iio: ad5933: Convert to i2c's .probe_new() > staging: iio: ade7854: Convert to i2c's .probe_new()
On Fri, 18 Nov 2022 23:35:34 +0100, Uwe Kleine-König wrote: > since commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new() > call-back type") from 2016 there is a "temporary" alternative probe > callback for i2c drivers. > > This series completes all drivers to this new callback (unless I missed > something). It's based on current next/master. > A part of the patches depend on commit 662233731d66 ("i2c: core: > Introduce i2c_client_get_device_id helper function"), there is a branch that > you can pull into your tree to get it: > > [...] Applied, thanks! Repo: https://cgit.freedesktop.org/drm/drm-misc/ [014/606] drm/bridge: adv7511: Convert to i2c's .probe_new() commit: 1c546894ff82f8b7c070998c03f9b15a3499f326 [028/606] drm/bridge: parade-ps8622: Convert to i2c's .probe_new() commit: d6b522e9bbb0cca1aeae4ef6188800534794836f [035/606] drm/bridge: ti-sn65dsi83: Convert to i2c's .probe_new() commit: 0f6548807fa77e87bbc37964c6b1ed9ba6e1155d rob