From patchwork Wed Sep 28 21:00:30 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Daniel Lezcano X-Patchwork-Id: 610491 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FDE7C6FA93 for ; Wed, 28 Sep 2022 21:01:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233425AbiI1VBR (ORCPT ); Wed, 28 Sep 2022 17:01:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43158 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233015AbiI1VBP (ORCPT ); Wed, 28 Sep 2022 17:01:15 -0400 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 216F22DA86 for ; Wed, 28 Sep 2022 14:01:11 -0700 (PDT) Received: by mail-wr1-x432.google.com with SMTP id x18so21604310wrm.7 for ; Wed, 28 Sep 2022 14:01:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date; bh=rzDboIf/0ZkplK5avMKmSlVoA8poTTgfjo85z32vUpw=; b=PXylRomthejoADML0IdWhQUGrmdli4X7Lz+BJkAfYAIG00MvIjUl3xr0rDM7Tp+c9E gERTEzX6OrmGxpSznrRYJVml/BbowAO721rEaCiF2ZRaNgXJ7o8FbpZQkgrjZXNIyM4T qZNAqp1UlAcp1VHjxAk6up9ZJhT0M9XaoYiwA8Lbv/DCcNKHW1lqBu7me6e6M0G5O9y5 6elYYL8Br46BJy3ugJfzyt5TF6Kn3evoIrzIp8C3LQcSObibYdeDxG9YCabSAH16lf0w /qEmyrqU+YpieR9hy2GfcKRjUyNR5i8QsH8kAw0rn228woofdN32juEndUDd2mVi1Y5Y 49XA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date; bh=rzDboIf/0ZkplK5avMKmSlVoA8poTTgfjo85z32vUpw=; b=5GppPik8AoSR87kSRMZWgTw+u4EZ5E5SG27AJ5M2dYrcVeZFBjWfBYaGD/+NaVZ28e Pw9JCFKIXaH73lf711O4iT1tbWy8/EWHavQMyKbZcvW9EmKmkNDfw/mOP+aiMjTojFhR dLhulRFr6ASTIrX8I872+dG/6DAXV75owC3LTtsn4ygnOIqGvTzLMQudopo/vKI5e50t 6/Q6PypPKjFnmKlwYBYCdhuXAkGooVzjOIKSvZMPAaoLHagUiwU+qEB9kbtn1wBVaR68 7HKiMFj3F4RNFgVZ03rw44hi1mslbYAAE44NS9sv0JqruR3gbaGS0Sxv8yhjkodjIjX6 AKBg== X-Gm-Message-State: ACrzQf0cSyZJn+ZDNmNAyD8qWw22es6wngFSqde/rCVvNkKgtwTS2+Zh fYS+nnH4aWWc8xH1V2a67yb+ZA== X-Google-Smtp-Source: AMsMyM7phNWIVsHp55ggg5BnRcj1C06uD07FaHc0YVPmQtKh3wHiewzaoFstiqc0jphNe/Zmeu6ZVg== X-Received: by 2002:a05:6000:1881:b0:22c:bee7:96e with SMTP id a1-20020a056000188100b0022cbee7096emr6855462wri.418.1664398869586; Wed, 28 Sep 2022 14:01:09 -0700 (PDT) Received: from mai.. ([2a05:6e02:1041:c10:48a2:39eb:9d1b:8b8d]) by smtp.gmail.com with ESMTPSA id g20-20020a05600c4ed400b003b4931eb435sm2874300wmq.26.2022.09.28.14.01.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Sep 2022 14:01:09 -0700 (PDT) From: Daniel Lezcano To: daniel.lezcano@linaro.org, rafael@kernel.org Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, rui.zhang@intel.com, Raju Rangoju , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Peter Kaestle , Hans de Goede , Mark Gross , Miquel Raynal , Amit Kucheria , Nicolas Saenz Julienne , Broadcom Kernel Team , Florian Fainelli , Ray Jui , Scott Branden , Support Opensource , Lukasz Luba , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Thara Gopinath , Andy Gross , Bjorn Andersson , =?utf-8?q?Niklas_S=C3=B6derlu?= =?utf-8?q?nd?= , Bartlomiej Zolnierkiewicz , Krzysztof Kozlowski , Alim Akhtar , Thierry Reding , Jonathan Hunter , Eduardo Valentin , Keerthy , Kunihiko Hayashi , Masami Hiramatsu , Antoine Tenart , Srinivas Pandruvada , Dmitry Osipenko , netdev@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org Subject: [PATCH v7 00/29] Rework the trip points creation Date: Wed, 28 Sep 2022 23:00:30 +0200 Message-Id: <20220928210059.891387-1-daniel.lezcano@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org This work is the pre-requisite of handling correctly when the trip point are crossed. For that we need to rework how the trip points are declared and assigned to a thermal zone. Even if it appears to be a common sense to have the trip points being ordered, this no guarantee neither documentation telling that is the case. One solution could have been to create an ordered array of trips built when registering the thermal zone by calling the different get_trip* ops. However those ops receive a thermal zone pointer which is not known as it is in the process of creating it. This cyclic dependency shows we have to rework how we manage the trip points. Actually, all the trip points definition can be common to the backend sensor drivers and we can factor out the thermal trip structure in all of them. Then, as we register the thermal trips array, they will be available in the thermal zone structure and a core function can return the trip given its id. The get_trip_* ops won't be needed anymore and could be removed. The resulting code will be another step forward to a self encapsulated generic thermal framework. Most of the drivers can be converted more or less easily. This series does a first round with most of the drivers. Some remain and will be converted but with a smaller set of changes as the conversion is a bit more complex. Changelog: v7: - Added missing return 0 in the x86_pkg_temp driver v6: - Improved the code for the get_crit_temp() function as suggested by Rafael - Removed inner parenthesis in the set_trip_temp() function and invert the conditions. Check the type of the trip point is unchanged - Folded patch 4 with 1 - Add per thermal zone info message in the bang-bang governor - Folded the fix for an uninitialized variable in int340x_thermal_zone_add() v5: - Fixed a deadlock when calling thermal_zone_get_trip() while handling the thermal zone lock - Remove an extra line in the sysfs change - Collected tags v4: - Remove extra lines on exynos changes as reported by Krzysztof Kozlowski - Collected tags v3: - Reorg the series to be git-bisect safe - Added the set_trip generic function - Added the get_crit_temp generic function - Removed more dead code in the thermal-of - Fixed the exynos changelog - Fixed the error check for the exynos drivers - Collected tags v2: - Added missing EXPORT_SYMBOL_GPL() for thermal_zone_get_trip() - Removed tab whitespace in the acerhdf driver - Collected tags Cc: Raju Rangoju Cc: "David S. Miller" Cc: Eric Dumazet Cc: Jakub Kicinski Cc: Paolo Abeni Cc: Peter Kaestle Cc: Hans de Goede Cc: Mark Gross Cc: Miquel Raynal Cc: "Rafael J. Wysocki" Cc: Daniel Lezcano Cc: Amit Kucheria Cc: Zhang Rui Cc: Nicolas Saenz Julienne Cc: Broadcom Kernel Team Cc: Florian Fainelli Cc: Ray Jui Cc: Scott Branden Cc: Support Opensource Cc: Lukasz Luba Cc: Shawn Guo Cc: Sascha Hauer Cc: Pengutronix Kernel Team Cc: Fabio Estevam Cc: NXP Linux Team Cc: Thara Gopinath Cc: Andy Gross Cc: Bjorn Andersson Cc: "Niklas Söderlund" Cc: Bartlomiej Zolnierkiewicz Cc: Krzysztof Kozlowski Cc: Alim Akhtar Cc: Thierry Reding Cc: Jonathan Hunter Cc: Eduardo Valentin Cc: Keerthy Cc: Kunihiko Hayashi Cc: Masami Hiramatsu Cc: Antoine Tenart Cc: Srinivas Pandruvada Cc: Dmitry Osipenko Cc: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: platform-driver-x86@vger.kernel.org Cc: linux-pm@vger.kernel.org Cc: linux-rpi-kernel@lists.infradead.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-arm-msm@vger.kernel.org Cc: linux-renesas-soc@vger.kernel.org Cc: linux-samsung-soc@vger.kernel.org Cc: linux-tegra@vger.kernel.org Cc: linux-omap@vger.kernel.org Daniel Lezcano (29): thermal/core: Add a generic thermal_zone_get_trip() function thermal/sysfs: Always expose hysteresis attributes thermal/core: Add a generic thermal_zone_set_trip() function thermal/core/governors: Use thermal_zone_get_trip() instead of ops functions thermal/of: Use generic thermal_zone_get_trip() function thermal/of: Remove unused functions thermal/drivers/exynos: Use generic thermal_zone_get_trip() function thermal/drivers/exynos: of_thermal_get_ntrips() thermal/drivers/exynos: Replace of_thermal_is_trip_valid() by thermal_zone_get_trip() thermal/drivers/tegra: Use generic thermal_zone_get_trip() function thermal/drivers/uniphier: Use generic thermal_zone_get_trip() function thermal/drivers/hisi: Use generic thermal_zone_get_trip() function thermal/drivers/qcom: Use generic thermal_zone_get_trip() function thermal/drivers/armada: Use generic thermal_zone_get_trip() function thermal/drivers/rcar_gen3: Use the generic function to get the number of trips thermal/of: Remove of_thermal_get_ntrips() thermal/of: Remove of_thermal_is_trip_valid() thermal/of: Remove of_thermal_set_trip_hyst() thermal/of: Remove of_thermal_get_crit_temp() thermal/drivers/st: Use generic trip points thermal/drivers/imx: Use generic thermal_zone_get_trip() function thermal/drivers/rcar: Use generic thermal_zone_get_trip() function thermal/drivers/broadcom: Use generic thermal_zone_get_trip() function thermal/drivers/da9062: Use generic thermal_zone_get_trip() function thermal/drivers/ti: Remove unused macros ti_thermal_get_trip_value() / ti_thermal_trip_is_valid() thermal/drivers/acerhdf: Use generic thermal_zone_get_trip() function thermal/drivers/cxgb4: Use generic thermal_zone_get_trip() function thermal/intel/int340x: Replace parameter to simplify thermal/drivers/intel: Use generic thermal_zone_get_trip() function drivers/net/ethernet/chelsio/cxgb4/cxgb4.h | 2 - .../ethernet/chelsio/cxgb4/cxgb4_thermal.c | 41 +---- drivers/platform/x86/acerhdf.c | 73 +++----- drivers/thermal/armada_thermal.c | 39 ++--- drivers/thermal/broadcom/bcm2835_thermal.c | 8 +- drivers/thermal/da9062-thermal.c | 52 +----- drivers/thermal/gov_bang_bang.c | 39 +++-- drivers/thermal/gov_fair_share.c | 18 +- drivers/thermal/gov_power_allocator.c | 51 +++--- drivers/thermal/gov_step_wise.c | 22 ++- drivers/thermal/hisi_thermal.c | 11 +- drivers/thermal/imx_thermal.c | 72 +++----- .../int340x_thermal/int340x_thermal_zone.c | 33 ++-- .../int340x_thermal/int340x_thermal_zone.h | 4 +- .../processor_thermal_device.c | 10 +- drivers/thermal/intel/x86_pkg_temp_thermal.c | 120 +++++++------ drivers/thermal/qcom/qcom-spmi-temp-alarm.c | 39 ++--- drivers/thermal/rcar_gen3_thermal.c | 2 +- drivers/thermal/rcar_thermal.c | 53 +----- drivers/thermal/samsung/exynos_tmu.c | 57 +++---- drivers/thermal/st/st_thermal.c | 47 +---- drivers/thermal/tegra/soctherm.c | 33 ++-- drivers/thermal/tegra/tegra30-tsensor.c | 17 +- drivers/thermal/thermal_core.c | 161 +++++++++++++++--- drivers/thermal/thermal_core.h | 24 +-- drivers/thermal/thermal_helpers.c | 28 +-- drivers/thermal/thermal_netlink.c | 21 +-- drivers/thermal/thermal_of.c | 116 ------------- drivers/thermal/thermal_sysfs.c | 133 +++++---------- drivers/thermal/ti-soc-thermal/ti-thermal.h | 15 -- drivers/thermal/uniphier_thermal.c | 27 ++- include/linux/thermal.h | 10 ++ 32 files changed, 560 insertions(+), 818 deletions(-) Reviewed-by: Dmitry Baryshkov Acked-by: Florian Fainelli Acked-by: Rafael J. Wysocki