mbox series

[v8,00/15] dt-bindings: arm: freescale: Switch fsl,scu from txt to yaml

Message ID 20220707125022.1156498-1-viorel.suman@oss.nxp.com
Headers show
Series dt-bindings: arm: freescale: Switch fsl,scu from txt to yaml | expand

Message

Viorel Suman (OSS) July 7, 2022, 12:50 p.m. UTC 
From: Viorel Suman <viorel.suman@nxp.com>

Changes since v7: https://lore.kernel.org/lkml/20220704161541.943696-1-viorel.suman@oss.nxp.com/
  * added missing Reviewed-By: 
  * Defined "mboxes" and "mbox-names" sections in scu-key.yaml as schema.

Changes since v6: https://lore.kernel.org/lkml/20220629164414.301813-1-viorel.suman@oss.nxp.com/
  * The series updated so that each patch making the conversion removes
    the piece being converted, then finally the patch adding fsl,scu.yaml
    removes the last pieces, as suggested by Krzysztof Kozlowski.
  * Updated ocotp and system-controller node names in the existing DTS
    files

Changes since v5: https://lore.kernel.org/lkml/20220616164303.790379-1-viorel.suman@nxp.com/
  * Updated according to Krzysztof Kozlowski comments

Changes since v4: https://lore.kernel.org/lkml/20220615105834.743045-1-viorel.suman@nxp.com/
  * Missing SoB added

Changes since v3: https://lore.kernel.org/lkml/20220609143423.2839186-1-abel.vesa@nxp.com/
  * Examples included
  * Included Abel's patches fixing thermal zone, keys and power controller names.

Abel Vesa (12):
  dt-bindings: clk: imx: Add fsl,scu-clk yaml file
  dt-bindings: pinctrl: imx: Add fsl,scu-iomux yaml file
  dt-bindings: input: Add fsl,scu-key yaml file
  dt-bindings: nvmem: Add fsl,scu-ocotp yaml file
  dt-bindings: power: Add fsl,scu-pd yaml file
  dt-bindings: rtc: Add fsl,scu-rtc yaml file
  dt-bindings: thermal: Add fsl,scu-thermal yaml file
  dt-bindings: watchdog: Add fsl,scu-wdt yaml file
  dt-bindings: firmware: Add fsl,scu yaml file
  arm64: dts: freescale: imx8: Fix power controller name
  arm64: dts: freescale: imx8qxp: Add fallback compatible for clock
    controller
  arm64: dts: freescale: imx8qxp: Fix the keys node name

Viorel Suman (3):
  arm64: dts: freescale: imx8qxp: Remove unnecessary clock related
    entries
  arm64: dts: freescale: imx8qxp: Fix the ocotp node name
  arm64: dts: freescale: imx8: Fix the system-controller node name

 .../bindings/arm/freescale/fsl,scu.txt        | 271 ------------------
 .../bindings/clock/fsl,scu-clk.yaml           |  43 +++
 .../devicetree/bindings/firmware/fsl,scu.yaml | 210 ++++++++++++++
 .../bindings/input/fsl,scu-key.yaml           |  40 +++
 .../bindings/nvmem/fsl,scu-ocotp.yaml         |  56 ++++
 .../bindings/pinctrl/fsl,scu-pinctrl.yaml     |  74 +++++
 .../devicetree/bindings/power/fsl,scu-pd.yaml |  41 +++
 .../devicetree/bindings/rtc/fsl,scu-rtc.yaml  |  31 ++
 .../bindings/thermal/fsl,scu-thermal.yaml     |  38 +++
 .../bindings/watchdog/fsl,scu-wdt.yaml        |  34 +++
 arch/arm64/boot/dts/freescale/imx8qm.dtsi     |   4 +-
 arch/arm64/boot/dts/freescale/imx8qxp.dtsi    |  12 +-
 12 files changed, 574 insertions(+), 280 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
 create mode 100644 Documentation/devicetree/bindings/clock/fsl,scu-clk.yaml
 create mode 100644 Documentation/devicetree/bindings/firmware/fsl,scu.yaml
 create mode 100644 Documentation/devicetree/bindings/input/fsl,scu-key.yaml
 create mode 100644 Documentation/devicetree/bindings/nvmem/fsl,scu-ocotp.yaml
 create mode 100644 Documentation/devicetree/bindings/pinctrl/fsl,scu-pinctrl.yaml
 create mode 100644 Documentation/devicetree/bindings/power/fsl,scu-pd.yaml
 create mode 100644 Documentation/devicetree/bindings/rtc/fsl,scu-rtc.yaml
 create mode 100644 Documentation/devicetree/bindings/thermal/fsl,scu-thermal.yaml
 create mode 100644 Documentation/devicetree/bindings/watchdog/fsl,scu-wdt.yaml

Comments

Shawn Guo July 8, 2022, 12:35 p.m. UTC | #1 
On Thu, Jul 07, 2022 at 03:50:07PM +0300, Viorel Suman (OSS) wrote:
> From: Viorel Suman <viorel.suman@nxp.com>
> 
> Changes since v7: https://lore.kernel.org/lkml/20220704161541.943696-1-viorel.suman@oss.nxp.com/
>   * added missing Reviewed-By: 
>   * Defined "mboxes" and "mbox-names" sections in scu-key.yaml as schema.
> 
> Changes since v6: https://lore.kernel.org/lkml/20220629164414.301813-1-viorel.suman@oss.nxp.com/
>   * The series updated so that each patch making the conversion removes
>     the piece being converted, then finally the patch adding fsl,scu.yaml
>     removes the last pieces, as suggested by Krzysztof Kozlowski.
>   * Updated ocotp and system-controller node names in the existing DTS
>     files
> 
> Changes since v5: https://lore.kernel.org/lkml/20220616164303.790379-1-viorel.suman@nxp.com/
>   * Updated according to Krzysztof Kozlowski comments
> 
> Changes since v4: https://lore.kernel.org/lkml/20220615105834.743045-1-viorel.suman@nxp.com/
>   * Missing SoB added
> 
> Changes since v3: https://lore.kernel.org/lkml/20220609143423.2839186-1-abel.vesa@nxp.com/
>   * Examples included
>   * Included Abel's patches fixing thermal zone, keys and power controller names.
> 
> Abel Vesa (12):
>   dt-bindings: clk: imx: Add fsl,scu-clk yaml file
>   dt-bindings: pinctrl: imx: Add fsl,scu-iomux yaml file
>   dt-bindings: input: Add fsl,scu-key yaml file
>   dt-bindings: nvmem: Add fsl,scu-ocotp yaml file
>   dt-bindings: power: Add fsl,scu-pd yaml file
>   dt-bindings: rtc: Add fsl,scu-rtc yaml file
>   dt-bindings: thermal: Add fsl,scu-thermal yaml file
>   dt-bindings: watchdog: Add fsl,scu-wdt yaml file
>   dt-bindings: firmware: Add fsl,scu yaml file
>   arm64: dts: freescale: imx8: Fix power controller name
>   arm64: dts: freescale: imx8qxp: Add fallback compatible for clock
>     controller
>   arm64: dts: freescale: imx8qxp: Fix the keys node name
> 
> Viorel Suman (3):
>   arm64: dts: freescale: imx8qxp: Remove unnecessary clock related
>     entries
>   arm64: dts: freescale: imx8qxp: Fix the ocotp node name
>   arm64: dts: freescale: imx8: Fix the system-controller node name

I'm preparing material for the next merge window, so just picked the
series up.  If there is more outstanding review comments coming up,
let's address them with follow-up changes.

Shawn
Abel Vesa July 11, 2022, 11:10 a.m. UTC | #2 
On 22-07-07 15:50:08, Viorel Suman (OSS) wrote:
> From: Abel Vesa <abel.vesa@nxp.com>
>
> In order to replace the fsl,scu txt file from bindings/arm/freescale,
> we need to split it between the right subsystems. This patch documents
> separately the 'clock' child node of the SCU main node.
>
> Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
> Signed-off-by: Viorel Suman <viorel.suman@nxp.com>
> Acked-by: Stephen Boyd <sboyd@kernel.org>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Shawn, I'm assuming you're going to pick this up through your tree,
right?

> ---
>  .../bindings/arm/freescale/fsl,scu.txt        | 31 -------------
>  .../bindings/clock/fsl,scu-clk.yaml           | 43 +++++++++++++++++++
>  2 files changed, 43 insertions(+), 31 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/clock/fsl,scu-clk.yaml
>
> diff --git a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> index a87ec15e28d2..ef7f5222ac48 100644
> --- a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> +++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> @@ -79,29 +79,6 @@ Required properties:
>  			See detailed Resource ID list from:
>  			include/dt-bindings/firmware/imx/rsrc.h
>
> -Clock bindings based on SCU Message Protocol
> -------------------------------------------------------------
> -
> -This binding uses the common clock binding[1].
> -
> -Required properties:
> -- compatible:		Should be one of:
> -			  "fsl,imx8dxl-clk"
> -			  "fsl,imx8qm-clk"
> -			  "fsl,imx8qxp-clk"
> -			followed by "fsl,scu-clk"
> -- #clock-cells:		Should be 2.
> -			Contains the Resource and Clock ID value.
> -- clocks:		List of clock specifiers, must contain an entry for
> -			each required entry in clock-names
> -- clock-names:		Should include entries "xtal_32KHz", "xtal_24MHz"
> -
> -The clock consumer should specify the desired clock by having the clock
> -ID in its "clocks" phandle cell.
> -
> -See the full list of clock IDs from:
> -include/dt-bindings/clock/imx8qxp-clock.h
> -
>  Pinctrl bindings based on SCU Message Protocol
>  ------------------------------------------------------------
>
> @@ -127,7 +104,6 @@ Required properties for Pinctrl sub nodes:
>  			Please refer to i.MX8QXP Reference Manual for detailed
>  			CONFIG settings.
>
> -[1] Documentation/devicetree/bindings/clock/clock-bindings.txt
>  [2] Documentation/devicetree/bindings/power/power-domain.yaml
>  [3] Documentation/devicetree/bindings/pinctrl/fsl,imx-pinctrl.txt
>
> @@ -208,11 +184,6 @@ firmware {
>  			  &lsio_mu1 1 3
>  			  &lsio_mu1 3 3>;
>
> -		clk: clk {
> -			compatible = "fsl,imx8qxp-clk", "fsl,scu-clk";
> -			#clock-cells = <2>;
> -		};
> -
>  		iomuxc {
>  			compatible = "fsl,imx8qxp-iomuxc";
>
> @@ -265,7 +236,5 @@ serial@5a060000 {
>  	...
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&pinctrl_lpuart0>;
> -	clocks = <&uart0_clk IMX_SC_R_UART_0 IMX_SC_PM_CLK_PER>;
> -	clock-names = "ipg";
>  	power-domains = <&pd IMX_SC_R_UART_0>;
>  };
> diff --git a/Documentation/devicetree/bindings/clock/fsl,scu-clk.yaml b/Documentation/devicetree/bindings/clock/fsl,scu-clk.yaml
> new file mode 100644
> index 000000000000..f2c48460a399
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/fsl,scu-clk.yaml
> @@ -0,0 +1,43 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/clock/fsl,scu-clk.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: i.MX SCU Client Device Node - Clock bindings based on SCU Message Protocol
> +
> +maintainers:
> +  - Abel Vesa <abel.vesa@nxp.com>
> +
> +description: i.MX SCU Client Device Node
> +  Client nodes are maintained as children of the relevant IMX-SCU device node.
> +  This binding uses the common clock binding.
> +  (Documentation/devicetree/bindings/clock/clock-bindings.txt)
> +  The clock consumer should specify the desired clock by having the clock
> +  ID in its "clocks" phandle cell. See the full list of clock IDs from
> +  include/dt-bindings/clock/imx8qxp-clock.h
> +
> +properties:
> +  compatible:
> +    items:
> +      - enum:
> +          - fsl,imx8dxl-clk
> +          - fsl,imx8qm-clk
> +          - fsl,imx8qxp-clk
> +      - const: fsl,scu-clk
> +
> +  '#clock-cells':
> +    const: 2
> +
> +required:
> +  - compatible
> +  - '#clock-cells'
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    clock-controller {
> +        compatible = "fsl,imx8qxp-clk", "fsl,scu-clk";
> +        #clock-cells = <2>;
> +    };
> --
> 2.25.1
>