| Message ID | 20220511110657.16305-1-j-keerthy@ti.com |
|---|---|
| Headers | show |
| Series | thermal: k3_j72xx_bandgap: Add the bandgap driver support | expand |
Cc'ing krzysztof.kozlowski@linaro.org On 11/05/2022 13:06, Keerthy wrote: > Add VTM bindings documentation. In the Voltage Thermal > Management Module(VTM), K3 J72XX supplies a voltage > reference and a temperature sensor feature that are gathered in the band > gap voltage and temperature sensor (VBGAPTS) module. The band > gap provides current and voltage reference for its internal > circuits and other analog IP blocks. The analog-to-digital > converter (ADC) produces an output value that is proportional > to the silicon temperature. > > Signed-off-by: Keerthy <j-keerthy@ti.com> > --- > .../bindings/thermal/ti,j72xx-thermal.yaml | 64 +++++++++++++++++++ > 1 file changed, 64 insertions(+) > create mode 100644 Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.yaml > > diff --git a/Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.yaml b/Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.yaml > new file mode 100644 > index 000000000000..83f8f444a133 > --- /dev/null > +++ b/Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.yaml > @@ -0,0 +1,64 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/thermal/ti,j72xx-thermal.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Texas Instruments J72XX VTM (DTS) binding > + > +maintainers: > + - Keerthy <j-keerthy@ti.com> > + > +properties: > + compatible: > + items: > + - enum: > + - ti,j721e-vtm > + - ti,j7200-vtm > + > + reg: > + items: > + - description: VTM cfg1 register space > + - description: VTM cfg2 register space > + - description: VTM efuse register space > + > + power-domains: > + maxItems: 1 > + > + "#thermal-sensor-cells": > + const: 1 > + > +required: > + - compatible > + - reg > + - power-domains > + - "#thermal-sensor-cells" > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/soc/ti,sci_pm_domain.h> > + wkup_vtm0: thermal-sensor@42040000 { > + compatible = "ti,j721e-vtm"; > + reg = <0x42040000 0x350>, > + <0x42050000 0x350>, > + <0x43000300 0x10>; > + power-domains = <&k3_pds 154 TI_SCI_PD_EXCLUSIVE>; > + #thermal-sensor-cells = <1>; > + }; > + > + mpu_thermal: mpu-thermal { > + polling-delay-passive = <250>; /* milliseconds */ > + polling-delay = <500>; /* milliseconds */ > + thermal-sensors = <&wkup_vtm0 0>; > + > + trips { > + mpu_crit: mpu-crit { > + temperature = <125000>; /* milliCelsius */ > + hysteresis = <2000>; /* milliCelsius */ > + type = "critical"; > + }; > + }; > + }; > +...
On 16/05/2022 12:32, Daniel Lezcano wrote: > > Cc'ing krzysztof.kozlowski@linaro.org Eh, I wished people used automatically scripts/get_maintainers.pl, so there will be no need to Cc someone. It's actually a bit weird because I was reviewing v6... > > On 11/05/2022 13:06, Keerthy wrote: >> Add VTM bindings documentation. In the Voltage Thermal >> Management Module(VTM), K3 J72XX supplies a voltage >> reference and a temperature sensor feature that are gathered in the band >> gap voltage and temperature sensor (VBGAPTS) module. The band >> gap provides current and voltage reference for its internal >> circuits and other analog IP blocks. The analog-to-digital >> converter (ADC) produces an output value that is proportional >> to the silicon temperature. >> >> Signed-off-by: Keerthy <j-keerthy@ti.com> In any case this misses all the review-tags, so I don't know what we are supposed to do here. Keerthy, Please add Acked-by/Reviewed-by tags when posting new versions. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for acks received on the version they apply. https://elixir.bootlin.com/linux/v5.13/source/Documentation/process/submitting-patches.rst#L543 If a tag was not added on purpose, please state why and what changed. >> --- >> .../bindings/thermal/ti,j72xx-thermal.yaml | 64 +++++++++++++++++++ >> 1 file changed, 64 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.yaml >> >> diff --git a/Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.yaml b/Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.yaml >> new file mode 100644 >> index 000000000000..83f8f444a133 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.yaml >> @@ -0,0 +1,64 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/thermal/ti,j72xx-thermal.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Texas Instruments J72XX VTM (DTS) binding >> + >> +maintainers: >> + - Keerthy <j-keerthy@ti.com> >> + >> +properties: >> + compatible: >> + items: >> + - enum: >> + - ti,j721e-vtm >> + - ti,j7200-vtm No items, you have only one item. Best regards, Krzysztof