| Message ID | 20220412101409.7980-1-j-keerthy@ti.com |
|---|---|
| Headers | show |
| Series | thermal: k3_j72xx_bandgap: Add the bandgap driver support | expand |
On 4/13/2022 3:43 PM, Krzysztof Kozlowski wrote: > On 12/04/2022 12:14, Keerthy wrote: >> Add VTM bindings documentation. In the Voltage Thermal >> Management Module(VTM), K3 J72XX supplies a voltage >> reference and a temperature sensor feature that are gathered in the band >> gap voltage and temperature sensor (VBGAPTS) module. The band >> gap provides current and voltage reference for its internal >> circuits and other analog IP blocks. The analog-to-digital >> converter (ADC) produces an output value that is proportional >> to the silicon temperature. >> >> Signed-off-by: Keerthy <j-keerthy@ti.com> >> --- >> .../bindings/thermal/ti,j72xx-thermal.yaml | 62 +++++++++++++++++++ >> 1 file changed, 62 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.yaml >> >> diff --git a/Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.yaml b/Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.yaml >> new file mode 100644 >> index 000000000000..8483c495cb9a >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.yaml >> @@ -0,0 +1,62 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/thermal/ti,j72xx-thermal.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Texas Instruments J72XX VTM (DTS) binding >> + >> +maintainers: >> + - Keerthy <j-keerthy@ti.com> >> + >> +properties: >> + compatible: >> + const: ti,j721e-vtm >> + oneOf: >> + - enum: >> + - ti,j721e-vtm >> + - ti,j7200-vtm > > It seems you resent this ignoring all of Rob's comments. In changelog of > cover letter you wrote "Fixed all the comments on v4" but it's not true. > Maybe you sent us old patch? > > Anyway, you need to follow Rob's comments. Krzysztof, Apologies. Some issues with my mailbox. Rob's response didn't reach me for some reason. I am now seeing them on the web: https://lore.kernel.org/lkml/YY7HvCyJ90Ge8mr7@robh.at.kernel.org/ It wasn't deliberate to ignore comments. Apologies. I will fix them in v6. Thanks for the quick feedback. - Keerthy > > > Best regards, > Krzysztof
On 13/04/2022 14:04, J, KEERTHY wrote: > Apologies. Some issues with my mailbox. Rob's response didn't reach me > for some reason. > > I am now seeing them on the web: > https://lore.kernel.org/lkml/YY7HvCyJ90Ge8mr7@robh.at.kernel.org/ > > It wasn't deliberate to ignore comments. Apologies. > > I will fix them in v6. Sure :) Best regards, Krzysztof
On Wed, Apr 13, 2022 at 05:34:20PM +0530, J, KEERTHY wrote: > > > On 4/13/2022 3:43 PM, Krzysztof Kozlowski wrote: > > On 12/04/2022 12:14, Keerthy wrote: > > > Add VTM bindings documentation. In the Voltage Thermal > > > Management Module(VTM), K3 J72XX supplies a voltage > > > reference and a temperature sensor feature that are gathered in the band > > > gap voltage and temperature sensor (VBGAPTS) module. The band > > > gap provides current and voltage reference for its internal > > > circuits and other analog IP blocks. The analog-to-digital > > > converter (ADC) produces an output value that is proportional > > > to the silicon temperature. > > > > > > Signed-off-by: Keerthy <j-keerthy@ti.com> > > > --- > > > .../bindings/thermal/ti,j72xx-thermal.yaml | 62 +++++++++++++++++++ > > > 1 file changed, 62 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.yaml > > > > > > diff --git a/Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.yaml b/Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.yaml > > > new file mode 100644 > > > index 000000000000..8483c495cb9a > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.yaml > > > @@ -0,0 +1,62 @@ > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/thermal/ti,j72xx-thermal.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: Texas Instruments J72XX VTM (DTS) binding > > > + > > > +maintainers: > > > + - Keerthy <j-keerthy@ti.com> > > > + > > > +properties: > > > + compatible: > > > + const: ti,j721e-vtm > > > + oneOf: > > > + - enum: > > > + - ti,j721e-vtm > > > + - ti,j7200-vtm > > > > It seems you resent this ignoring all of Rob's comments. In changelog of > > cover letter you wrote "Fixed all the comments on v4" but it's not true. > > Maybe you sent us old patch? > > > > Anyway, you need to follow Rob's comments. > > Krzysztof, > > Apologies. Some issues with my mailbox. Rob's response didn't reach me for > some reason. Maybe because I'm still banned by TI. Just had another bounce a few days ago. Rob