mbox series

[v4,0/4] cpufreq: qcom-hw: Fixes for cpu hotplug support

Message ID 20220326155153.7377-1-dmitry.baryshkov@linaro.org
Headers show
Series cpufreq: qcom-hw: Fixes for cpu hotplug support | expand

Message

Dmitry Baryshkov March 26, 2022, 3:51 p.m. UTC
This patchseries aims at fixing and improving CPU hotplug support on
Qualcomm platforms. First three patches are the fixes for the LMH
support in the cpufreq driver. The last patch adds support for
lightweight offline() and online() callbacks which are used instead of
exit() and init() each time the CPU is put offline or back online.

Patches 1-3 being pure simple fixes can be applied during the -rc
stage, while patch 4 is targeting next development cycle

Changes since v3:
- Readd throttled_freq calculation disappearing from the third patch.

Changes since v2:
- Point Fixes tag from the first patch to the correct commit
- Replace huge patch 2 with one-liner thanks to being able to use
  policy->related_cpus instead of policy->cpus

Changes since v1:
- Update commit message for the first patch to describe why dropping
  affinity hint is required (before calling free_irq()),
- Fixed commit message for the second patch to include messages
  generated using the mainline kernel w/o additional patches,
- Changed third patch to use dev_warn_ratelimited(),
- Reworked last patch to move request_irq/free_irq to online()/offline()
  to make sure that the IRQ isn't left enabled after the CPU has been
  put offline.


Dmitry Baryshkov (4):
  cpufreq: qcom-hw: drop affinity hint before freeing the IRQ
  cpufreq: qcom-hw: fix the race between LMH worker and cpuhp
  cpufreq: qcom-hw: fix the opp entries refcounting
  cpufreq: qcom-hw: provide online/offline operations

 drivers/cpufreq/qcom-cpufreq-hw.c | 45 ++++++++++++++++++++++++++-----
 1 file changed, 38 insertions(+), 7 deletions(-)

Comments

Bjorn Andersson March 31, 2022, 6:34 p.m. UTC | #1
On Sat 26 Mar 08:51 PDT 2022, Dmitry Baryshkov wrote:

> This patchseries aims at fixing and improving CPU hotplug support on
> Qualcomm platforms. First three patches are the fixes for the LMH
> support in the cpufreq driver. The last patch adds support for
> lightweight offline() and online() callbacks which are used instead of
> exit() and init() each time the CPU is put offline or back online.
> 
> Patches 1-3 being pure simple fixes can be applied during the -rc
> stage, while patch 4 is targeting next development cycle
> 

Viresh, please consider picking up patch 1-3 for v5.18-rc.

Thanks,
Bjorn

> Changes since v3:
> - Readd throttled_freq calculation disappearing from the third patch.
> 
> Changes since v2:
> - Point Fixes tag from the first patch to the correct commit
> - Replace huge patch 2 with one-liner thanks to being able to use
>   policy->related_cpus instead of policy->cpus
> 
> Changes since v1:
> - Update commit message for the first patch to describe why dropping
>   affinity hint is required (before calling free_irq()),
> - Fixed commit message for the second patch to include messages
>   generated using the mainline kernel w/o additional patches,
> - Changed third patch to use dev_warn_ratelimited(),
> - Reworked last patch to move request_irq/free_irq to online()/offline()
>   to make sure that the IRQ isn't left enabled after the CPU has been
>   put offline.
> 
> 
> Dmitry Baryshkov (4):
>   cpufreq: qcom-hw: drop affinity hint before freeing the IRQ
>   cpufreq: qcom-hw: fix the race between LMH worker and cpuhp
>   cpufreq: qcom-hw: fix the opp entries refcounting
>   cpufreq: qcom-hw: provide online/offline operations
> 
>  drivers/cpufreq/qcom-cpufreq-hw.c | 45 ++++++++++++++++++++++++++-----
>  1 file changed, 38 insertions(+), 7 deletions(-)
> 
> -- 
> 2.35.1
>
Viresh Kumar April 1, 2022, 2:39 a.m. UTC | #2
On 31-03-22, 11:34, Bjorn Andersson wrote:
> On Sat 26 Mar 08:51 PDT 2022, Dmitry Baryshkov wrote:
> 
> > This patchseries aims at fixing and improving CPU hotplug support on
> > Qualcomm platforms. First three patches are the fixes for the LMH
> > support in the cpufreq driver. The last patch adds support for
> > lightweight offline() and online() callbacks which are used instead of
> > exit() and init() each time the CPU is put offline or back online.
> > 
> > Patches 1-3 being pure simple fixes can be applied during the -rc
> > stage, while patch 4 is targeting next development cycle
> > 
> 
> Viresh, please consider picking up patch 1-3 for v5.18-rc.

Applied. Thanks.