From patchwork Sat Jul 10 10:38:16 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adrian Hunter X-Patchwork-Id: 472556 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B93CFC07E95 for ; Sat, 10 Jul 2021 10:38:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9694B613DA for ; Sat, 10 Jul 2021 10:38:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232469AbhGJKk5 (ORCPT ); Sat, 10 Jul 2021 06:40:57 -0400 Received: from mga14.intel.com ([192.55.52.115]:34009 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232387AbhGJKk4 (ORCPT ); Sat, 10 Jul 2021 06:40:56 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10040"; a="209638432" X-IronPort-AV: E=Sophos;i="5.84,229,1620716400"; d="scan'208";a="209638432" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jul 2021 03:38:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,229,1620716400"; d="scan'208";a="429090400" Received: from ahunter-desktop.fi.intel.com ([10.237.72.79]) by orsmga002.jf.intel.com with ESMTP; 10 Jul 2021 03:38:06 -0700 From: Adrian Hunter To: "Rafael J . Wysocki" Cc: Greg Kroah-Hartman , Saravana Kannan , "Martin K . Petersen" , "James E . J . Bottomley" , linux-scsi@vger.kernel.org, Avri Altman , Bean Huo , Can Guo , Asutosh Das , Bart Van Assche , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 0/3] driver core: Add ability to delete device links of unregistered devices Date: Sat, 10 Jul 2021 13:38:16 +0300 Message-Id: <20210710103819.12532-1-adrian.hunter@intel.com> X-Mailer: git-send-email 2.17.1 Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Hi There is an issue with the SCSI UFS driver when the optional BOOT well-known LUN fails to probe, which is not a fatal error. The issue is that the device and its "managed" device link do not then get deleted. The device because the device link has a reference to it. The device link because it can only be deleted by device_del(), but device_add() was never called, so device_del() never will be either. Since V2, these patches fix the issue by amending device link removal to accept removal of a link with an unregistered consumer device, as suggested by Rafael. Changes in V3: driver core: Prevent warning when removing a device link from unregistered consumer New patch split from "driver core: Add ability to delete device links of unregistered devices" except first chunk from that patch dropped as unnecessary driver core: Add ability to delete device links of unregistered devices Move warning fix to separate patch. Changes in V2: Take approach suggested by Rafael Adrian Hunter (3): driver core: Prevent warning when removing a device link from unregistered consumer driver core: Add ability to delete device links of unregistered devices scsi: ufshcd: Fix device links when BOOT WLUN fails to probe drivers/base/core.c | 8 ++++++-- drivers/scsi/ufs/ufshcd.c | 23 +++++++++++++++++++++-- 2 files changed, 27 insertions(+), 4 deletions(-) Regards Adrian Reviewed-by: Rafael J. Wysocki