From patchwork Mon Jun 14 18:58:12 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lukasz Luba X-Patchwork-Id: 460852 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B977C2B9F4 for ; Mon, 14 Jun 2021 18:58:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4654261245 for ; Mon, 14 Jun 2021 18:58:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232864AbhFNTAe (ORCPT ); Mon, 14 Jun 2021 15:00:34 -0400 Received: from foss.arm.com ([217.140.110.172]:43950 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232745AbhFNTAe (ORCPT ); Mon, 14 Jun 2021 15:00:34 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 03C4C113E; Mon, 14 Jun 2021 11:58:31 -0700 (PDT) Received: from e123648.arm.com (unknown [10.57.5.127]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 430943F694; Mon, 14 Jun 2021 11:58:27 -0700 (PDT) From: Lukasz Luba To: linux-kernel@vger.kernel.org Cc: linux-pm@vger.kernel.org, peterz@infradead.org, rjw@rjwysocki.net, viresh.kumar@linaro.org, vincent.guittot@linaro.org, qperret@google.com, dietmar.eggemann@arm.com, vincent.donnefort@arm.com, lukasz.luba@arm.com, Beata.Michalska@arm.com, mingo@redhat.com, juri.lelli@redhat.com, rostedt@goodmis.org, segall@google.com, mgorman@suse.de, bristot@redhat.com, thara.gopinath@linaro.org, amit.kachhap@gmail.com, amitk@kernel.org, rui.zhang@intel.com, daniel.lezcano@linaro.org Subject: [PATCH v4 0/3] Add allowed CPU capacity knowledge to EAS Date: Mon, 14 Jun 2021 19:58:12 +0100 Message-Id: <20210614185815.15136-1-lukasz.luba@arm.com> X-Mailer: git-send-email 2.17.1 Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Hi all, The patch set v4 aims to add knowledge about reduced CPU capacity into the Energy Model (EM) and Energy Aware Scheduler (EAS). Currently the issue is that SchedUtil CPU frequency and EM frequency are not aligned, when there is a CPU thermal capping. This causes an estimation error. This patch set provides the information about allowed CPU capacity into the EM (thanks to thermal pressure information). This improves the energy estimation. More info about this mechanism can be found in the patches description. Changelog: v4: - removed local variable and improved description in patch 2/3 - added Reviewed-by from Vincent for patch 2/3 - added Acked-by from Viresh for patch 1/3 v3 [3]: - switched to 'raw' per-cpu thermal pressure instead of thermal pressure geometric series signal, since it more suited for purpose of this use case: predicting SchedUtil frequency (Vincent, Dietmar) - added more comment in the patch 2/3 header for use case when thermal capping might be applied even the CPUs are not over-utilized (Dietmar) - added ACK tag from Rafael for SchedUtil part - added a fix patch for offline CPUs in cpufreq_cooling and per-cpu thermal_pressure missing update v2 [2]: - clamp the returned value from effective_cpu_util() and avoid irq util scaling issues (Quentin) v1 is available at [1] Regards, Lukasz [1] https://lore.kernel.org/linux-pm/20210602135609.10867-1-lukasz.luba@arm.com/ [2] https://lore.kernel.org/lkml/20210604080954.13915-1-lukasz.luba@arm.com/ [3] https://lore.kernel.org/lkml/20210610150324.22919-1-lukasz.luba@arm.com/ Lukasz Luba (3): thermal: cpufreq_cooling: Update also offline CPUs per-cpu thermal_pressure sched/fair: Take thermal pressure into account while estimating energy sched/cpufreq: Consider reduced CPU capacity in energy calculation drivers/thermal/cpufreq_cooling.c | 2 +- include/linux/energy_model.h | 16 +++++++++++++--- include/linux/sched/cpufreq.h | 2 +- kernel/sched/cpufreq_schedutil.c | 1 + kernel/sched/fair.c | 13 +++++++++---- 5 files changed, 25 insertions(+), 9 deletions(-)