mbox series

[v1,0/2] NVIDIA Tegra core power domain follow up

Message ID 20210601231003.9845-1-digetx@gmail.com
Headers show
Series NVIDIA Tegra core power domain follow up | expand

Message

Dmitry Osipenko June 1, 2021, 11:10 p.m. UTC 
Remove the lockdep_set_class(), which Ulf Hansson asked for. And
prevent core domain syncing if domain node is missing in device-tree,
which I accidentally missed to add after squashing the standalone
domain driver into the PMC driver.

Dmitry Osipenko (2):
  soc/tegra: pmc: Don't sync core domain if it's missing in device-tree
  soc/tegra: pmc: Remove usage of lockdep_set_class()

 drivers/soc/tegra/pmc.c | 21 +++++++++++----------
 1 file changed, 11 insertions(+), 10 deletions(-)

Comments

Ulf Hansson June 2, 2021, 7:38 a.m. UTC | #1 
On Wed, 2 Jun 2021 at 01:10, Dmitry Osipenko <digetx@gmail.com> wrote:
>

> Remove the lockdep_set_class(), which Ulf Hansson asked for. And

> prevent core domain syncing if domain node is missing in device-tree,

> which I accidentally missed to add after squashing the standalone

> domain driver into the PMC driver.

>

> Dmitry Osipenko (2):

>   soc/tegra: pmc: Don't sync core domain if it's missing in device-tree

>   soc/tegra: pmc: Remove usage of lockdep_set_class()

>

>  drivers/soc/tegra/pmc.c | 21 +++++++++++----------

>  1 file changed, 11 insertions(+), 10 deletions(-)

>


Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>


Kind regards
Uffe
Thierry Reding June 2, 2021, 9:10 a.m. UTC | #2 
On Wed, Jun 02, 2021 at 02:10:01AM +0300, Dmitry Osipenko wrote:
> Remove the lockdep_set_class(), which Ulf Hansson asked for. And

> prevent core domain syncing if domain node is missing in device-tree,

> which I accidentally missed to add after squashing the standalone

> domain driver into the PMC driver.

> 

> Dmitry Osipenko (2):

>   soc/tegra: pmc: Don't sync core domain if it's missing in device-tree

>   soc/tegra: pmc: Remove usage of lockdep_set_class()

> 

>  drivers/soc/tegra/pmc.c | 21 +++++++++++----------

>  1 file changed, 11 insertions(+), 10 deletions(-)


I've squashed these into the corresponding patches of you v6 series and
added Ulf's reviewed-by to them.

Ulf, let me know if I misinterpreted the discussion and your reviewed-by
didn't extend to the original patches.

Thierry
Ulf Hansson June 2, 2021, 10 a.m. UTC | #3 
On Wed, 2 Jun 2021 at 11:08, Thierry Reding <thierry.reding@gmail.com> wrote:
>

> On Wed, Jun 02, 2021 at 02:10:01AM +0300, Dmitry Osipenko wrote:

> > Remove the lockdep_set_class(), which Ulf Hansson asked for. And

> > prevent core domain syncing if domain node is missing in device-tree,

> > which I accidentally missed to add after squashing the standalone

> > domain driver into the PMC driver.

> >

> > Dmitry Osipenko (2):

> >   soc/tegra: pmc: Don't sync core domain if it's missing in device-tree

> >   soc/tegra: pmc: Remove usage of lockdep_set_class()

> >

> >  drivers/soc/tegra/pmc.c | 21 +++++++++++----------

> >  1 file changed, 11 insertions(+), 10 deletions(-)

>

> I've squashed these into the corresponding patches of you v6 series and

> added Ulf's reviewed-by to them.

>

> Ulf, let me know if I misinterpreted the discussion and your reviewed-by

> didn't extend to the original patches.


Nope, looks good to me! Thanks!

Kind regards
Uffe