| Message ID | 20210309000530.2165752-1-luzmaximilian@gmail.com |
|---|---|
| Headers | show |
| Series | power: supply: Add battery and AC drivers for Surface devices | expand |
Hi, On 3/9/21 1:05 AM, Maximilian Luz wrote: > This series provides battery and AC drivers for Microsoft Surface > devices, where this information is provided via an embedded controller > (the Surface System Aggregator Module, SSAM) instead of the usual ACPI > interface. > > Specifically, 7th generation Surface devices, i.e. Surface Pro 7, > Surface Book 3, Surface Laptop 3, as well as the Surface Laptop Go use > this new interface. > > Note: This series depends on the > > platform/surface: Add Surface Aggregator device registry > > series. More specifically patch > > platform/surface: Set up Surface Aggregator device registry > > The full series has been merged into the for-next branch of the > platform-drivers-x86 tree [1]. The commit in question can be found at > [2]. > > [1]: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=for-next > [2]: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/commit/?h=for-next&id=fc622b3d36e6d91330fb21506b9ad1e3206a4dde Sebastian, I guess you want a pull-req from an immutable branch from me for that dependend commit and then you will merge these 2 patches ? Maximillian, this only needs that commit right, or would it be better if I send Sebastian a pull-req for a branch with the entire series? Regards, Hans > > Maximilian Luz (2): > power: supply: Add battery driver for Surface Aggregator Module > power: supply: Add AC driver for Surface Aggregator Module > > MAINTAINERS | 8 + > drivers/power/supply/Kconfig | 32 + > drivers/power/supply/Makefile | 2 + > drivers/power/supply/surface_battery.c | 901 +++++++++++++++++++++++++ > drivers/power/supply/surface_charger.c | 296 ++++++++ > 5 files changed, 1239 insertions(+) > create mode 100644 drivers/power/supply/surface_battery.c > create mode 100644 drivers/power/supply/surface_charger.c >
On 3/17/21 6:39 PM, Hans de Goede wrote: > Hi, > > On 3/9/21 1:05 AM, Maximilian Luz wrote: >> This series provides battery and AC drivers for Microsoft Surface >> devices, where this information is provided via an embedded controller >> (the Surface System Aggregator Module, SSAM) instead of the usual ACPI >> interface. >> >> Specifically, 7th generation Surface devices, i.e. Surface Pro 7, >> Surface Book 3, Surface Laptop 3, as well as the Surface Laptop Go use >> this new interface. >> >> Note: This series depends on the >> >> platform/surface: Add Surface Aggregator device registry >> >> series. More specifically patch >> >> platform/surface: Set up Surface Aggregator device registry >> >> The full series has been merged into the for-next branch of the >> platform-drivers-x86 tree [1]. The commit in question can be found at >> [2]. >> >> [1]: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=for-next >> [2]: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/commit/?h=for-next&id=fc622b3d36e6d91330fb21506b9ad1e3206a4dde > > Sebastian, I guess you want a pull-req from an immutable branch from me for > that dependend commit and then you will merge these 2 patches ? > > Maximillian, this only needs that commit right, or would it be better if > I send Sebastian a pull-req for a branch with the entire series? The entire series would be better, I think. Strictly speaking, it only requires the mentioned commit to compile successfully, but if anyone would want to test this they'd need the full series (or at least the battery/power subsystem commit) due to the device instantiation. Same reasoning applies to the HID series. Thanks, Max
Hi, On 3/17/21 6:47 PM, Maximilian Luz wrote: > On 3/17/21 6:39 PM, Hans de Goede wrote: >> Hi, >> >> On 3/9/21 1:05 AM, Maximilian Luz wrote: >>> This series provides battery and AC drivers for Microsoft Surface >>> devices, where this information is provided via an embedded controller >>> (the Surface System Aggregator Module, SSAM) instead of the usual ACPI >>> interface. >>> >>> Specifically, 7th generation Surface devices, i.e. Surface Pro 7, >>> Surface Book 3, Surface Laptop 3, as well as the Surface Laptop Go use >>> this new interface. >>> >>> Note: This series depends on the >>> >>> platform/surface: Add Surface Aggregator device registry >>> >>> series. More specifically patch >>> >>> platform/surface: Set up Surface Aggregator device registry >>> >>> The full series has been merged into the for-next branch of the >>> platform-drivers-x86 tree [1]. The commit in question can be found at >>> [2]. >>> >>> [1]: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=for-next >>> [2]: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/commit/?h=for-next&id=fc622b3d36e6d91330fb21506b9ad1e3206a4dde >> >> Sebastian, I guess you want a pull-req from an immutable branch from me for >> that dependend commit and then you will merge these 2 patches ? >> >> Maximillian, this only needs that commit right, or would it be better if >> I send Sebastian a pull-req for a branch with the entire series? > > The entire series would be better, I think. > > Strictly speaking, it only requires the mentioned commit to compile > successfully, but if anyone would want to test this they'd need the full > series (or at least the battery/power subsystem commit) due to the > device instantiation. Ack, I think the whole series makes the most sense too, so I will prepare a pull-req for that. > Same reasoning applies to the HID series. Ack. Regards, Hans
On 3/9/21 1:05 AM, Maximilian Luz wrote: > This series provides battery and AC drivers for Microsoft Surface > devices, where this information is provided via an embedded controller > (the Surface System Aggregator Module, SSAM) instead of the usual ACPI > interface. > > Specifically, 7th generation Surface devices, i.e. Surface Pro 7, > Surface Book 3, Surface Laptop 3, as well as the Surface Laptop Go use > this new interface. > > Note: This series depends on the > > platform/surface: Add Surface Aggregator device registry > > series. More specifically patch > > platform/surface: Set up Surface Aggregator device registry > > The full series has been merged into the for-next branch of the > platform-drivers-x86 tree [1]. The commit in question can be found at > [2]. > > [1]: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=for-next > [2]: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/commit/?h=for-next&id=fc622b3d36e6d91330fb21506b9ad1e3206a4dde > > Maximilian Luz (2): > power: supply: Add battery driver for Surface Aggregator Module > power: supply: Add AC driver for Surface Aggregator Module > > MAINTAINERS | 8 + > drivers/power/supply/Kconfig | 32 + > drivers/power/supply/Makefile | 2 + > drivers/power/supply/surface_battery.c | 901 +++++++++++++++++++++++++ > drivers/power/supply/surface_charger.c | 296 ++++++++ > 5 files changed, 1239 insertions(+) > create mode 100644 drivers/power/supply/surface_battery.c > create mode 100644 drivers/power/supply/surface_charger.c > Hi, is there any status update on this? Regards, Max
This series provides battery and AC drivers for Microsoft Surface devices, where this information is provided via an embedded controller (the Surface System Aggregator Module, SSAM) instead of the usual ACPI interface. Specifically, 7th generation Surface devices, i.e. Surface Pro 7, Surface Book 3, Surface Laptop 3, as well as the Surface Laptop Go use this new interface. Note: This series depends on the platform/surface: Add Surface Aggregator device registry series. More specifically patch platform/surface: Set up Surface Aggregator device registry The full series has been merged into the for-next branch of the platform-drivers-x86 tree [1]. The commit in question can be found at [2]. [1]: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=for-next [2]: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/commit/?h=for-next&id=fc622b3d36e6d91330fb21506b9ad1e3206a4dde Maximilian Luz (2): power: supply: Add battery driver for Surface Aggregator Module power: supply: Add AC driver for Surface Aggregator Module MAINTAINERS | 8 + drivers/power/supply/Kconfig | 32 + drivers/power/supply/Makefile | 2 + drivers/power/supply/surface_battery.c | 901 +++++++++++++++++++++++++ drivers/power/supply/surface_charger.c | 296 ++++++++ 5 files changed, 1239 insertions(+) create mode 100644 drivers/power/supply/surface_battery.c create mode 100644 drivers/power/supply/surface_charger.c