| Message ID | 20210120015010.14191-1-digetx@gmail.com |
|---|---|
| Headers | show |
| Series | GENPD API improvements | expand |
On Wed, 20 Jan 2021 at 05:39, Viresh Kumar <viresh.kumar@linaro.org> wrote: > > On 20-01-21, 04:50, Dmitry Osipenko wrote: > > Make set_performance_state() callback optional in order to remove the > > need from power domain drivers to implement a dummy callback. If callback > > isn't implemented by a GENPD driver, then the performance state is passed > > to the parent domain. > > > > Tested-by: Peter Geis <pgwipeout@gmail.com> > > Tested-by: Nicolas Chauvet <kwizart@gmail.com> > > Tested-by: Matt Merhar <mattmerhar@protonmail.com> > > [tested on NVIDIA Tegra20/30/124 SoCs] > > Suggested-by: Ulf Hansson <ulf.hansson@linaro.org> > > Signed-off-by: Dmitry Osipenko <digetx@gmail.com> > > --- > > drivers/base/power/domain.c | 33 ++++++++++++++++++--------------- > > 1 file changed, 18 insertions(+), 15 deletions(-) > > > > diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c > > index 9a14eedacb92..0bd0cdc30393 100644 > > --- a/drivers/base/power/domain.c > > +++ b/drivers/base/power/domain.c > > @@ -297,6 +297,18 @@ static int _genpd_reeval_performance_state(struct generic_pm_domain *genpd, > > return state; > > } > > > > +static int _genpd_xlate_performance_state(struct generic_pm_domain *src_genpd, > > + struct generic_pm_domain *dst_genpd, > > + unsigned int pstate) > > I would name them as genpd and parent, that makes it more readable for it. ... and while at it, probably also drop the "_" as the prefix of the function name. Other than that, please add: Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org> Kind regards Uffe
Hi, This is a continuation of [1], where Ulf Hansson suggested to factor out GENPD patches into a separate series. This series is a prerequisite for the power domain driver of NVIDIA Tegra SoCs. [1] https://patchwork.ozlabs.org/project/linux-tegra/list/?series=221130 Changelog: v4: - Updated the "Make set_performance_state() callback optional" patch. Now the case where one of intermediate domains doesn't implement the set_performance_state() callback is handled properly, thanks to Viresh and Ulf for catching this drawback and suggesting the fix. - Added more r-bs from Ulf Hansson and Viresh Kumar. v3: - Added r-b from Ulf Hansson. - Added new patch "Make of_genpd_add_subdomain() to return -EPROBE_DEFER", which was suggested by Ulf Hansson. - Improved "Add "performance" column to debug summary" patch by correcting the formatting of debug output, which had a superfluous whitespace. Dmitry Osipenko (3): PM: domains: Make set_performance_state() callback optional PM: domains: Make of_genpd_add_subdomain() to return -EPROBE_DEFER PM: domains: Add "performance" column to debug summary drivers/base/power/domain.c | 54 +++++++++++++++++++++++-------------- 1 file changed, 34 insertions(+), 20 deletions(-)