From patchwork Fri Mar 9 21:09:51 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Georgi Djakov X-Patchwork-Id: 131248 Delivered-To: patch@linaro.org Received: by 10.46.66.2 with SMTP id p2csp1455383lja; Fri, 9 Mar 2018 13:10:05 -0800 (PST) X-Google-Smtp-Source: AG47ELs5I0fm+oZl04jaAenQFTup9C52JFgru+Bn/Qu65oPd4T6uUF+7aN9wsd4vpgVzLb1UuSz3 X-Received: by 10.98.238.2 with SMTP id e2mr31383070pfi.68.1520629805223; Fri, 09 Mar 2018 13:10:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520629805; cv=none; d=google.com; s=arc-20160816; b=AdAn+3wijt3I9ZL/iMDYv+jDQQqf5Ayizi+95j9K+j059kHNCBAJXVqzxlu1La2dkH k4Bb8HXhMs1s4QLO5ajoQ15HW8Iz8i3eKry8JTNKIUaVGsIIzj8JF9J6fwga97w7ZRcw +aKviN/QH6cdsq4F8r1KLysTy4p+PrbSTvhFhVAj1lMXoDYQuixeWlz+IbHrWTPGyD1x 4dPhHsLtyy9RlF7pDKCBmZEzz60gBbo2cY71EWj5UoAq04ydSDWv+ztW2bg/jbtN4Nff nJRwq370mQNssOcuYCkOOx76IJrVjC6clGOqE//IRxVXS7GNX5SLfdW4jEFS9BM7qPA2 fBqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=c2tTM+18yJuLazLFw8tp9zidIdNr8+QuQ2lRk4Q3kMw=; b=E4doETbhhfupwOL2VHaWDWxkuUvNhcRktXipn3vuJd+31+geoCVPq37bt4D05rbml2 G6NuA0RxCltwBQhUB1N1m/UuevIeGWUzv/mevAjCH2xqbT93UM+SFjPf810aX7zHMPqX 8EVgs7q9kz2M5sef7KDWpNV7cgJ1E9gwmWewEWk4qEdii1Wmfm6gFwhDgNih/WZEsSya nv8J6lpWIlAKKbKYI4vFgkDubE/mmzLrRiask4wPu4c/uIKOz0k4R8aFJ1q7jdvcGlhU QXycYbun3pBZd9z5POaK8OdXdJnCUH1bOthmSdy4eU2Gf5eMtr5s6/z+/HLEfTWWSPb9 T2/g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ItiOOHGY; spf=pass (google.com: best guess record for domain of linux-pm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-pm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u23-v6si1548667plk.116.2018.03.09.13.10.04; Fri, 09 Mar 2018 13:10:05 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-pm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ItiOOHGY; spf=pass (google.com: best guess record for domain of linux-pm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-pm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932337AbeCIVKD (ORCPT + 11 others); Fri, 9 Mar 2018 16:10:03 -0500 Received: from mail-wr0-f181.google.com ([209.85.128.181]:44073 "EHLO mail-wr0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932327AbeCIVKC (ORCPT ); Fri, 9 Mar 2018 16:10:02 -0500 Received: by mail-wr0-f181.google.com with SMTP id v65so10246734wrc.11 for ; Fri, 09 Mar 2018 13:10:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=c2tTM+18yJuLazLFw8tp9zidIdNr8+QuQ2lRk4Q3kMw=; b=ItiOOHGYxe/gk8vYu0eQdIKosGBCgC09TjVLOFYYqAQ0Hb/jPYoQp86meYh0xVwpcV uRjsthdQvoQtob43ai1TM4B/hVu5Nv8gOI56DkhgDEX4n3zfD83rr4bWM6MG0freTWfj e8nTLPVikfU1VbfHwHFyLJWu2/7bBssh7vzjk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=c2tTM+18yJuLazLFw8tp9zidIdNr8+QuQ2lRk4Q3kMw=; b=ebm9pc3TFC1QaFcFNSnXK6NRUexQqLJ3JmyK1H0jw335bHpq1/QerSNTAEWxCvbgrX g5N0Sd5P7y8yVDIo4jSExEzx5NBm9ZJPzlJcVcClYfJPMJOvL9b6sRZLjaowHYScUzbL tlUAi/aH+o65rP82W93vJPHpLiKgQ9KE0OahwC9JUx0m0FbYfqOP0kdX9IrNAmthhFLU JQUMoIdr+O6OJmh3bTjAiSnN5bYZ2VqRtj0Hx9TnMC5EMtP6pX+yRL5Ukvd6lWLAfbge KZVCxcCMxADNUoh/mv1GQzAgaURE0j3hVmPLKWdeSBquwvUx5eT9LUVjV3DhpembXc+O arLw== X-Gm-Message-State: APf1xPArKGk8C39defsyc9YekXLQ5ALWnoRWu4fT4qDJJjW+gK5WtcIq /STukf8puOnEDygY7uzL9yw4TeZk9AA= X-Received: by 10.223.175.44 with SMTP id z41mr25521217wrc.129.1520629800864; Fri, 09 Mar 2018 13:10:00 -0800 (PST) Received: from mms-0441.qualcomm.mm-sol.com ([212.45.67.2]) by smtp.googlemail.com with ESMTPSA id g7sm1853118wrb.78.2018.03.09.13.09.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 09 Mar 2018 13:10:00 -0800 (PST) From: Georgi Djakov To: linux-pm@vger.kernel.org, gregkh@linuxfoundation.org Cc: rjw@rjwysocki.net, robh+dt@kernel.org, mturquette@baylibre.com, khilman@baylibre.com, vincent.guittot@linaro.org, skannan@codeaurora.org, bjorn.andersson@linaro.org, amit.kucheria@linaro.org, seansw@qti.qualcomm.com, davidai@quicinc.com, mark.rutland@arm.com, lorenzo.pieralisi@arm.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, georgi.djakov@linaro.org Subject: [PATCH v4 0/7] Introduce on-chip interconnect API Date: Fri, 9 Mar 2018 23:09:51 +0200 Message-Id: <20180309210958.16672-1-georgi.djakov@linaro.org> X-Mailer: git-send-email 2.16.2 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Modern SoCs have multiple processors and various dedicated cores (video, gpu, graphics, modem). These cores are talking to each other and can generate a lot of data flowing through the on-chip interconnects. These interconnect buses could form different topologies such as crossbar, point to point buses, hierarchical buses or use the network-on-chip concept. These buses have been sized usually to handle use cases with high data throughput but it is not necessary all the time and consume a lot of power. Furthermore, the priority between masters can vary depending on the running use case like video playback or cpu intensive tasks. Having an API to control the requirement of the system in term of bandwidth and QoS, so we can adapt the interconnect configuration to match those by scaling the frequencies, setting link priority and tuning QoS parameters. This configuration can be a static, one-time operation done at boot for some platforms or a dynamic set of operations that happen at run-time. This patchset introduce a new API to get the requirement and configure the interconnect buses across the entire chipset to fit with the current demand. The API is NOT for changing the performance of the endpoint devices, but only the interconnect path in between them. The API is using a consumer/provider-based model, where the providers are the interconnect buses and the consumers could be various drivers. The consumers request interconnect resources (path) to an endpoint and set the desired constraints on this data flow path. The provider(s) receive requests from consumers and aggregate these requests for all master-slave pairs on that path. Then the providers configure each participating in the topology node according to the requested data flow path, physical links and constraints. The topology could be complicated and multi-tiered and is SoC specific. Below is a simplified diagram of a real-world SoC topology. The interconnect providers are the NoCs. +----------------+ +----------------+ | HW Accelerator |--->| M NoC |<---------------+ +----------------+ +----------------+ | | | +------------+ +-----+ +-------------+ V +------+ | | | DDR | | +--------+ | PCIe | | | +-----+ | | Slaves | +------+ | | ^ ^ | +--------+ | | C NoC | | | V V | | +------------------+ +------------------------+ | | +-----+ | |-->| |-->| |-->| CPU | | |-->| |<--| | +-----+ | Mem NoC | | S NoC | +------------+ | |<--| |---------+ | | |<--| |<------+ | | +--------+ +------------------+ +------------------------+ | | +-->| Slaves | ^ ^ ^ ^ ^ | | +--------+ | | | | | | V +------+ | +-----+ +-----+ +---------+ +----------------+ +--------+ | CPUs | | | GPU | | DSP | | Masters |-->| P NoC |-->| Slaves | +------+ | +-----+ +-----+ +---------+ +----------------+ +--------+ | +-------+ | Modem | +-------+ TODO: * Create icc_set_extended() to handle parameters such as latency and other QoS values. * Convert from using global node identifiers to local per provider identifiers. * Cache the path between the nodes instead of walking the graph on each get(). * Sync interconnect requests with the idle state of the device. Changes since patchset v3 (https://lkml.org/lkml/2017/9/8/544) * Refactored the constraints aggregation. * Use the IDR API. * Split the provider and consumer bindings into separate patches and propose new bindings for consumers, which allows to specify the local source port. * Adopted the icc_ prefix for API functions. * Introduced separate API functions for creating interconnect nodes and links. * Added DT lookup support in addition to platform data. * Dropped the event tracing patch for now. * Added a patch to provide summary via debugfs. * Use macro for the list of topology definitions in the platform driver. * Various minor changes. Changes since patchset v2 (https://lkml.org/lkml/2017/7/20/825) * Split the aggregation into per node and per provider. Cache the aggregated values. * Various small refactorings and cleanups in the framework. * Added a patch introducing basic tracepoint support for monitoring the time required to update the interconnect nodes. Changes since patchset v1 (https://lkml.org/lkml/2017/6/27/890) * Updates in the documentation. * Changes in request aggregation, locking. * Dropped the aggregate() callback and use the default as it currently sufficient for the single vendor driver. Will add it later when needed. * Dropped the dt-bindings draft patch for now. Changes since RFC v2 (https://lkml.org/lkml/2017/6/12/316) * Converted documentation to rst format. * Fixed an incorrect call to mutex_lock. Renamed max_bw to peak_bw. Changes since RFC v1 (https://lkml.org/lkml/2017/5/15/605) * Refactored code into shorter functions. * Added a new aggregate() API function. * Rearranged some structs to reduce padding bytes. Changes since RFC v0 (https://lkml.org/lkml/2017/3/1/599) * Removed DT support and added optional Patch 3 with new bindings proposal. * Converted the topology into internal driver data. * Made the framework modular. * interconnect_get() now takes (src and dst ports as arguments). * Removed public declarations of some structs. * Now passing prev/next nodes to the vendor driver. * Properly remove requests on _put(). * Added refcounting. * Updated documentation. * Changed struct interconnect_path to use array instead of linked list. Georgi Djakov (7): interconnect: Add generic on-chip interconnect API dt-bindings: Introduce interconnect provider bindings interconnect: Add debugfs support interconnect: qcom: Add RPM communication interconnect: qcom: Add msm8916 interconnect provider driver dt-bindings: Introduce interconnect consumers bindings interconnect: Allow endpoints translation via DT .../bindings/interconnect/interconnect.txt | 70 +++ .../devicetree/bindings/interconnect/qcom-smd.txt | 31 ++ Documentation/interconnect/interconnect.rst | 96 ++++ drivers/Kconfig | 2 + drivers/Makefile | 1 + drivers/interconnect/Kconfig | 15 + drivers/interconnect/Makefile | 2 + drivers/interconnect/core.c | 597 +++++++++++++++++++++ drivers/interconnect/qcom/Kconfig | 11 + drivers/interconnect/qcom/Makefile | 3 + drivers/interconnect/qcom/msm8916.c | 482 +++++++++++++++++ drivers/interconnect/qcom/smd-rpm.c | 90 ++++ drivers/interconnect/qcom/smd-rpm.h | 15 + include/linux/interconnect-provider.h | 109 ++++ include/linux/interconnect.h | 46 ++ include/linux/interconnect/qcom.h | 350 ++++++++++++ 16 files changed, 1920 insertions(+) create mode 100644 Documentation/devicetree/bindings/interconnect/interconnect.txt create mode 100644 Documentation/devicetree/bindings/interconnect/qcom-smd.txt create mode 100644 Documentation/interconnect/interconnect.rst create mode 100644 drivers/interconnect/Kconfig create mode 100644 drivers/interconnect/Makefile create mode 100644 drivers/interconnect/core.c create mode 100644 drivers/interconnect/qcom/Kconfig create mode 100644 drivers/interconnect/qcom/Makefile create mode 100644 drivers/interconnect/qcom/msm8916.c create mode 100644 drivers/interconnect/qcom/smd-rpm.c create mode 100644 drivers/interconnect/qcom/smd-rpm.h create mode 100644 include/linux/interconnect-provider.h create mode 100644 include/linux/interconnect.h create mode 100644 include/linux/interconnect/qcom.h