@@ -7,6 +7,7 @@
* Denis Ciocca <denis.ciocca@st.com>
*/
+#include <linux/bitfield.h>
#include <linux/kernel.h>
#include <linux/module.h>
#include <linux/slab.h>
@@ -26,8 +27,8 @@ int st_sensors_write_data_with_mask(struct iio_dev *indio_dev,
{
struct st_sensor_data *sdata = iio_priv(indio_dev);
- return regmap_update_bits(sdata->regmap,
- reg_addr, mask, data << __ffs(mask));
+ return regmap_update_bits(sdata->regmap, reg_addr, mask,
+ field_prep(mask, data));
}
int st_sensors_debugfs_reg_access(struct iio_dev *indio_dev,
Use the field_prep() helper, instead of open-coding the same operation. Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- Compile-tested only. Marked RFC, as this depends on [PATCH 01/17], but follows a different path to upstream. --- drivers/iio/common/st_sensors/st_sensors_core.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)