From patchwork Wed Jan 31 05:06:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuninori Morimoto X-Patchwork-Id: 768730 Received: from JPN01-TYC-obe.outbound.protection.outlook.com (mail-tycjpn01on2122.outbound.protection.outlook.com [40.107.114.122]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E41AB3EA97; Wed, 31 Jan 2024 05:06:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.114.122 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706677582; cv=fail; b=N9Eyq1eiMOQn/q40vVKfZjc9By8vc/5wLgDvtZfHFItoyGhnsdD6wT9lpz9lWcj19s3rZBUmAEPmaGtDOBAQIwTvCUvJFHTy26ksUyfmQFGR7A4IM6oNRKc1GQnFmf3FAKcl/G+3+kBNHM8yJG2PpaDcjXHK1TVfuRRMp7k08Ec= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706677582; c=relaxed/simple; bh=46PMrE3uVBxf0b1hlA8wFd1fzXKAhx62Qf9fKtBmqCY=; h=Message-ID:From:To:Cc:In-Reply-To:References:Subject:Content-Type: Date:MIME-Version; b=g1nLi6J1PiZXMYrkeDFaeOCu4SXXE1s4hOYDbA+kL0plm3qB8+u7Wdjh1qtsr7kICgwdaQpVazE/cJWSshz2jIWFNaaNDskeB0e3zg6HreqkBUBq8/Unda+fqwlosqdXQ2I0L2K5qhsuhI+Oz1Ndl/gAzQpK4fzB6oaISfRdJ88= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=renesas.com; spf=pass smtp.mailfrom=renesas.com; dkim=pass (1024-bit key) header.d=renesas.com header.i=@renesas.com header.b=YFD75/CG; arc=fail smtp.client-ip=40.107.114.122 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=renesas.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=renesas.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=renesas.com header.i=@renesas.com header.b="YFD75/CG" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iMLwB5UTxv3JG/2nybpZv/Mt7Gg33F4sMTwl2twP4B2ItmbhJICmqVdnOSzyaTwQuGKl8098TWnYtCt2+EppNKyfuZUsNlAMB6I6V3VyTFZ4c4Ymvsg1wPS88kn9KiWGyZbGxaf9vNkdtTSpBnyP4KOldwKDRkeIY0SLisv7f6EyJhC7qA28OMjAf935AzvvW+y0LEIfVLD0Csc93dp3CtjMqw6EYjBLV1Q3lce5A0kgbJdhf51BA+eJb5qrFoQ+VUPVpU8tyvhcPcy1Geb4UQTdUKEYN1jnJt1X8XysJUtc94jgqN8HYgLCtErCbVKxd99XfvEhfql+TeLOunN1UA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5lhu29/2H+3rhc4xo+KZigQT3G3CvKsffKBWZag3xfU=; b=WHb4YxZHVnMfLArhPA4C47H7h1OBXy9hzT4RCeAg6SwpJY218B2qB5r+EiljwkSejxqqjpJqOTEBDThkJSIPZHzijbHBuwkKhE+x6huemXeJDCxxrsdHyJHSjrX6OiCjqkzzAe+HlhbDrhhV/0sPg2bbjHF19Wt6CSHVFei3/WvhKHfZF33+KOfhead/EDaKwrHEWwpUA2hUkVUTrzBERddvMAtxJOyuGAQKD1Ktz3V86u6E71ZqOlk9BtrsnXt/9MvEHNz4O1YILTiaGWPX9mz0CjswM4WfvP/3J8IL5iHI1/1t68KXa8ky2e624sUdE/obXhamALoj/ulRH8y4Tg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=renesas.com; dmarc=pass action=none header.from=renesas.com; dkim=pass header.d=renesas.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesas.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5lhu29/2H+3rhc4xo+KZigQT3G3CvKsffKBWZag3xfU=; b=YFD75/CGokUYv6H6oAc/0HAIVg7PsK9Pip+OGgXHFzFfvAeHo98BboAxnGvOWNLzFN+TH/6lJd/zhmMp0azmqZmYcklPJtrEsHnX3fm3Ys+52+CKLgauEE5Zp/Nllw4yYVNcRlaYiN4rHrjgf7Zi3J1QCimOPmSXOJdKGhs7t68= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=renesas.com; Received: from TYCPR01MB10914.jpnprd01.prod.outlook.com (2603:1096:400:3a9::11) by OSZPR01MB8896.jpnprd01.prod.outlook.com (2603:1096:604:158::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.23; Wed, 31 Jan 2024 05:06:15 +0000 Received: from TYCPR01MB10914.jpnprd01.prod.outlook.com ([fe80::ce8:8f5e:99a0:aba4]) by TYCPR01MB10914.jpnprd01.prod.outlook.com ([fe80::ce8:8f5e:99a0:aba4%2]) with mapi id 15.20.7249.023; Wed, 31 Jan 2024 05:06:15 +0000 Message-ID: <877cjq6qig.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: "Bryan O'Donoghue" , "Lad, Prabhakar" , =?iso-8859-1?q?=22Niklas_S=C3=B6d?= =?iso-8859-1?q?erlund=22?= , =?iso-8859-1?q?=22Uwe_Kleine-K=C3=B6nig=22?= , Abhinav Kumar , Alexander Shishkin , Alexander Stein , Alexandre Belloni , Alexandre Torgue , Alexey Brodkin , Andrzej Hajda , Andy Gross , Biju Das , Bjorn Andersson , Claudiu Beznea , Daniel Vetter , Dave Stevenson , David Airlie , Dmitry Baryshkov , Dmitry Torokhov , Emma Anholt , Eugen Hristev , Florian Fainelli , Frank Rowand , Greg Kroah-Hartman , Hans Verkuil , Helge Deller , Hugues Fruchet , Jacopo Mondi , Jacopo Mondi , James Clark , Jaroslav Kysela , Jonathan Hunter , Kevin Hilman , Kieran Bingham , Kieran Bingham , Konrad Dybcio , Krzysztof Kozlowski , Laurent Pinchart , Laurent Pinchart , Liam Girdwood , Liu Ying , Luca Ceresoli , Maarten Lankhorst , Marek Vasut , Mark Brown , Mauro Carvalho Chehab , Maxime Coquelin , Maxime Ripard , Michael Tretter , Michal Simek , Miguel Ojeda , Nathan Chancellor , Neil Armstrong , Nick Desaulniers , Nicolas Ferre , Philipp Zabel , Philippe Cornu , Raphael Gallais-Pou , Rob Clark , Rob Herring , Robert Foss , Russell King , Sakari Ailus , Saravana Kannan , Sascha Hauer , Shawn Guo , Sowjanya Komatineni , Stefan Agner , Suzuki K Poulose , Sylwester Nawrocki , Takashi Iwai , Thierry Reding , Thomas Zimmermann , Tim Harvey , Todor Tomov , Tomi Valkeinen , Yannick Fertre Cc: Alim Akhtar , Fabio Estevam , Jacopo Mondi , Jernej Skrabec , Jerome Brunet , Jessica Zhang , Jonas Karlman , Laurent Pinchart , Leo Yan , Marijn Suijten , Martin Blumenstingl , Mike Leach , Sam Ravnborg , Sean Paul , Tom Rix , coresight@lists.linaro.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-media@vger.kernel.org, linux-omap@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-sound@vger.kernel.org, linux-staging@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, linux-tegra@vger.kernel.org, llvm@lists.linux.dev In-Reply-To: <87o7d26qla.wl-kuninori.morimoto.gx@renesas.com> References: <87o7d26qla.wl-kuninori.morimoto.gx@renesas.com> Subject: [PATCH v3 12/24] of: property: add port base loop User-Agent: Wanderlust/2.15.9 Emacs/27.1 Mule/6.0 Date: Wed, 31 Jan 2024 05:06:15 +0000 X-ClientProxiedBy: TYCP286CA0282.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:3c9::9) To TYCPR01MB10914.jpnprd01.prod.outlook.com (2603:1096:400:3a9::11) Precedence: bulk X-Mailing-List: linux-omap@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TYCPR01MB10914:EE_|OSZPR01MB8896:EE_ X-MS-Office365-Filtering-Correlation-Id: f333e95f-4e17-415c-f914-08dc221a5a25 X-LD-Processed: 53d82571-da19-47e4-9cb4-625a166a4a2a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kKfbS+LzAgXhKRqTmkb/mkhoI2TmGookJsEQ/o0mMN1KB6njm7CtxEQ61UOJ60ifDaPpIhmbe0lCR139fWwABf2xMaBj4waEdpw9Ct3LjdWr1esJSCZsavSaPpucZ50RMuSQ2rE7z5feZQ1pWVi8+YduIKir21VJCW/zLhcVhLj9MvPi12pux3js01joUi5P+lpFnJwzcBVgkhLyhmI7pfgUwAAZMtX4m5dqpOVc1NLS9D6iP+LPJ0McNyvHOr+RCPLYxuioSFjd1Hg3/q6FsQ+o/T//RL3QQ5KIAqdALs1cB8bF6/rVd4IFS8cwWUlpChHVPUgACOywXwyb6MY9dTCtotcB1A1DT/T2ROiJzpLRP+OC9KiyA2S5DmxqJXgK8iX/DFPUr8KOlj+Bc3zxZz3Vu4qkKzq2eIh3QkpSeGG0xQk5KttFCg7h57cFNyBycjPw4aumhl5OvG+rHhBY6+1VvsLHALBxiAKFeyMsXM0Wm0OM2w3lmV0/3rt4ft8eSJ9h2NPq1lcyvtSvmSnW78ZnpKyqajQhd3Xt6L9Hj0zK4KCEA9w4XaYXcry7Ndo/1cPA6aSW3XA72AZ2soGt2/dyZVwfGNRwxOm2IfaRLWxfMHhyj0dxTIaQzXWNbxdse1jNpmq1ch/u8jbwjuicQQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TYCPR01MB10914.jpnprd01.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(39860400002)(366004)(136003)(346002)(396003)(376002)(230922051799003)(1800799012)(451199024)(64100799003)(186009)(36756003)(7336002)(7366002)(7276002)(52116002)(7406005)(7416002)(6506007)(38100700002)(6512007)(5660300002)(86362001)(38350700005)(41300700001)(2906002)(2616005)(478600001)(6486002)(26005)(1191002)(921011)(66476007)(66946007)(66556008)(54906003)(110136005)(8936002)(8676002)(316002)(4326008); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: HSWH/BjpYQqAlznVH+ULeNSyJ/d6ovU/qV1rXmZ2bP7/XknBsiUm1kKH2aikxc2I543XWvaWkjMhuLjhT/E8ScQrFcftoN5jpCfBsiGlxqtBqBX+yW6gRITtz+PlMWWVQNIS6eOF9od0FXXpcCzEyGRE78bhY6SaT4g3Qt0NuPIyjFxQqQIZWKi1pIzZ00rL886HVzM4UqVxiOiZWGxl/+jbPAtxxzfLU7lDJXqA9BJx5CjLTgO3F/VWICgUKqqS1eF1EFtdFhvzFWRAr5TSqaMIjeUmjJQPI8AeraBrqpC3YgSo5p0pcjh9cECI33SZSzST6AbTFXHZWdvdzOlNUWfwEq80S+Q03CfFmruJ8kN7f3BLK/AknFGOkCrhQvyWxcxd8ZUqVe1W4FFHX5vnlb/bpyHF4T09HJT4dQETlwGjfhPQgWfEzkbzPOFLZR4dCX8oQ9d/yoYFcuLhmoA1Ic8/XCAQNClkB8p+Z57YCo8Qg8RX9mVYGtyk1gY9V4shDVhOqAq6003xkTbS4NHbQOhID3jrZg3xjMjp11dAdrujSjR62UsXtFg11AgG/uf82okoqCFxTXzwzYMQ4OpCHhhe+gxmyHfFc9AS6r7wv3cXA6es5NMnr80p6SN7NSc+VoU3cKz6L1q7210qugq/CKVqctIYcBz7R/JixvVYOnzfWET2/oxCQce3IXHlzZp19eq/1V/HKqbgC7d0JAaNkkAB+O4Reu+gYDO8KvNX13mNDTD94xniWpndxb0bJWE4KZqxzle9RNCtxppfH0P7iBAobiAIqQDtW/rIgDNczDE7CGGLee1XMVF3T3zdQxrIhmC8lkLYB0Eq9h3FaLTwdhPsPWyLpcUF7rwyLXJKtRGf5C99UUZaNRMHeDkrSGYsW5orvaV1AZMRIB1/nn5bkbNHF4NniVD5vz7XU/NTiC541RY7dlQAlj+Y5hsCIUDrtl1QGWTPyGW9cOHu9gSPYIeDx39aiAAtit7oM/wMoNJ0kIPW/IaNeWsVUQjbjibWL8buel6KnIrSc7bBhn+DD1dqkMZq/ypj30WbDM+C/oxUI8Pui4vgEN3ANAgEsnGTWMJS6NCy8ll/EpQ/4jsl0PUQKWTCQ3wzHk7C6w0y6oyURqJN9zbaJCtkuz5Gn+IZ2f5Hd/ZmvrL4voZ0/FTgbLAc22fCf89TTsWBNy4i5s8NK2DAh6NTsX45pvLsrjPQuTFg8t8rz0U+9amaJ2NLMgcjsvo7ssLQz+J34RQJe0Xn4bJR/T/PSnCd9q551RNdD24p7fYcqjz+i6MIVPlherK0kZb1tCIEgb4YCAzJyb299kM1AvZB5DKA64ti2TUCTZyrxz58oSQh1J1sVeHO72CTq2iJFadGpLYCp3ncEi4yY63fH2jbLyKFtwFUI2k/SivLdO2ZJLNp9vF0LDYsTZr/uYDBuxlANutDNIFzND07t6J3MWWQmU9lQ2KRa0LgEBkLMSuHhG5ORbj1HJiGn1QEak0sTdxo+fs4P+XT8CQqjGKUZ747DEIW1cKeyyOblueNLAnMQwEZHPIsq+61IZwU/h43Q8ix1r0ATgVtcsZKm7ZeOpLjs//SL2a3OcYlaGxUapm7Ric4Ig0wzT0wBP5MDJ5bKKwumCSgkjkwCKc= X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-Network-Message-Id: f333e95f-4e17-415c-f914-08dc221a5a25 X-MS-Exchange-CrossTenant-AuthSource: TYCPR01MB10914.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2024 05:06:15.7623 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: w2WFfwXn9yFx5UREo9AQ96AExaHVqckos5juZ7nFm4kkrse80crQ4yqtGAnhTiqDwe+BzSQ+qoQXZ2sOTj/k9cm9AyALHbpXH4x+oXc4MuHANrQ737fQ7hannY8TWQCL X-MS-Exchange-Transport-CrossTenantHeadersStamped: OSZPR01MB8896 We have endpoint base functions - of_graph_get_next_device_endpoint() - of_graph_get_device_endpoint_count() - for_each_device_endpoint_of_node() Here, for_each_device_endpoint_of_node() loop finds each endpoints ports { port@0 { (1) endpoint {...}; }; port@1 { (2) endpoint {...}; }; ... }; In above case, for_each_device_endpoint_of_node() loop finds endpoint as (1) -> (2) -> ... Basically, user/driver knows which port is used for what, but not in all cases. For example on flexible/generic driver case, how many ports are used is not fixed. For example Sound Generic Card driver which is used from many venders can't know how many ports are used. Because the driver is very flexible/generic, it is impossible to know how many ports are used, it depends on each vender SoC and/or its used board. And more, the port can have multi endpoints. For example Generic Sound Card case, it supports many type of connection between CPU / Codec, and some of them uses multi endpoint in one port. Then, Generic Sound Card want to handle each connection via "port" instead of "endpoint". But, it is very difficult to handle each "port" by for_each_device_endpoint_of_node(). Getting "port" by using of_get_parent() from "endpoint" doesn't work. see below. ports { port@0 { (1) endpoint@0 {...}; (2) endpoint@1 {...}; }; port@1 { (3) endpoint {...}; }; ... }; Add "port" base functions. Signed-off-by: Kuninori Morimoto --- drivers/of/property.c | 56 ++++++++++++++++++++++++++++++++++++++++ include/linux/of_graph.h | 26 +++++++++++++++++++ 2 files changed, 82 insertions(+) diff --git a/drivers/of/property.c b/drivers/of/property.c index 007729d66972..cba07d2af62b 100644 --- a/drivers/of/property.c +++ b/drivers/of/property.c @@ -631,6 +631,44 @@ struct device_node *of_graph_get_port_by_id(struct device_node *parent, u32 id) } EXPORT_SYMBOL(of_graph_get_port_by_id); +/** + * of_graph_get_next_port() - get next port node. + * @parent: pointer to the parent device node + * @port: current port node, or NULL to get first + * + * Return: A 'port' node pointer with refcount incremented. Refcount + * of the passed @prev node is decremented. + */ +struct device_node *of_graph_get_next_port(const struct device_node *parent, + struct device_node *port) +{ + if (!parent) + return NULL; + + if (!port) { + struct device_node *node; + struct device_node *port; + + node = of_get_child_by_name(parent, "ports"); + if (node) + parent = node; + + port = of_get_child_by_name(parent, "port"); + of_node_put(node); + + return port; + } + + do { + port = of_get_next_child(parent, port); + if (!port) + break; + } while (!of_node_name_eq(port, "port")); + + return port; +} +EXPORT_SYMBOL(of_graph_get_next_port); + /** * of_graph_get_next_device_endpoint() - get next endpoint node. If it reached to end of the port, * it gets next endpoint from next port. @@ -831,6 +869,24 @@ unsigned int of_graph_get_device_endpoint_count(const struct device_node *np) } EXPORT_SYMBOL(of_graph_get_device_endpoint_count); +/** + * of_graph_get_port_count() - get count of port + * @np: pointer to the parent device node + * + * Return: count of port of this device node + */ +unsigned int of_graph_get_port_count(const struct device_node *np) +{ + struct device_node *port; + int num = 0; + + for_each_port_of_node(np, port) + num++; + + return num; +} +EXPORT_SYMBOL(of_graph_get_port_count); + /** * of_graph_get_remote_node() - get remote parent device_node for given port/endpoint * @node: pointer to parent device_node containing graph port/endpoint diff --git a/include/linux/of_graph.h b/include/linux/of_graph.h index f59ce2ea55eb..48f7701feab1 100644 --- a/include/linux/of_graph.h +++ b/include/linux/of_graph.h @@ -37,14 +37,28 @@ struct of_endpoint { for (child = of_graph_get_next_device_endpoint(parent, NULL); child != NULL; \ child = of_graph_get_next_device_endpoint(parent, child)) +/** + * for_each_port_of_node - iterate over every port in a device node + * @parent: parent device node containing ports/port + * @child: loop variable pointing to the current port node + * + * When breaking out of the loop, of_node_put(child) has to be called manually. + */ +#define for_each_port_of_node(parent, child) \ + for (child = of_graph_get_next_port(parent, NULL); child != NULL; \ + child = of_graph_get_next_port(parent, child)) + #ifdef CONFIG_OF bool of_graph_is_present(const struct device_node *node); int of_graph_parse_endpoint(const struct device_node *node, struct of_endpoint *endpoint); unsigned int of_graph_get_device_endpoint_count(const struct device_node *np); +unsigned int of_graph_get_port_count(const struct device_node *np); struct device_node *of_graph_get_port_by_id(struct device_node *node, u32 id); struct device_node *of_graph_get_next_device_endpoint(const struct device_node *parent, struct device_node *previous); +struct device_node *of_graph_get_next_port(const struct device_node *parent, + struct device_node *previous); struct device_node *of_graph_get_endpoint_by_regs( const struct device_node *parent, int port_reg, int reg); struct device_node *of_graph_get_remote_endpoint( @@ -73,6 +87,11 @@ static inline unsigned int of_graph_get_device_endpoint_count(const struct devic return 0; } +static inline unsigned int of_graph_get_port_count(const struct device_node *np) +{ + return 0; +} + static inline struct device_node *of_graph_get_port_by_id( struct device_node *node, u32 id) { @@ -86,6 +105,13 @@ static inline struct device_node *of_graph_get_next_device_endpoint( return NULL; } +static inline struct device_node *of_graph_get_next_port( + const struct device_node *parent, + struct device_node *previous) +{ + return NULL; +} + static inline struct device_node *of_graph_get_endpoint_by_regs( const struct device_node *parent, int port_reg, int reg) {