From patchwork Thu Mar 31 15:06:54 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Roger Quadros X-Patchwork-Id: 64799 Delivered-To: patch@linaro.org Received: by 10.112.199.169 with SMTP id jl9csp212164lbc; Thu, 31 Mar 2016 08:07:19 -0700 (PDT) X-Received: by 10.98.34.200 with SMTP id p69mr22606939pfj.114.1459436839050; Thu, 31 Mar 2016 08:07:19 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 76si14674202pfb.3.2016.03.31.08.07.18; Thu, 31 Mar 2016 08:07:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-omap-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-omap-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-omap-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756776AbcCaPHS (ORCPT + 3 others); Thu, 31 Mar 2016 11:07:18 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:55846 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754567AbcCaPHR (ORCPT ); Thu, 31 Mar 2016 11:07:17 -0400 Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by bear.ext.ti.com (8.13.7/8.13.7) with ESMTP id u2VF6vwN009572; Thu, 31 Mar 2016 10:06:57 -0500 Received: from DLEE70.ent.ti.com (dlemailx.itg.ti.com [157.170.170.113]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id u2VF6vYt027279; Thu, 31 Mar 2016 10:06:57 -0500 Received: from dflp33.itg.ti.com (10.64.6.16) by DLEE70.ent.ti.com (157.170.170.113) with Microsoft SMTP Server id 14.3.224.2; Thu, 31 Mar 2016 10:06:57 -0500 Received: from [192.168.2.6] (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp33.itg.ti.com (8.14.3/8.13.8) with ESMTP id u2VF6s2R021508; Thu, 31 Mar 2016 10:06:55 -0500 Subject: Re: Beagle-X15, Debian and reproducible-builds To: Vagrant Cascadian , Nishanth Menon , beagleboard-x15 , linux-omap , "Cooper Jr., Franklin" References: <87egb16jci.fsf@aikidev.net> <56F3201C.2090103@ti.com> <56FC0BEC.4070203@ti.com> <874mbn6866.fsf@aikidev.net> From: Roger Quadros Message-ID: <56FD3D0E.50703@ti.com> Date: Thu, 31 Mar 2016 18:06:54 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <874mbn6866.fsf@aikidev.net> Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org Vagrant, On 30/03/16 23:08, Vagrant Cascadian wrote: > On 2016-03-30, Roger Quadros wrote: >> On 24/03/16 01:00, Nishanth Menon wrote: >>> On 03/23/2016 03:16 PM, Vagrant Cascadian wrote: >>>> ethernet. Unfortunately, eSATA doesn't seem to work when compiled as a >>>> module, although I have it working as a built-in with linux 4.5-rc6. >>> >>> >>> weird. I could swear that omap2plus_defconfig did work with eSATA last >>> I tested... probably built in though.. >>> >>> Could you file a https://bugzilla.kernel.org/ bug with details and >>> .config involved? > > Haven't created a bugzilla account yet... > > >> I just tired with omap2plus_defconfig with CONFIG_ATA=m and CONFIG_SATA_AHCI_PLATFORM=m >> on v4.5 + u-boot 2016.03 and eSATA worked fine. >> >> I need to know the exact .config that you used to debug the issue. Thanks. > > Thanks for following up. I recently tried with 4.6-rc1 and the attached > config, which is based on Debian's multiplatform builds of the kernel. > > I'm also starting to suspect some of the patches applied to u-boot > 2016.03 might be interfering, which were forward-ported from ti's > u-boot; will try without those u-boot patches applied. At least with omap2plus_defconfig with CONFIG_TI_PIPE3=m, CONFIG_ATA=m and CONFIG_SATA_AHCI_PLATFORM=m I can get SATA to break. Can you please try this patch to u-boot? It seemed to work for me. --- From: Roger Quadros Date: Thu, 31 Mar 2016 17:46:55 +0300 Subject: [PATCH] board: ti: am57xx: Prevent init_sata() from being called twice init_sata() is done as part of scsi_init() in arch/arm/cpu/armv7/omap-common/sata.c so no need to duplicate it here. This seems to fix SATA problems in the kernel when CONFIG_TI_PIPE3 is configured as loadable module. Reported-by: Vagrant Cascadian Cc: Cooper Jr., Franklin Cc: Nishanth Menon Signed-off-by: Roger Quadros --- board/ti/am57xx/board.c | 1 - 1 file changed, 1 deletion(-) -- 2.5.0 -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/board/ti/am57xx/board.c b/board/ti/am57xx/board.c index 042f9ab..34c5161 100644 --- a/board/ti/am57xx/board.c +++ b/board/ti/am57xx/board.c @@ -264,7 +264,6 @@ int board_init(void) int board_late_init(void) { - init_sata(0); /* * DEV_CTRL.DEV_ON = 1 please - else palmas switches off in 8 seconds * This is the POWERHOLD-in-Low behavior.