| Message ID | 20250116223840.430054-2-s-ramamoorthy@ti.com |
|---|---|
| State | New |
| Headers | show |
| Series | Add TI TPS65215 PMIC GPIO Support | expand |
On 16/01/2025 23:38, Shree Ramamoorthy wrote: > /* > - * GPIO driver for TI TPS65215/TPS65219 PMICs > + * TI TPS65214/TPS65215/TPS65219 PMIC GPIO Driver > * > * Copyright (C) 2024 Texas Instruments Incorporated - http://www.ti.com/ > */ > @@ -156,6 +156,10 @@ static const struct gpio_chip tps65219_template_chip = { > }; > > static const struct tps65219_chip_data chip_info_table[] = { > + [TPS65214] = { > + .ngpio = 2, > + .offset = 1, So that's the same as TPS65215? Why do you keep duplicating entries? > + }, > [TPS65215] = { > .ngpio = 2, > .offset = 1, Best regards, Krzysztof
Hi, On 1/17/25 3:27 AM, Krzysztof Kozlowski wrote: > On 16/01/2025 23:38, Shree Ramamoorthy wrote: >> /* >> - * GPIO driver for TI TPS65215/TPS65219 PMICs >> + * TI TPS65214/TPS65215/TPS65219 PMIC GPIO Driver >> * >> * Copyright (C) 2024 Texas Instruments Incorporated - http://www.ti.com/ >> */ >> @@ -156,6 +156,10 @@ static const struct gpio_chip tps65219_template_chip = { >> }; >> >> static const struct tps65219_chip_data chip_info_table[] = { >> + [TPS65214] = { >> + .ngpio = 2, >> + .offset = 1, > So that's the same as TPS65215? Why do you keep duplicating entries? Thanks for reviewing! I will register TPS65214 as "tps65215-gpio" in the MFD driver to minimize changes. This will eliminate the tps65215 gpio series, since only the description changes are left. >> + }, >> [TPS65215] = { >> .ngpio = 2, >> .offset = 1, > Best regards, > Krzysztof
diff --git a/drivers/gpio/gpio-tps65219.c b/drivers/gpio/gpio-tps65219.c index 6845f2920f3a..6b8d88ca3e8a 100644 --- a/drivers/gpio/gpio-tps65219.c +++ b/drivers/gpio/gpio-tps65219.c @@ -1,6 +1,6 @@ // SPDX-License-Identifier: GPL-2.0 /* - * GPIO driver for TI TPS65215/TPS65219 PMICs + * TI TPS65214/TPS65215/TPS65219 PMIC GPIO Driver * * Copyright (C) 2024 Texas Instruments Incorporated - http://www.ti.com/ */ @@ -156,6 +156,10 @@ static const struct gpio_chip tps65219_template_chip = { }; static const struct tps65219_chip_data chip_info_table[] = { + [TPS65214] = { + .ngpio = 2, + .offset = 1, + }, [TPS65215] = { .ngpio = 2, .offset = 1, @@ -191,6 +195,7 @@ static int tps65219_gpio_probe(struct platform_device *pdev) } static const struct platform_device_id tps6521x_gpio_id_table[] = { + { "tps65214-gpio", TPS65214 }, { "tps65215-gpio", TPS65215 }, { "tps65219-gpio", TPS65219 }, { } @@ -207,5 +212,5 @@ static struct platform_driver tps65219_gpio_driver = { module_platform_driver(tps65219_gpio_driver); MODULE_AUTHOR("Jonathan Cormier <jcormier@criticallink.com>"); -MODULE_DESCRIPTION("TPS65215/TPS65219 GPIO driver"); +MODULE_DESCRIPTION("TPS65214/TPS65215/TPS65219 GPIO driver"); MODULE_LICENSE("GPL");
Add TPS65214 support to platform_id table and device-specific chip_data struct. Update descriptions to reflect the driver supports 3 PMICs: TPS65214, TPS65215, and TPS65219. Signed-off-by: Shree Ramamoorthy <s-ramamoorthy@ti.com> --- drivers/gpio/gpio-tps65219.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)