| Message ID | 20210727101034.32148-1-tony@atomide.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2] memory: omap-gpmc: Clear GPMC_CS_CONFIG7 register on restore if unused | expand |
On Tue, 27 Jul 2021 13:10:33 +0300, Tony Lindgren wrote: > We want to clear any unused GPMC_CS_CONFIG7 register on restore to > ensure unused chip selects are not enabled. Applied, thanks! [1/2] memory: omap-gpmc: Clear GPMC_CS_CONFIG7 register on restore if unused commit: 0f78964b523fe9920deae3455324060356ae53d0 [2/2] memory: omap-gpmc: Drop custom PM calls with cpu_pm notifier commit: 77ed5e9dec551765bde9f2e4b7ed9071ff03d61d Best regards, -- Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
On 27/07/2021 13:10, Tony Lindgren wrote: > We want to clear any unused GPMC_CS_CONFIG7 register on restore to > ensure unused chip selects are not enabled. > > Cc: Roger Quadros <rogerq@kernel.org> > Signed-off-by: Tony Lindgren <tony@atomide.com> Acked-by: Roger Quadros <rogerq@kernel.org> Sorry if you got this twice. I got a bounce back on the previous Ack. cheers, -roger > --- > drivers/memory/omap-gpmc.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c > --- a/drivers/memory/omap-gpmc.c > +++ b/drivers/memory/omap-gpmc.c > @@ -2595,6 +2595,8 @@ void omap3_gpmc_restore_context(void) > gpmc_context.cs_context[i].config6); > gpmc_cs_write_reg(i, GPMC_CS_CONFIG7, > gpmc_context.cs_context[i].config7); > + } else { > + gpmc_cs_write_reg(i, GPMC_CS_CONFIG7, 0); > } > } > } >
diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c --- a/drivers/memory/omap-gpmc.c +++ b/drivers/memory/omap-gpmc.c @@ -2595,6 +2595,8 @@ void omap3_gpmc_restore_context(void) gpmc_context.cs_context[i].config6); gpmc_cs_write_reg(i, GPMC_CS_CONFIG7, gpmc_context.cs_context[i].config7); + } else { + gpmc_cs_write_reg(i, GPMC_CS_CONFIG7, 0); } } }
We want to clear any unused GPMC_CS_CONFIG7 register on restore to ensure unused chip selects are not enabled. Cc: Roger Quadros <rogerq@kernel.org> Signed-off-by: Tony Lindgren <tony@atomide.com> --- drivers/memory/omap-gpmc.c | 2 ++ 1 file changed, 2 insertions(+)