diff mbox series

[v2,2/4] dt-bindings: pci: ti,j721e: Add host mode dt-bindings for TI's AM64 SoC

Message ID 20210104124103.30930-3-kishon@ti.com
State New
Headers show
Series AM64: Add PCIe bindings and driver support | expand

Commit Message

Kishon Vijay Abraham I Jan. 4, 2021, 12:41 p.m. UTC
Add host mode dt-bindings for TI's AM64 SoC. This is the same IP used in
J7200, however AM64 is a non-coherent architecture.

Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
---
 .../devicetree/bindings/pci/ti,j721e-pci-host.yaml     | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

Comments

Rob Herring (Arm) Jan. 11, 2021, 10:37 p.m. UTC | #1
On Mon, Jan 04, 2021 at 06:11:01PM +0530, Kishon Vijay Abraham I wrote:
> Add host mode dt-bindings for TI's AM64 SoC. This is the same IP used in

> J7200, however AM64 is a non-coherent architecture.

> 

> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>

> ---

>  .../devicetree/bindings/pci/ti,j721e-pci-host.yaml     | 10 +++++++---

>  1 file changed, 7 insertions(+), 3 deletions(-)

> 

> diff --git a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml

> index 7607018a115b..77118dba415e 100644

> --- a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml

> +++ b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml

> @@ -16,12 +16,17 @@ allOf:

>  properties:

>    compatible:

>      oneOf:

> -      - description: PCIe controller in J7200

> +      - const: ti,am64-pcie-host


No, either you have fallback or you don't. 

> +      - const: ti,j7200-pcie-host

> +      - const: ti,j721e-pcie-host

> +      - description: PCIe controller in AM64

>          items:

> +          - const: ti,am64-pcie-host

>            - const: ti,j7200-pcie-host

>            - const: ti,j721e-pcie-host


2 fallbacks is probably not too useful. Do those really enable 
anything?

> -      - description: PCIe controller in J721E

> +      - description: PCIe controller in J7200

>          items:

> +          - const: ti,j7200-pcie-host

>            - const: ti,j721e-pcie-host

>  

>    reg:

> @@ -87,7 +92,6 @@ required:

>    - vendor-id

>    - device-id

>    - msi-map

> -  - dma-coherent

>    - dma-ranges

>    - ranges

>    - reset-gpios

> -- 

> 2.17.1

>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
index 7607018a115b..77118dba415e 100644
--- a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
+++ b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
@@ -16,12 +16,17 @@  allOf:
 properties:
   compatible:
     oneOf:
-      - description: PCIe controller in J7200
+      - const: ti,am64-pcie-host
+      - const: ti,j7200-pcie-host
+      - const: ti,j721e-pcie-host
+      - description: PCIe controller in AM64
         items:
+          - const: ti,am64-pcie-host
           - const: ti,j7200-pcie-host
           - const: ti,j721e-pcie-host
-      - description: PCIe controller in J721E
+      - description: PCIe controller in J7200
         items:
+          - const: ti,j7200-pcie-host
           - const: ti,j721e-pcie-host
 
   reg:
@@ -87,7 +92,6 @@  required:
   - vendor-id
   - device-id
   - msi-map
-  - dma-coherent
   - dma-ranges
   - ranges
   - reset-gpios