From patchwork Fri Nov 9 22:18:13 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Turquette X-Patchwork-Id: 12799 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id DFD5523E01 for ; Fri, 9 Nov 2012 22:18:33 +0000 (UTC) Received: from mail-ie0-f180.google.com (mail-ie0-f180.google.com [209.85.223.180]) by fiordland.canonical.com (Postfix) with ESMTP id 8B109A181C6 for ; Fri, 9 Nov 2012 22:18:33 +0000 (UTC) Received: by mail-ie0-f180.google.com with SMTP id e10so6364745iej.11 for ; Fri, 09 Nov 2012 14:18:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf :content-type:mime-version:content-transfer-encoding:to:from :in-reply-to:cc:references:message-id:user-agent:subject:date :x-originating-ip:x-gm-message-state; bh=2CwEpKmW5+1ReWtI3afxFp7IWaAjU+hllj7XfWWcTFU=; b=iONmCr9/Xmd7N+rbTVc+D7NQxkVr/s2FPnsaQcbaGFCwMpJlEzCNGJd8xlVtF1YY4o OjsSkiM27kcerrJBPVZS45zfmFB+vpP0TZ2W2Uk8Z93vKt64p0ahHMzDzMDe15JTjZhd HhP1sBHwqXoQYFUfEi0ytF124oFePHinUfpv0HAeU4H3sLT1RjefPrf82I5T4yTBgFm7 9djkUyNZ6sYdPbrWNi1SXCrMFfEwRpJqUVtl+tXA1ih07fcA3Jehk1Y3Q4zn52sJ/Kyb s2PQqLcc8eUJ+y1ZliuZRwm73JkX5ff0Dh0etiSUE5ulplAEi1Xov/uYDMlHJqoTI+eb vsxg== Received: by 10.43.46.2 with SMTP id um2mr4499916icb.18.1352499513001; Fri, 09 Nov 2012 14:18:33 -0800 (PST) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.50.67.148 with SMTP id n20csp95123igt; Fri, 9 Nov 2012 14:18:32 -0800 (PST) Received: by 10.182.47.66 with SMTP id b2mr9579843obn.34.1352499512367; Fri, 09 Nov 2012 14:18:32 -0800 (PST) Received: from bear.ext.ti.com (bear.ext.ti.com. [192.94.94.41]) by mx.google.com with ESMTPS id pt10si9585454obc.131.2012.11.09.14.18.31 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 09 Nov 2012 14:18:31 -0800 (PST) Received-SPF: pass (google.com: domain of mturquette@ti.com designates 192.94.94.41 as permitted sender) client-ip=192.94.94.41; Authentication-Results: mx.google.com; spf=pass (google.com: domain of mturquette@ti.com designates 192.94.94.41 as permitted sender) smtp.mail=mturquette@ti.com Received: from dlelxv30.itg.ti.com ([172.17.2.17]) by bear.ext.ti.com (8.13.7/8.13.7) with ESMTP id qA9MIV9c013045; Fri, 9 Nov 2012 16:18:31 -0600 Received: from DLEE74.ent.ti.com (dlee74.ent.ti.com [157.170.170.8]) by dlelxv30.itg.ti.com (8.13.8/8.13.8) with ESMTP id qA9MIVhM007561; Fri, 9 Nov 2012 16:18:31 -0600 Received: from localhost (10.188.36.112) by DLEE74.ent.ti.com (157.170.170.8) with Microsoft SMTP Server (TLS) id 14.1.323.3; Fri, 9 Nov 2012 16:18:30 -0600 MIME-Version: 1.0 To: Paul Walmsley , From: Mike Turquette In-Reply-To: CC: , , References: <1352337181-29427-1-git-send-email-mturquette@ti.com> Message-ID: <20121109221813.17381.31431@nucleus> User-Agent: alot/0.3.2+ Subject: Re: [PATCH v2 00/26] Move OMAP2+ over to common clk framework Date: Fri, 9 Nov 2012 14:18:13 -0800 X-Originating-IP: [10.188.36.112] X-Gm-Message-State: ALoCoQlZPAeEPNU7zit7wV70kefJFwMRlhMj4c1/tztNy4LW8EKmvE0unsFOdJJsTC3lQbZ8nrXr Quoting Paul Walmsley (2012-11-09 13:12:24) > Hi > > With the fixes that have been posted, this is testing clean here. Mike > and Rajendra have put in months of work on these patches under > often-difficult conditions, and it's really great that we've arrived at > this point with zero obvious remaining regressions from the current code. > > The branch has been posted for the time being at > git://git.pwsan.com/linux-2.6 in the branch 'common_clk_devel_3.8', with > the head at commit 376676b429cb6dc95c39cdac82b2be816ea22893, in case > anyone else wants to try it. > Thanks a lot Paul. You put in a lot of work on this series as well and that should not go unnoticed. I'm truly happy to see this series come together. > Anyway, barring any further regressions that haven't reared their ugly > heads yet, and barring anything truly horrible in the code or data that > I've missed so far, will take this branch from here. It still needs some > more work before it's ready to merge. The clockdomain usecounting fix > patch needs to be split and moved earlier in the patch stack so 'git > bisect' doesn't result in warnings and broken PM on OMAP3. And it all is > going to be rebased on the second set of PRCM cleanup patches at commit > b99db36cdf37decb1b5575c5f293d170cbbc53d6, which I'm assuming Tony is > planning to pull. Then will plan to send that pull request to Tony. > I just did some more testing on your branch and everything looks great. The only thing that caught my eye was using the clk-private.h header in the top-most patch. The following patch will help me sleep better at night: Tested on 3530 ES3.0 Beagleboard, boot + suspend/resume. Regards, Mike > Then after that, if there's still time to merge some of the clock changes > that have showed up on the lists for 3.8, those will get stacked onto a > topic branch based on the branch that's sent to Tony. > > > - Paul diff --git a/arch/arm/mach-omap2/clockdomain.c b/arch/arm/mach-omap2/clockdomain.c index ba4d14c..3848735 100644 --- a/arch/arm/mach-omap2/clockdomain.c +++ b/arch/arm/mach-omap2/clockdomain.c @@ -22,7 +22,7 @@ #include #include #include -#include +#include #include