From patchwork Mon Jun 16 11:23:06 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sricharan R X-Patchwork-Id: 31937 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-qc0-f197.google.com (mail-qc0-f197.google.com [209.85.216.197]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id D60A920E7A for ; Mon, 16 Jun 2014 11:26:27 +0000 (UTC) Received: by mail-qc0-f197.google.com with SMTP id i8sf20661312qcq.4 for ; Mon, 16 Jun 2014 04:26:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe:content-type; bh=yn77Ew/K6GwEuo+mwu4YUm1MF+ZRKshj/QAfZvot80M=; b=AQyq/B3kAUjl4A1XfjJS25AgCtAhxxuFMYnB0YDYeizHpNtWHdJ36HN9LOVbt09wG3 DeET2f1MP88f2k/2LQF4brMrmgHFU8pVfJtanwlpXzNUX2ShEBifGwwjZ4KpWtGAhV4H 4Xz/pgMpUXo7ksCyQLMpYJI75/yNJjP27+bBtav6H65YyB1UL6PBbDUPXIDaL3DBtK9I x4XwNHiDU6Khu6pC9iyArbz83Q3Cb7JRlR1Z9Mj4JODoTSrVB7QZoBGTcxFhghx8f5GO WIKj9QTtaXsJyb01vHiK0UXEGz8lqBGgIIRAVG7N5Qpn/kO7irC+82djpwmEG8Y4tZGj JGuA== X-Gm-Message-State: ALoCoQlqCd5InQMrzYeO5PqkkZQUAmU/zotU2jGq7BizLIfz279W/lAR+jCL3uK2ulMI4Zb3bKNu X-Received: by 10.236.223.9 with SMTP id u9mr3733yhp.2.1402917987570; Mon, 16 Jun 2014 04:26:27 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.97.200 with SMTP id m66ls4212758qge.83.gmail; Mon, 16 Jun 2014 04:26:27 -0700 (PDT) X-Received: by 10.221.29.137 with SMTP id ry9mr15881286vcb.6.1402917987488; Mon, 16 Jun 2014 04:26:27 -0700 (PDT) Received: from mail-ve0-f172.google.com (mail-ve0-f172.google.com [209.85.128.172]) by mx.google.com with ESMTPS id yd5si960705vec.100.2014.06.16.04.26.27 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 16 Jun 2014 04:26:27 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.128.172 as permitted sender) client-ip=209.85.128.172; Received: by mail-ve0-f172.google.com with SMTP id jz11so5856532veb.17 for ; Mon, 16 Jun 2014 04:26:27 -0700 (PDT) X-Received: by 10.58.123.71 with SMTP id ly7mr15535308veb.11.1402917987393; Mon, 16 Jun 2014 04:26:27 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.221.54.6 with SMTP id vs6csp127280vcb; Mon, 16 Jun 2014 04:26:26 -0700 (PDT) X-Received: by 10.68.234.2 with SMTP id ua2mr23045450pbc.81.1402917986485; Mon, 16 Jun 2014 04:26:26 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id kc2si10613800pbc.148.2014.06.16.04.26.25; Mon, 16 Jun 2014 04:26:25 -0700 (PDT) Received-SPF: none (google.com: linux-kernel-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755333AbaFPL0K (ORCPT + 9 others); Mon, 16 Jun 2014 07:26:10 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:37735 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752565AbaFPL0I (ORCPT ); Mon, 16 Jun 2014 07:26:08 -0400 Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by comal.ext.ti.com (8.13.7/8.13.7) with ESMTP id s5GBPdD7029552; Mon, 16 Jun 2014 06:25:39 -0500 Received: from DFLE72.ent.ti.com (dfle72.ent.ti.com [128.247.5.109]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id s5GBPdSR027124; Mon, 16 Jun 2014 06:25:39 -0500 Received: from dlep33.itg.ti.com (157.170.170.75) by DFLE72.ent.ti.com (128.247.5.109) with Microsoft SMTP Server id 14.3.174.1; Mon, 16 Jun 2014 06:25:39 -0500 Received: from uda0393807.india.ti.com. (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep33.itg.ti.com (8.14.3/8.13.8) with ESMTP id s5GBOx43008965; Mon, 16 Jun 2014 06:25:34 -0500 From: Sricharan R To: , , , CC: , , , , , , , , Subject: [PATCH V3 06/16] irqchip: crossbar: remove IS_ERR_VALUE check Date: Mon, 16 Jun 2014 16:53:06 +0530 Message-ID: <1402917796-31574-7-git-send-email-r.sricharan@ti.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1402917796-31574-1-git-send-email-r.sricharan@ti.com> References: <1402917796-31574-1-git-send-email-r.sricharan@ti.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: r.sricharan@ti.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.128.172 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , From: Nishanth Menon IS_ERR_VALUE makes sense only *if* there could be valid values in negative error range. But in the cases that we do use it, there is no such case. Just remove the same. Signed-off-by: Nishanth Menon Signed-off-by: Sricharan R --- drivers/irqchip/irq-crossbar.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/irqchip/irq-crossbar.c b/drivers/irqchip/irq-crossbar.c index 9528cf2..42ea49d 100644 --- a/drivers/irqchip/irq-crossbar.c +++ b/drivers/irqchip/irq-crossbar.c @@ -102,15 +102,15 @@ static int crossbar_domain_xlate(struct irq_domain *d, unsigned long *out_hwirq, unsigned int *out_type) { - unsigned long ret; + int ret; ret = get_prev_map_irq(intspec[1]); - if (!IS_ERR_VALUE(ret)) + if (ret >= 0) goto found; ret = allocate_free_irq(intspec[1]); - if (IS_ERR_VALUE(ret)) + if (ret < 0) return ret; found: