From patchwork Thu Jun 12 11:53:12 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sricharan R X-Patchwork-Id: 31816 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-oa0-f69.google.com (mail-oa0-f69.google.com [209.85.219.69]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id EF0EE20AE6 for ; Thu, 12 Jun 2014 11:56:44 +0000 (UTC) Received: by mail-oa0-f69.google.com with SMTP id j17sf5755134oag.4 for ; Thu, 12 Jun 2014 04:56:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe:content-type; bh=his75SwLMRR4gWL8wIpeTBYzY/2X8okJgR1zXXbNSPU=; b=Lw0WM28RfoTP2FM+M/oMuPEaNpT78Gx9FjZidYfhBf9HhAFv1pGXXE32aWBt0fSXDo 6UJU81QPI8Qlc3ije50hro9OOQP1g57eXyMKGHGGFstFrzvOvWYkDG9au8s4YGGUuWwl BJqV/zh3vO3pKNelV5OL4HQyasgNZVQTvRZPIbvHg0nmXx2mqAhyoG4QvcFv2s3cHgZN 34R6jC1SJavWI/Y3azU2bIfsD90/ueRNCw9+hxuRVYU6ZSv2dLu5VNMB8hPBX1WbfVv8 32EsSa3dlM6xnfpzvtWy8+wggBgXp42xnH/OkgIPKdGoduYIWtu7DCiOFIkKCncTdpwx TQsg== X-Gm-Message-State: ALoCoQn2Y37DDiUGaHaAHGdGC7U4OHzVcIZYq1+Z+GA2X8TOGQ3KbBMGY08imMZgPtYjUkelXeQD X-Received: by 10.43.156.13 with SMTP id lk13mr250902icc.29.1402574204407; Thu, 12 Jun 2014 04:56:44 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.23.7 with SMTP id 7ls3114639qgo.60.gmail; Thu, 12 Jun 2014 04:56:44 -0700 (PDT) X-Received: by 10.58.219.166 with SMTP id pp6mr45650605vec.1.1402574204290; Thu, 12 Jun 2014 04:56:44 -0700 (PDT) Received: from mail-ve0-f175.google.com (mail-ve0-f175.google.com [209.85.128.175]) by mx.google.com with ESMTPS id sw4si237026vdc.69.2014.06.12.04.56.44 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 12 Jun 2014 04:56:44 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.128.175 as permitted sender) client-ip=209.85.128.175; Received: by mail-ve0-f175.google.com with SMTP id us18so1630271veb.20 for ; Thu, 12 Jun 2014 04:56:44 -0700 (PDT) X-Received: by 10.58.29.198 with SMTP id m6mr44366953veh.15.1402574204162; Thu, 12 Jun 2014 04:56:44 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.221.54.6 with SMTP id vs6csp397124vcb; Thu, 12 Jun 2014 04:56:43 -0700 (PDT) X-Received: by 10.66.246.138 with SMTP id xw10mr20273931pac.142.1402574203345; Thu, 12 Jun 2014 04:56:43 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id bi1si6155337pbb.209.2014.06.12.04.56.42; Thu, 12 Jun 2014 04:56:42 -0700 (PDT) Received-SPF: none (google.com: linux-kernel-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933539AbaFLL4T (ORCPT + 27 others); Thu, 12 Jun 2014 07:56:19 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:32773 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933473AbaFLL4M (ORCPT ); Thu, 12 Jun 2014 07:56:12 -0400 Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by bear.ext.ti.com (8.13.7/8.13.7) with ESMTP id s5CBtg8K025205; Thu, 12 Jun 2014 06:55:42 -0500 Received: from DFLE72.ent.ti.com (dfle72.ent.ti.com [128.247.5.109]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id s5CBtgo9029219; Thu, 12 Jun 2014 06:55:42 -0500 Received: from dflp32.itg.ti.com (10.64.6.15) by DFLE72.ent.ti.com (128.247.5.109) with Microsoft SMTP Server id 14.3.174.1; Thu, 12 Jun 2014 06:55:41 -0500 Received: from uda0393807.india.ti.com. (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp32.itg.ti.com (8.14.3/8.13.8) with ESMTP id s5CBtEbr008910; Thu, 12 Jun 2014 06:55:38 -0500 From: Sricharan R To: , , , CC: , , , , , , , Subject: [PATCH V2 04/19] irqchip: crossbar: Initialise the crossbar with a safe value Date: Thu, 12 Jun 2014 17:23:12 +0530 Message-ID: <1402574007-13987-5-git-send-email-r.sricharan@ti.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1402574007-13987-1-git-send-email-r.sricharan@ti.com> References: <1402574007-13987-1-git-send-email-r.sricharan@ti.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: r.sricharan@ti.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.128.175 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , From: Nishanth Menon Since crossbar is s/w configurable, the initial settings of the crossbar cannot be assumed to be sane. This implies that: a) On initialization all un-reserved crossbars must be initialized to a known 'safe' value. b) When unmapping the interrupt, the safe value must be written to ensure that the crossbar mapping matches with interrupt controller usage. So provide a safe value in the compatible data to map if '0' is not safe for the platform and use it during init and unmap Signed-off-by: Nishanth Menon Signed-off-by: Sricharan R Signed-off-by: Tony Lindgren --- drivers/irqchip/irq-crossbar.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/drivers/irqchip/irq-crossbar.c b/drivers/irqchip/irq-crossbar.c index 847f6e3..287d3ce 100644 --- a/drivers/irqchip/irq-crossbar.c +++ b/drivers/irqchip/irq-crossbar.c @@ -44,6 +44,7 @@ struct crossbar_device { struct crossbar_data { const uint *irqs_unused; const uint size; + const uint safe_map; }; static struct crossbar_device *cb; @@ -134,7 +135,7 @@ const struct irq_domain_ops routable_irq_domain_ops = { static int __init crossbar_of_init(struct device_node *node, const struct crossbar_data *data) { - int i, size, max, reserved = 0, entry; + int i, size, max, reserved = 0, entry, safe_map; const __be32 *irqsr; const int *irqsk = NULL; @@ -212,6 +213,7 @@ static int __init crossbar_of_init(struct device_node *node, if (data) { irqsk = data->irqs_unused; size = data->size; + safe_map = data->safe_map; for (i = 0; i < size; i++) { entry = irqsk[i]; @@ -222,6 +224,14 @@ static int __init crossbar_of_init(struct device_node *node, } cb->irq_map[entry] = IRQ_SKIP; } + + for (i = 0; i < max; i++) { + if (cb->irq_map[i] == IRQ_RESERVED || + cb->irq_map[i] == IRQ_SKIP) + continue; + + cb->write(i, safe_map); + } } register_routable_domain_ops(&routable_irq_domain_ops); @@ -241,7 +251,7 @@ err1: /* irq number 10 cannot be used because of hw bug */ int dra_irqs_unused[] = { 10 }; struct crossbar_data cb_dra_data = { dra_irqs_unused, - ARRAY_SIZE(dra_irqs_unused) }; + ARRAY_SIZE(dra_irqs_unused), 0 }; static const struct of_device_id crossbar_match[] __initconst = { { .compatible = "ti,irq-crossbar", .data = &cb_dra_data },