From patchwork Thu Jun 12 11:53:25 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sricharan R X-Patchwork-Id: 31821 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-qc0-f200.google.com (mail-qc0-f200.google.com [209.85.216.200]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 0AAAB20AE6 for ; Thu, 12 Jun 2014 11:57:56 +0000 (UTC) Received: by mail-qc0-f200.google.com with SMTP id o8sf4277572qcw.11 for ; Thu, 12 Jun 2014 04:57:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe:content-type; bh=uKsZ4FgD5SGXS1mnIvQ/6AHkvcNxsP/L0hDqcMy5OWM=; b=PrNXxoSkeABtRRpac42HcIc6CUF6RA+asAh91uLCIINS9zstNnznzHidTStzKyqHDD sCrAmjjxSdboDRJd0W6Dv6GDG4rrvUO9yr+OGEc/pBb8vpun9U16Db8aBCmRLCJPuHNG 3NCm8UX2IXriznb1qR5grNdHEKn1GxkNkE1APNPfiI52wOX/SN68knipEitXIhwdijt2 l+TWdlNz5gWlVO5xSDnzLjaTNV4q+KhHgEWWltu2eoVFOQqogpVqi2VrA1FUbpjG6WBo cTJYW60xAjpBfU51dzhsr7BItzAA+hBT3Kr5N91uGWlef1QExG5xM68WeVbzDMIjHaCr pJQQ== X-Gm-Message-State: ALoCoQkvD2j1Bszk7Si7I9D8NluOH7+brYABMj+27Ic/P8HpoMIw5h8aVIdw3VghC4J+yByh0lnM X-Received: by 10.58.225.225 with SMTP id rn1mr2159123vec.5.1402574276688; Thu, 12 Jun 2014 04:57:56 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.26.183 with SMTP id 52ls2968144qgv.15.gmail; Thu, 12 Jun 2014 04:57:56 -0700 (PDT) X-Received: by 10.52.159.226 with SMTP id xf2mr8030736vdb.14.1402574276555; Thu, 12 Jun 2014 04:57:56 -0700 (PDT) Received: from mail-vc0-f172.google.com (mail-vc0-f172.google.com [209.85.220.172]) by mx.google.com with ESMTPS id r1si244010vcx.25.2014.06.12.04.57.56 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 12 Jun 2014 04:57:56 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.172 as permitted sender) client-ip=209.85.220.172; Received: by mail-vc0-f172.google.com with SMTP id hy10so672601vcb.3 for ; Thu, 12 Jun 2014 04:57:56 -0700 (PDT) X-Received: by 10.220.12.66 with SMTP id w2mr43631564vcw.15.1402574276421; Thu, 12 Jun 2014 04:57:56 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.221.54.6 with SMTP id vs6csp397192vcb; Thu, 12 Jun 2014 04:57:56 -0700 (PDT) X-Received: by 10.69.17.66 with SMTP id gc2mr12101129pbd.90.1402574275677; Thu, 12 Jun 2014 04:57:55 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id mm9si41313033pbc.151.2014.06.12.04.57.55; Thu, 12 Jun 2014 04:57:55 -0700 (PDT) Received-SPF: none (google.com: devicetree-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755696AbaFLL5y (ORCPT + 8 others); Thu, 12 Jun 2014 07:57:54 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:32848 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933831AbaFLL5H (ORCPT ); Thu, 12 Jun 2014 07:57:07 -0400 Received: from dflxv15.itg.ti.com ([128.247.5.124]) by bear.ext.ti.com (8.13.7/8.13.7) with ESMTP id s5CBufVo025282; Thu, 12 Jun 2014 06:56:41 -0500 Received: from DLEE71.ent.ti.com (dlee71.ent.ti.com [157.170.170.114]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id s5CBufA9023732; Thu, 12 Jun 2014 06:56:41 -0500 Received: from dflp32.itg.ti.com (10.64.6.15) by DLEE71.ent.ti.com (157.170.170.114) with Microsoft SMTP Server id 14.3.174.1; Thu, 12 Jun 2014 06:56:40 -0500 Received: from uda0393807.india.ti.com. (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp32.itg.ti.com (8.14.3/8.13.8) with ESMTP id s5CBtEc6008910; Thu, 12 Jun 2014 06:56:37 -0500 From: Sricharan R To: , , , CC: , , , , , , , Subject: [PATCH V2 17/19] irqchip: crossbar: introduce centralized check for crossbar write Date: Thu, 12 Jun 2014 17:23:25 +0530 Message-ID: <1402574007-13987-18-git-send-email-r.sricharan@ti.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1402574007-13987-1-git-send-email-r.sricharan@ti.com> References: <1402574007-13987-1-git-send-email-r.sricharan@ti.com> MIME-Version: 1.0 Sender: devicetree-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: devicetree@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: r.sricharan@ti.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.172 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , From: Nishanth Menon This is a basic check to ensure that crossbar register needs to be written. This ensures that we have a common check which is used in both map and unmap logic. Signed-off-by: Nishanth Menon --- drivers/irqchip/irq-crossbar.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/drivers/irqchip/irq-crossbar.c b/drivers/irqchip/irq-crossbar.c index cf69c4d..745ad0a 100644 --- a/drivers/irqchip/irq-crossbar.c +++ b/drivers/irqchip/irq-crossbar.c @@ -96,10 +96,20 @@ static inline int allocate_free_irq(int cb_no) return -ENODEV; } +static inline bool needs_crossbar_write(irq_hw_number_t hw) +{ + if (hw > GIC_IRQ_START) + return true; + + return false; +} + static int crossbar_domain_map(struct irq_domain *d, unsigned int irq, irq_hw_number_t hw) { - cb->write(hw - GIC_IRQ_START, cb->irq_map[hw - GIC_IRQ_START]); + if (needs_crossbar_write(hw)) + cb->write(hw - GIC_IRQ_START, cb->irq_map[hw - GIC_IRQ_START]); + return 0; } @@ -117,7 +127,7 @@ static void crossbar_domain_unmap(struct irq_domain *d, unsigned int irq) { irq_hw_number_t hw = irq_get_irq_data(irq)->hwirq; - if (hw > GIC_IRQ_START) + if (needs_crossbar_write(hw)) cb->irq_map[hw - GIC_IRQ_START] = IRQ_FREE; }